Attention is currently required from: Kevin Chiu, Daniel Kurtz, Martin Roth, Akshu Agrawal, Paul Menzel, Aaron Durbin.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51659 )
Change subject: google/grunt: Add ALC5682 ACPI I2S machine driver
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
martin/djkurtz/akshu - can you please take a look?
--
To view, visit https://review.coreboot.org/c/coreboot/+/51659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f29a2d784a9fc749fff61a9c96c0a487b71a2d7
Gerrit-Change-Number: 51659
Gerrit-PatchSet: 6
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Akshu Agrawal <akshu.agrawal(a)amd.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 18:09:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Justin Frodsham, Raul Rangel, Marshall Dawson, Matt Papageorge.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 )
Change subject: vc/amd/fsp/cezanne: add platform_descriptors.h
......................................................................
Patch Set 11:
(3 comments)
File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/51197/comment/a48e4df3_7a00d17c
PS10, Line 37: SPDC_DISBLED
> _DISABLED
Done
https://review.coreboot.org/c/coreboot/+/51197/comment/c5d8c6b1_cdec037b
PS10, Line 155: DDI_UNUSED_PTYPE
> DDI_UNUSED_TYPE
Done
File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/51197/comment/fefa4b07_32605075
PS2, Line 108: EDP_TO_LVDS, // eDP-to-LVDS translator chip without AMD SW init
> i'm not 100% sure about this and the next 3
this at least matches what is in agesa/fsp
--
To view, visit https://review.coreboot.org/c/coreboot/+/51197
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474
Gerrit-Change-Number: 51197
Gerrit-PatchSet: 11
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Justin Frodsham <justin.frodsham(a)protonmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Attention: Justin Frodsham <justin.frodsham(a)protonmail.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 16:55:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51948 )
Change subject: soc/amd/cezanne: Pass DXIO and DDI Descriptors to FSP
......................................................................
Patch Set 5:
(2 comments)
File src/soc/amd/cezanne/fsp_m_params.c:
https://review.coreboot.org/c/coreboot/+/51948/comment/5cb10d24_1c3425f6
PS5, Line 20: for (i = 0; i < num; i++) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/51948/comment/c99f71b0_440e0117
PS5, Line 33: for (i = 0; i < num; i++) {
braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/51948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cb36addcf0202cd56ce99e610a13d6d230bc981
Gerrit-Change-Number: 51948
Gerrit-PatchSet: 5
Gerrit-Owner: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 01 Apr 2021 16:54:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Marshall Dawson, Nikolai Vyssotski, Matt Papageorge.
Hello build bot (Jenkins), Matt Papageorge,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51957
to look at the new patch set (#4).
Change subject: [WIP] mb/google/guybrush: add DXIO and DDI descriptors
......................................................................
[WIP] mb/google/guybrush: add DXIO and DDI descriptors
TODO: The devices and function numbers of the PCIe bridges still need to
be verified.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Signed-off-by: Matt Papageorge <matthewpapa07(a)gmail.com>
Change-Id: Ic8a4349315f8759c79dc6b087b2a933c307cd573
---
M src/mainboard/google/guybrush/port_descriptors.c
1 file changed, 59 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/51957/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/51957
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8a4349315f8759c79dc6b087b2a933c307cd573
Gerrit-Change-Number: 51957
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-CC: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt Papageorge.
Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Matt Papageorge,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51956
to look at the new patch set (#4).
Change subject: [WIP] mb/amd/majolica: add DXIO and DDI descriptors
......................................................................
[WIP] mb/amd/majolica: add DXIO and DDI descriptors
TODO: The devices and function numbers of the PCIe bridges still need to
be verified.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Signed-off-by: Matt Papageorge <matthewpapa07(a)gmail.com>
Change-Id: I65c7e0ebf1e43fd4608d46bae8a176cfc3d0236b
---
M src/mainboard/amd/majolica/port_descriptors.c
1 file changed, 109 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/51956/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/51956
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65c7e0ebf1e43fd4608d46bae8a176cfc3d0236b
Gerrit-Change-Number: 51956
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Justin Frodsham, Raul Rangel, Matt Papageorge, Felix Held.
Hello build bot (Jenkins), Raul Rangel, Marshall Dawson, Matt Papageorge, Justin Frodsham,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51197
to look at the new patch set (#11).
Change subject: vc/amd/fsp/cezanne: add platform_descriptors.h
......................................................................
vc/amd/fsp/cezanne: add platform_descriptors.h
Not sure if CLK_GPP_REQx in cpm_clk_req are valid options; left a TODO
in the code for that.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474
---
A src/vendorcode/amd/fsp/cezanne/platform_descriptors.h
1 file changed, 223 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/51197/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/51197
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474
Gerrit-Change-Number: 51197
Gerrit-PatchSet: 11
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Justin Frodsham <justin.frodsham(a)protonmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Attention: Justin Frodsham <justin.frodsham(a)protonmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset