coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: [WIP] mb/google/guybrush: add DXIO and DDI descriptors
by Felix Held (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Marshall Dawson, Matt Papageorge, Felix Held. Hello build bot (Jenkins), Matt Papageorge, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51957 to look at the new patch set (#5). Change subject: [WIP] mb/google/guybrush: add DXIO and DDI descriptors ...................................................................... [WIP] mb/google/guybrush: add DXIO and DDI descriptors TODO: The devices and function numbers of the PCIe bridges still need to be verified to work. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Signed-off-by: Matt Papageorge <matthewpapa07(a)gmail.com> Change-Id: Ic8a4349315f8759c79dc6b087b2a933c307cd573 --- M src/mainboard/google/guybrush/port_descriptors.c 1 file changed, 71 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/51957/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/51957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8a4349315f8759c79dc6b087b2a933c307cd573 Gerrit-Change-Number: 51957 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP] mb/amd/majolica: add DXIO and DDI descriptors
by Felix Held (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt Papageorge. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Matt Papageorge, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51956 to look at the new patch set (#5). Change subject: [WIP] mb/amd/majolica: add DXIO and DDI descriptors ...................................................................... [WIP] mb/amd/majolica: add DXIO and DDI descriptors TODO: The devices and function numbers of the PCIe bridges still need to be tested. The values used in the Majolica UEFI reference implementation weren't consistent with the PPR. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Signed-off-by: Matt Papageorge <matthewpapa07(a)gmail.com> Change-Id: I65c7e0ebf1e43fd4608d46bae8a176cfc3d0236b --- M src/mainboard/amd/majolica/port_descriptors.c 1 file changed, 110 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/51956/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/51956 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65c7e0ebf1e43fd4608d46bae8a176cfc3d0236b Gerrit-Change-Number: 51956 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vc/amd/fsp/cezanne: add platform_descriptors.h
by Felix Held (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Justin Frodsham, Raul Rangel, Marshall Dawson, Felix Held. Hello build bot (Jenkins), Raul Rangel, Marshall Dawson, Nikolai Vyssotski, Matt Papageorge, Justin Frodsham, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51197 to look at the new patch set (#12). Change subject: vc/amd/fsp/cezanne: add platform_descriptors.h ...................................................................... vc/amd/fsp/cezanne: add platform_descriptors.h Not sure if CLK_GPP_REQx in cpm_clk_req are valid options; left a TODO in the code for that. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474 --- A src/vendorcode/amd/fsp/cezanne/platform_descriptors.h 1 file changed, 218 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/51197/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/51197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474 Gerrit-Change-Number: 51197 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lib: Add obvious definition for `calloc`
by Furquan Shaikh (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Tim Wawrzynczak. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51949 ) Change subject: lib: Add obvious definition for `calloc` ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57a568e323344a97b35014b7b8bec16adc2fd720 Gerrit-Change-Number: 51949 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:43:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Update VBT filenames
by Furquan Shaikh (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: YH Lin, Tim Wawrzynczak, Spoorthi K. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52032 ) Change subject: mb/intel/adlrvp: Update VBT filenames ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icefbac462d0ec9c660541e9cf44686d6dcf82dfd Gerrit-Change-Number: 52032 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Spoorthi K <spoorthi.k(a)intel.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Spoorthi K <spoorthi.k(a)intel.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:42:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Update VBT filenames
by Tim Wawrzynczak (Code Review) 01 Apr '21

01 Apr '21

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52032 ) Change subject: mb/intel/adlrvp: Update VBT filenames ...................................................................... mb/intel/adlrvp: Update VBT filenames These files were just renamed to put `adlrvp` in between `vbt` and the memory technology type. Change-Id: Icefbac462d0ec9c660541e9cf44686d6dcf82dfd Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/mainboard/intel/adlrvp/mainboard.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/52032/1 diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c index 3946204..0ab80d2 100644 --- a/src/mainboard/intel/adlrvp/mainboard.c +++ b/src/mainboard/intel/adlrvp/mainboard.c @@ -46,9 +46,9 @@ switch (sku_id) { case ADL_P_LP5_1: case ADL_P_LP5_2: - return "vbt_lp5.bin"; + return "vbt_adlrvp_lp5.bin"; case ADL_P_DDR5: - return "vbt_ddr5.bin"; + return "vbt_adlrvp_ddr5.bin"; default: return "vbt.bin"; } -- To view, visit https://review.coreboot.org/c/coreboot/+/52032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icefbac462d0ec9c660541e9cf44686d6dcf82dfd Gerrit-Change-Number: 52032 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: lib: Add obvious definition for `calloc`
by Jakub Czapiga (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Tim Wawrzynczak. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51949 ) Change subject: lib: Add obvious definition for `calloc` ...................................................................... Patch Set 8: Code-Review+1 (1 comment) Patchset: PS8: All I can do now is +1, but it looks good to me :) -- To view, visit https://review.coreboot.org/c/coreboot/+/51949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57a568e323344a97b35014b7b8bec16adc2fd720 Gerrit-Change-Number: 51949 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:39:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib: Add obvious definition for `calloc`
by Tim Wawrzynczak (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Jakub Czapiga. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51949 ) Change subject: lib: Add obvious definition for `calloc` ...................................................................... Patch Set 7: (1 comment) File tests/lib/malloc-test.c: https://review.coreboot.org/c/coreboot/+/51949/comment/683c9f2f_f03a2c8e PS7, Line 150: assert_true(*p == 0); > There is assert_int_equal(a, b) macro. Please use that instead. Sure, I'm new to these unit tests 😉 -- To view, visit https://review.coreboot.org/c/coreboot/+/51949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57a568e323344a97b35014b7b8bec16adc2fd720 Gerrit-Change-Number: 51949 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:35:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib: Add obvious definition for `calloc`
by Tim Wawrzynczak (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Tim Wawrzynczak. Hello build bot (Jenkins), Furquan Shaikh, Jakub Czapiga, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51949 to look at the new patch set (#8). Change subject: lib: Add obvious definition for `calloc` ...................................................................... lib: Add obvious definition for `calloc` The calloc() function is useful in addition to malloc and friends, so add the obvious definition. Change-Id: I57a568e323344a97b35014b7b8bec16adc2fd720 Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/include/stdlib.h M src/lib/malloc.c M tests/lib/malloc-test.c 3 files changed, 34 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/51949/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/51949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57a568e323344a97b35014b7b8bec16adc2fd720 Gerrit-Change-Number: 51949 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/jasperlake: Update CpuRatio settings
by Kaiyen Chang (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Kaiyen Chang, Patrick Rudolph. Hello build bot (Jenkins), Kaiyen Chang, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52029 to look at the new patch set (#3). Change subject: soc/intel/jasperlake: Update CpuRatio settings ...................................................................... soc/intel/jasperlake: Update CpuRatio settings An extra reset is observed on JSL platform while the flex ratio in CPU Straps is set to a non-zero value. The root cause is that the config of CpuRatio on JSL is fixed to zero in fsp_param.c. While FSP finds the value of CpuRatio from m_cfg is inconsistent with the value from CPU straps, it will invoke a system reset to apply the value from m_cfg. This change adds a mechanism to set CpuRatio to allowed maximum processor non-turbo ratio (from CPU straps) when cpu_ratio_override is not set, or overriding CpuRatio with the value of cpu_ratio_override when cpu_ratio_override is set to a non-zero value instead of just fixing CpuRatio to zero. BUG=b:181588337 BRANCH=None TEST=Boot JSL platform with a non-zero flex ratio set in CPU Straps and observe there is no extra reset in meminit while cpu_ratio_override is not set. Change-Id: I20b9d5620b8e394201e82185eb28b67d6702b2d5 Signed-off-by: Kaiyen Chang <kaiyen.chang(a)intel.corp-partner.google.com> --- M src/soc/intel/jasperlake/romstage/fsp_params.c 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/52029/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20b9d5620b8e394201e82185eb28b67d6702b2d5 Gerrit-Change-Number: 52029 Gerrit-PatchSet: 3 Gerrit-Owner: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Reviewer: Kaiyen Chang <kaiyen.chang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021