coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: mb/intel/adlrvp: Update VBT filenames
by YH Lin (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Tim Wawrzynczak, Spoorthi K. YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52032 ) Change subject: mb/intel/adlrvp: Update VBT filenames ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icefbac462d0ec9c660541e9cf44686d6dcf82dfd Gerrit-Change-Number: 52032 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Spoorthi K <spoorthi.k(a)intel.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Spoorthi K <spoorthi.k(a)intel.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:55:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: adlrvp: fix the names of vbt files
by YH Lin (Code Review) 01 Apr '21

01 Apr '21

YH Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/52033 ) Change subject: adlrvp: fix the names of vbt files ...................................................................... Abandoned https://review.coreboot.org/c/coreboot/+/52032 is already in place. -- To view, visit https://review.coreboot.org/c/coreboot/+/52033 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I94f60d5a5ba718d83046d08e9e1dc9163bb6411d Gerrit-Change-Number: 52033 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: adlrvp: fix the names of vbt files
by YH Lin (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: YH Lin. Hello YH Lin, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/52033 to review the following change. Change subject: adlrvp: fix the names of vbt files ...................................................................... adlrvp: fix the names of vbt files Cope with change of file names. BUG=None BRANCH=master TEST=build with adlrvp Signed-off-by: YH Lin <yueherngl(a)chromium.org> Change-Id: I94f60d5a5ba718d83046d08e9e1dc9163bb6411d --- M src/mainboard/intel/adlrvp/mainboard.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/52033/1 diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c index 3946204..0ab80d2 100644 --- a/src/mainboard/intel/adlrvp/mainboard.c +++ b/src/mainboard/intel/adlrvp/mainboard.c @@ -46,9 +46,9 @@ switch (sku_id) { case ADL_P_LP5_1: case ADL_P_LP5_2: - return "vbt_lp5.bin"; + return "vbt_adlrvp_lp5.bin"; case ADL_P_DDR5: - return "vbt_ddr5.bin"; + return "vbt_adlrvp_ddr5.bin"; default: return "vbt.bin"; } -- To view, visit https://review.coreboot.org/c/coreboot/+/52033 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I94f60d5a5ba718d83046d08e9e1dc9163bb6411d Gerrit-Change-Number: 52033 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede: add lalala variant
by Aaron Durbin (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Martin Roth, Paul Menzel, Aseda Aboagye. Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52031 ) Change subject: mb/google/dedede: add lalala variant ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/dedede/variants/lalala/overridetree.cb: https://review.coreboot.org/c/coreboot/+/52031/comment/c5d9e856_acd50305 PS2, Line 301: chip drivers/wifi/generic : register "wake" = "GPE0_DW2_03" : device pci 00.0 on end : end > Is it using Discrete WiFi? If not, this can be removed. I was following magolor. -- To view, visit https://review.coreboot.org/c/coreboot/+/52031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f7abb9637cd5a13ac896396781b19feb156c948 Gerrit-Change-Number: 52031 Gerrit-PatchSet: 2 Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:50:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/assert.h: Use mock_assert() for ENV_TEST targets
by Paul Fagerburg (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros. Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51804 ) Change subject: include/assert.h: Use mock_assert() for ENV_TEST targets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e8dd1b198ee6fab61e2be3f92baf1178f79bf18 Gerrit-Change-Number: 51804 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:50:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/rules.h: Add ENV_TEST definition
by Paul Fagerburg (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Martin Roth, Jakub Czapiga, Julius Werner, Jan Dabros. Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51803 ) Change subject: include/rules.h: Add ENV_TEST definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8f2932902a73a7dbe181adc82cc18437abb48e8 Gerrit-Change-Number: 51803 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:49:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] mb/amd/majolica: add DXIO and DDI descriptors
by Felix Held (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt Papageorge. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51956 ) Change subject: [WIP] mb/amd/majolica: add DXIO and DDI descriptors ...................................................................... Patch Set 5: (2 comments) File src/mainboard/amd/majolica/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/51956/comment/cca11185_77200cf8 PS3, Line 12: device_number = 2 > haven't checked if that's correct for the mainboard, but this should indeed be on device 1, since it […] Done https://review.coreboot.org/c/coreboot/+/51956/comment/cc7e276d_0beee835 PS3, Line 23: device_number = 1, > yes, this should be behind some function of device 2 on bus 0. […] done, but untested -- To view, visit https://review.coreboot.org/c/coreboot/+/51956 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65c7e0ebf1e43fd4608d46bae8a176cfc3d0236b Gerrit-Change-Number: 51956 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:47:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne: Pass DXIO and DDI Descriptors to FSP
by build bot (Jenkins) (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Martin Roth, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51948 ) Change subject: soc/amd/cezanne: Pass DXIO and DDI Descriptors to FSP ...................................................................... Patch Set 6: (2 comments) File src/soc/amd/cezanne/fsp_m_params.c: https://review.coreboot.org/c/coreboot/+/51948/comment/04210bed_4f1148c7 PS6, Line 20: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks https://review.coreboot.org/c/coreboot/+/51948/comment/a21f7104_e885a3e4 PS6, Line 33: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/c/coreboot/+/51948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cb36addcf0202cd56ce99e610a13d6d230bc981 Gerrit-Change-Number: 51948 Gerrit-PatchSet: 6 Gerrit-Owner: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:47:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/amd/fsp/cezanne: update UPD headers
by Felix Held (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Marshall Dawson, Paul Menzel, Matt Papageorge. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51806 ) Change subject: vc/amd/fsp/cezanne: update UPD headers ...................................................................... Patch Set 8: (1 comment) File src/vendorcode/amd/fsp/cezanne/FspmUpd.h: https://review.coreboot.org/c/coreboot/+/51806/comment/ee115ed5_bdaa88c4 PS7, Line 15: /** Offset 0x0040**/ uint32_t bert_size; > We could take over 0x40 for version. […] yeah, that would be a good idea to check if the upd is still compatible. iirc i opened a bug on that when working on zork -- To view, visit https://review.coreboot.org/c/coreboot/+/51806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idca235029bf2e68d403230d55308820cab61a6c0 Gerrit-Change-Number: 51806 Gerrit-PatchSet: 8 Gerrit-Owner: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:47:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/amd/fsp/cezanne: add platform_descriptors.h
by Felix Held (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Justin Frodsham, Raul Rangel, Marshall Dawson, Matt Papageorge. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 ) Change subject: vc/amd/fsp/cezanne: add platform_descriptors.h ...................................................................... Patch Set 11: (3 comments) File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h: https://review.coreboot.org/c/coreboot/+/51197/comment/254d6f6b_ee77cab5 PS10, Line 196: Currently unused by FSP > Based on Matt's comment, I infer this should change too. this is mostly a copy of PlatformHooksPeim.h. that struct field gets copied into some other data structure, but haven't further traced that data flow File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h: https://review.coreboot.org/c/coreboot/+/51197/comment/aa808259_456f3019 PS7, Line 179: port_params > in short token and value pairs. […] added a comment File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h: https://review.coreboot.org/c/coreboot/+/51197/comment/5770845d_ed6f70c0 PS4, Line 57: CLK_GPP_REQ0 = 0x09, > added a TODO the uefi reference implementation doesn't have those, so i remove them -- To view, visit https://review.coreboot.org/c/coreboot/+/51197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474 Gerrit-Change-Number: 51197 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 21:46:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com> Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com> Comment-In-Reply-To: Matt Papageorge <matthewpapa07(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021