Attention is currently required from: Martin Roth, Paul Fagerburg, Julius Werner, Jan Dabros.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51976 )
Change subject: tests: Add lib/uuid-test test case
......................................................................
Patch Set 3:
(1 comment)
File tests/lib/uuid-test.c:
https://review.coreboot.org/c/coreboot/+/51976/comment/835b6045_83afe490
PS2, Line 83: assert_int_equal(guid.b[7] - guid_copy.b[7]
> would this be better as "assert_int_not_equal(0," so that you're just checking that the compare fail […]
You are right. I was convinced that it really does return exact difference. I looked into documentation and it gives no guarantee of that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51976
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f8498ad3d9d0d68b34aa0b48daca60545ec3f4e
Gerrit-Change-Number: 51976
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 08:04:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Jakub Czapiga, Julius Werner, Jan Dabros.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Fagerburg, Julius Werner, Jan Dabros,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51976
to look at the new patch set (#3).
Change subject: tests: Add lib/uuid-test test case
......................................................................
tests: Add lib/uuid-test test case
Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com>
Change-Id: I7f8498ad3d9d0d68b34aa0b48daca60545ec3f4e
---
M tests/lib/Makefile.inc
A tests/lib/uuid-test.c
2 files changed, 99 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/51976/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/51976
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f8498ad3d9d0d68b34aa0b48daca60545ec3f4e
Gerrit-Change-Number: 51976
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Rizwan Qureshi, Subrata Banik.
Hello build bot (Jenkins), Rizwan Qureshi, Angel Pons, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50265
to look at the new patch set (#22).
Change subject: mb/intel/adlrvp: Enable Camera in ADL-M RVP
......................................................................
mb/intel/adlrvp: Enable Camera in ADL-M RVP
1. Configure Power Enable, Reset and Clock GPIO for both camera
2. Use same ASL code as ADL-P RVP
Configure RST, PWR_EN and IMGCLKOUT signals for WFC and UFC
TEST=Build, Boot and Verify streaming in both Camera
Signed-off-by: Varshit Pandya <varshit.b.pandya(a)intel.com>
Change-Id: I70636eaa8d9bdf23d649e811b3ff4f33b1bc604e
---
M src/mainboard/intel/adlrvp/gpio_m.c
1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/50265/22
--
To view, visit https://review.coreboot.org/c/coreboot/+/50265
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70636eaa8d9bdf23d649e811b3ff4f33b1bc604e
Gerrit-Change-Number: 50265
Gerrit-PatchSet: 22
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-CC: Thejaswani Putta <thejaswani.putta(a)intel.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Justin van Son, Christian Walter.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51919 )
Change subject: mb/prodrive/hermes: Drop Vref configuration for older boards
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/51919/comment/fc3c4b2d_db85724c
PS1, Line 42: return AZALIA_PIN_DESC(
> The driver won't detect a valid pin configuration when AZALIA_PIN_DESC is used. […]
Should this use a separate association? Maybe 0x4 instead of 0xf?
Other verb tables set the type to ANALOG instead of UNKNOWN.
No_presence_detect should be true.
https://review.coreboot.org/c/coreboot/+/51919/comment/ab8684e5_630b9773
PS1, Line 69: 0x018707e1, /* port B VREF 50% of LDO-OUT */
> You don't need any of the 707 verbs, as they will get reset by realtek driver anyway
will drop them here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41c207f97dad6c9107c1999eb46d2d6304a6c217
Gerrit-Change-Number: 51919
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 07:46:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-MessageType: comment
Attention is currently required from: Chen-Tsung Hsieh, jitao shi, Shaoming Chen, Jitao Shi.
Chen-Tsung Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51432 )
Change subject: soc/mediatek: dsi: fine tune the delta time for EoTp
......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/51432/comment/e5db6080_5f97371d
PS2, Line 207: 10
> The effect is the same with MIPI_DSI_MODE_EOT_PACKET, 12 byte also.
For Jacuzzi projects, yes you keep it as 12.
But for Kukui projects (NOT using anx7625, NOT enable MIPI_DSI_MODE_EOT_PACKET),
Do we really expect to change it from 12 to 10?
According to the report from analogix, enabling EOTP doesn't always increate 2 bytes, sometimes only 1 byte. So we decide NOT to change timing based on MIPI_DSI_MODE_EOT_PACKET.
I thought the proposed fix from analogix is:
u32 delta = 12;
- if (mode_flags & MIPI_DSI_MODE_EOT_PACKET)
- delta += 2;
-
On the other hand, I checked the driver in kernel.
You use 18 or 12 for the delta according to MIPI_DSI_MODE_VIDEO_BURST.
Without checking MIPI_DSI_MODE_EOT_PACKET.
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/head…:
static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi)
{
...
if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) {
if ((vm->hfront_porch + vm->hback_porch) * dsi_tmp_buf_bpp >
data_phy_cycles * dsi->lanes + 18) {
...
}
} else {
if ((vm->hfront_porch + vm->hback_porch) * dsi_tmp_buf_bpp >
data_phy_cycles * dsi->lanes + 12) {
...
}
}
...
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/51432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0666068cfb04b78eb706278814163f050da32b9c
Gerrit-Change-Number: 51432
Gerrit-PatchSet: 5
Gerrit-Owner: jitao shi <jitao.shi(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)chromium.org>
Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)google.com>
Gerrit-CC: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com>
Gerrit-CC: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org>
Gerrit-Attention: jitao shi <jitao.shi(a)mediatek.com>
Gerrit-Attention: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 07:45:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chen-Tsung Hsieh <chentsung(a)google.com>
Comment-In-Reply-To: Chen-Tsung Hsieh <chentsung(a)chromium.org>
Comment-In-Reply-To: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com>
Comment-In-Reply-To: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51919 )
Change subject: mb/prodrive/hermes: Drop Vref configuration for older boards
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/51919/comment/23503071_8dd57ff0
PS1, Line 42: return AZALIA_PIN_DESC(
> The driver won't detect a valid pin configuration when AZALIA_PIN_DESC is used. […]
Which hex value should be used here? I suspect the values in the AZALIA_PIN_DESC macro aren't correct.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41c207f97dad6c9107c1999eb46d2d6304a6c217
Gerrit-Change-Number: 51919
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 07:44:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51919 )
Change subject: mb/prodrive/hermes: Drop Vref configuration for older boards
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/51919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41c207f97dad6c9107c1999eb46d2d6304a6c217
Gerrit-Change-Number: 51919
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 07:43:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Julius Werner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51551 )
Change subject: lint: checkpatch: Ignore ASSIGN_IN_IF and UNNECESSARY_ELSE errors
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51551
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I130598057c1800277a129ae6b927e961d6e26e42
Gerrit-Change-Number: 51551
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 07:42:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51949 )
Change subject: lib: Add obvious definition for `calloc`
......................................................................
Patch Set 7:
(1 comment)
File tests/lib/malloc-test.c:
https://review.coreboot.org/c/coreboot/+/51949/comment/4df6091f_f6a2d316
PS7, Line 150: assert_true(*p == 0);
There is assert_int_equal(a, b) macro. Please use that instead.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57a568e323344a97b35014b7b8bec16adc2fd720
Gerrit-Change-Number: 51949
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 07:40:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment