coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: soc/intel/alderlake: Enable RMT
by EricR Lai (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52012 ) Change subject: soc/intel/alderlake: Enable RMT ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @Furquan, do you thimnk it okay to keep this in soc code? -- To view, visit https://review.coreboot.org/c/coreboot/+/52012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I509671714bb779b44ce1bffa9b6ab7bc217fdcc4 Gerrit-Change-Number: 52012 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 04:47:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Enable RMT
by EricR Lai (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Sridhar Siricilla, Patrick Rudolph. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52012 ) Change subject: soc/intel/alderlake: Enable RMT ...................................................................... Patch Set 1: (4 comments) File src/soc/intel/alderlake/romstage/fsp_params.c: https://review.coreboot.org/c/coreboot/+/52012/comment/84aeea5e_c1369a6b PS1, Line 73: m_cfg->SaGv = config->SaGv; or we can use if(config->RMT){ } https://review.coreboot.org/c/coreboot/+/52012/comment/a5498835_f5e44e7c PS1, Line 74: m_cfg->RMT = 1; config->RMT https://review.coreboot.org/c/coreboot/+/52012/comment/bf474111_a0b1b9c5 PS1, Line 75: m_cfg->RMTBIT = 1; config->RMT https://review.coreboot.org/c/coreboot/+/52012/comment/c0c83ecb_58f71eda PS1, Line 76: m_cfg->MrcFastBoot = 0; !config->RMT -- To view, visit https://review.coreboot.org/c/coreboot/+/52012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I509671714bb779b44ce1bffa9b6ab7bc217fdcc4 Gerrit-Change-Number: 52012 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 04:46:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Enable Camera in ADL-M RVP
by Varshit B Pandya (Code Review) 01 Apr '21

01 Apr '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50265 to look at the new patch set (#21). Change subject: mb/intel/adlrvp: Enable Camera in ADL-M RVP ...................................................................... mb/intel/adlrvp: Enable Camera in ADL-M RVP 1. Configure Power Enable, Reset and Clock GPIO for both camera 2. Use same ASL code as ADL-P RVP Configure RST, PWR_EN and IMGCLKOUT signals for WFC and UFC Signed-off-by: Varshit Pandya <varshit.b.pandya(a)intel.com> Change-Id: I70636eaa8d9bdf23d649e811b3ff4f33b1bc604e --- M src/mainboard/intel/adlrvp/gpio_m.c 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/50265/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/50265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70636eaa8d9bdf23d649e811b3ff4f33b1bc604e Gerrit-Change-Number: 50265 Gerrit-PatchSet: 21 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lint: checkpatch: Ignore ASSIGN_IN_IF and UNNECESSARY_ELSE errors
by Werner Zeh (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Martin Roth, Julius Werner. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51551 ) Change subject: lint: checkpatch: Ignore ASSIGN_IN_IF and UNNECESSARY_ELSE errors ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51551/comment/62e51283_4063b321 PS3, Line 50: programmer > "their" is the appropriate pronoun for an unspecified singular individual in English (because you do […] OK, I wasn't aware. Thank you for the link. -- To view, visit https://review.coreboot.org/c/coreboot/+/51551 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I130598057c1800277a129ae6b927e961d6e26e42 Gerrit-Change-Number: 51551 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 04:34:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/drivers/generic/nau8315: Add nau8315 support
by EricR Lai (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Mac Chiang, leeweitse_seven, Martin Roth, Furquan Shaikh, Tim Wawrzynczak, John Hsu, David Lin. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51971 ) Change subject: src/drivers/generic/nau8315: Add nau8315 support ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: please check you file premission... -rw-r--r-- again -- To view, visit https://review.coreboot.org/c/coreboot/+/51971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie883d65ced3cd95fe318ba0914ed806ff592258d Gerrit-Change-Number: 51971 Gerrit-PatchSet: 3 Gerrit-Owner: leeweitse_seven <scott.6986(a)hotmail.com> Gerrit-Reviewer: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: leeweitse_seven <scott.6986(a)hotmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 04:16:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/drivers/generic/nau8315: Add nau8315 support
by EricR Lai (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Mac Chiang, leeweitse_seven, Martin Roth, Furquan Shaikh, Tim Wawrzynczak, John Hsu, David Lin. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51971 ) Change subject: src/drivers/generic/nau8315: Add nau8315 support ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/drivers/generic/nau8315/nau8315.c: https://review.coreboot.org/c/coreboot/+/51971/comment/66c6065c_9031e8cc PS3, Line 58: return NAU8315_ACPI_NAME; we can return string here, remove the define. -- To view, visit https://review.coreboot.org/c/coreboot/+/51971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie883d65ced3cd95fe318ba0914ed806ff592258d Gerrit-Change-Number: 51971 Gerrit-PatchSet: 3 Gerrit-Owner: leeweitse_seven <scott.6986(a)hotmail.com> Gerrit-Reviewer: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: leeweitse_seven <scott.6986(a)hotmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 04:16:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/kukui: fix the issue of getting error panel_id
by Yu-Ping Wu (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Hung-Te Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51853 ) Change subject: mb/google/kukui: fix the issue of getting error panel_id ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51853 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I63e0c8a2719462a9b979afe52a27c78b9fc804e8 Gerrit-Change-Number: 51853 Gerrit-PatchSet: 3 Gerrit-Owner: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 04:03:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Enable RMT
by Sridhar Siricilla (Code Review) 01 Apr '21

01 Apr '21

Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52012 ) Change subject: soc/intel/alderlake: Enable RMT ...................................................................... soc/intel/alderlake: Enable RMT This patch modifies RMT UPDs in order to run RMT logic in FSP-M. Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I509671714bb779b44ce1bffa9b6ab7bc217fdcc4 --- M src/soc/intel/alderlake/romstage/fsp_params.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/52012/1 diff --git a/src/soc/intel/alderlake/romstage/fsp_params.c b/src/soc/intel/alderlake/romstage/fsp_params.c index 3852467..62811b3 100644 --- a/src/soc/intel/alderlake/romstage/fsp_params.c +++ b/src/soc/intel/alderlake/romstage/fsp_params.c @@ -71,7 +71,9 @@ m_cfg->TsegSize = CONFIG_SMM_TSEG_SIZE; m_cfg->SaGv = config->SaGv; - m_cfg->RMT = config->RMT; + m_cfg->RMT = 1; + m_cfg->RMTBIT = 1; + m_cfg->MrcFastBoot = 0; /* CpuRatio Settings */ if (config->cpu_ratio_override) -- To view, visit https://review.coreboot.org/c/coreboot/+/52012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I509671714bb779b44ce1bffa9b6ab7bc217fdcc4 Gerrit-Change-Number: 52012 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: coreboot_tables: Print strapping IDs when adding them to coreboot table
by Tim Wawrzynczak (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Furquan Shaikh, Julius Werner. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52011 ) Change subject: coreboot_tables: Print strapping IDs when adding them to coreboot table ...................................................................... Patch Set 1: (2 comments) File src/lib/coreboot_table.c: https://review.coreboot.org/c/coreboot/+/52011/comment/9758d8c7_ccc26278 PS1, Line 308: uint64_t fw_config = fw_config_get(); nit: const https://review.coreboot.org/c/coreboot/+/52011/comment/232f3196_4d062c2b PS1, Line 321: llx PRIx64 -- To view, visit https://review.coreboot.org/c/coreboot/+/52011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdbfdd29d25a0937c27113ace776f7aec231a57d Gerrit-Change-Number: 52011 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 03:34:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Enable early EC Software Sync
by Raul Rangel (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52009 ) Change subject: mb/google/guybrush: Enable early EC Software Sync ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52009 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8655b6f805e14ce3cb71777c1cc175f45841fcc Gerrit-Change-Number: 52009 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 02:14:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021