Change in coreboot[master]: arch/x86: Reserve space for EC SMSC KBC1098/KBC1126

[Iru Cai (vimacs) (Code Review)]

Attention is currently required from: Bill XIE, Julius Werner.
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51671 )

Change subject: arch/x86: Reserve space for EC SMSC KBC1098/KBC1126
......................................................................


Patch Set 1: -Code-Review

(2 comments)

Patchset:

PS1: 
Hmm, I think the code will get complicated if there are more things to add.


File src/arch/x86/bootblock.ld:

https://review.coreboot.org/c/coreboot/+/51671/comment/8b2e4286_a9d1660d 
PS1, Line 35: MIN(_KBC1126_FW_LOCATIONS, MIN(_ID_SECTION, _FIT_POINTER)) - EARLYASM_SZ;
Hmm, the code will have more ``#if CONFIG(...)`` and ``MIN(...)`` to add if there're more things to add, so using one _ECFW_POINTER like in 51059 may be a better way to do this.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51671
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f0de0c4d7283e630242fbe84a46e0547783c49e
Gerrit-Change-Number: 51671
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE <[e-mail]>
Gerrit-Reviewer: Iru Cai (vimacs) <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Bill XIE <[e-mail]>
Gerrit-Attention: Julius Werner <[e-mail]>
Gerrit-Comment-Date: Thu, 01 Apr 2021 06:43:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment