coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
5704 discussions

Change in coreboot[master]: soc/amd/picasso: Add entry for PSP NVRAM data & RPMC data
by ritul guru (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held. ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51836 ) Change subject: soc/amd/picasso: Add entry for PSP NVRAM data & RPMC data ...................................................................... Patch Set 8: (1 comment) File src/soc/amd/picasso/fw.cfg: https://review.coreboot.org/c/coreboot/+/51836/comment/894be076_f32ad972 PS8, Line 9: PSPNVRAM_FILE > We can access by Firmware type ID. RPMC is 0x54. PSP_NVRAM is 4. […] i mean, will it be still part of cbfs? how it can be located in fmap.c? , -- To view, visit https://review.coreboot.org/c/coreboot/+/51836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e0c9d651b7c544eabbed8acc0d26ae55960ca3f Gerrit-Change-Number: 51836 Gerrit-PatchSet: 8 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 01 Apr 2021 14:28:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Comment-In-Reply-To: ritul guru <ritul.bits(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/picasso: Add entry for PSP NVRAM data & RPMC data
by Bao Zheng (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, ritul guru, Marshall Dawson, Zheng Bao, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51836 ) Change subject: soc/amd/picasso: Add entry for PSP NVRAM data & RPMC data ...................................................................... Patch Set 8: (1 comment) File src/soc/amd/picasso/fw.cfg: https://review.coreboot.org/c/coreboot/+/51836/comment/5c67fe7e_42285acd PS8, Line 9: PSPNVRAM_FILE > How will we access these regions without names? like RPMC/PSP_NVRAM region is read/write, when acces […] We can access by Firmware type ID. RPMC is 0x54. PSP_NVRAM is 4. (I dont quite understand the question and not sure if I answer the question). -- To view, visit https://review.coreboot.org/c/coreboot/+/51836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e0c9d651b7c544eabbed8acc0d26ae55960ca3f Gerrit-Change-Number: 51836 Gerrit-PatchSet: 8 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 01 Apr 2021 14:17:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ritul guru <ritul.bits(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/facebook/fbg1701/vboot-rw.fmd: Expand RO_SECTION
by Wim Vervoorn (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Frans Hendriks. Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52026 ) Change subject: mb/facebook/fbg1701/vboot-rw.fmd: Expand RO_SECTION ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f1020acb3ec99d4cddbaa05b0998fe32b470d3e Gerrit-Change-Number: 52026 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 13:43:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed()
by Frans Hendriks (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Wim Vervoorn. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52025 ) Change subject: vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed() ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52025/comment/54ddc2e8_053d28e4 PS1, Line 16: of compressed files. For non-compressed items the > This sentence is not complete Done. -- To view, visit https://review.coreboot.org/c/coreboot/+/52025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc799f49ee198100deab1ecf66336831d9aed415 Gerrit-Change-Number: 52025 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 12:54:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed()
by Frans Hendriks (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Frans Hendriks. Hello Wim Vervoorn, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52025 to look at the new patch set (#2). Change subject: vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed() ...................................................................... vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed() CB:49334 removes possibility to use cbfs_map() for retrieving CBFS map info of compressed files. cbfs_map() will return a NULL pointer for compressed files. The mapping and size of compressed items are used for verification and measuring. Add cbfs_map_compressed() to return mapping and compressed size of files. BUG = N/A TEST = Boot Facebook FBG7101 Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> Change-Id: Idc799f49ee198100deab1ecf66336831d9aed415 --- M src/vendorcode/eltan/security/verified_boot/vboot_check.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/52025/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc799f49ee198100deab1ecf66336831d9aed415 Gerrit-Change-Number: 52025 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/facebook/fbg1701/vboot-rw.fmd: Expand RO_SECTION
by Frans Hendriks (Code Review) 01 Apr '21

01 Apr '21

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52026 ) Change subject: mb/facebook/fbg1701/vboot-rw.fmd: Expand RO_SECTION ...................................................................... mb/facebook/fbg1701/vboot-rw.fmd: Expand RO_SECTION The romstage does not fit in RO_SECTION. Increase the CBFS size in RO_SECTION. BUG = N/A TEST = Boot Facebook FBG1701 with VBOOT enabled. Change-Id: I2f1020acb3ec99d4cddbaa05b0998fe32b470d3e Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M src/mainboard/facebook/fbg1701/vboot-rw.fmd 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/52026/1 diff --git a/src/mainboard/facebook/fbg1701/vboot-rw.fmd b/src/mainboard/facebook/fbg1701/vboot-rw.fmd index 51ee470..ae7312c 100644 --- a/src/mainboard/facebook/fbg1701/vboot-rw.fmd +++ b/src/mainboard/facebook/fbg1701/vboot-rw.fmd @@ -3,18 +3,18 @@ MISC_RW@0x0 0x08000 { RW_MRC_CACHE@0 0x08000 } - RW_SECTION_A@0x08000 0x578000 { + RW_SECTION_A@0x08000 0x568000 { VBLOCK_A@0x0 0x10000 RW_FWID_A@0x10000 0x40 - FW_MAIN_A(CBFS)@0x10040 0x567FC0 + FW_MAIN_A(CBFS)@0x10040 0x557FC0 } - WP_RO@0x580000 0x080000 { - RO_SECTION@0x0000 0x80000 { + WP_RO@0x570000 0x090000 { + RO_SECTION@0x0000 0x90000 { FMAP@0x0 0x400 RO_FRID@0xA00 0x40 RO_FRID_PAD@0xA40 0x5c0 GBB@0x1000 0x4000 - COREBOOT(CBFS)@0x5000 0x07B000 + COREBOOT(CBFS)@0x5000 0x08B000 } } } -- To view, visit https://review.coreboot.org/c/coreboot/+/52026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f1020acb3ec99d4cddbaa05b0998fe32b470d3e Gerrit-Change-Number: 52026 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/facebook/monolith: Remove disabled devices from devicetree
by Frans Hendriks (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Wim Vervoorn. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52018 ) Change subject: mb/facebook/monolith: Remove disabled devices from devicetree ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie67cd8afc9ea92e9fd7caed4338cb25a68d94cb1 Gerrit-Change-Number: 52018 Gerrit-PatchSet: 1 Gerrit-Owner: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 12:50:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed()
by Wim Vervoorn (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Frans Hendriks. Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52025 ) Change subject: vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed() ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52025/comment/94d69e7a_d0108cfa PS1, Line 16: of compressed files. For non-compressed items the This sentence is not complete -- To view, visit https://review.coreboot.org/c/coreboot/+/52025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc799f49ee198100deab1ecf66336831d9aed415 Gerrit-Change-Number: 52025 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 12:49:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed()
by Frans Hendriks (Code Review) 01 Apr '21

01 Apr '21

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52025 ) Change subject: vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed() ...................................................................... vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed() CB:49334 removes possibility to use cbfs_map() for retrieving CBFS map info of compressed files. cbfs_map() will return a NULL pointer for compressed files. The mapping and size of compressed items are used for verification and measuring. Add cbfs_map_compressed() which will return mapping and compressed size of compressed files. For non-compressed items the BUG = N/A TEST = Boot Facebook FBG7101 Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> Change-Id: Idc799f49ee198100deab1ecf66336831d9aed415 --- M src/vendorcode/eltan/security/verified_boot/vboot_check.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/52025/1 diff --git a/src/vendorcode/eltan/security/verified_boot/vboot_check.c b/src/vendorcode/eltan/security/verified_boot/vboot_check.c index 0de2f0a..6a27cad 100644 --- a/src/vendorcode/eltan/security/verified_boot/vboot_check.c +++ b/src/vendorcode/eltan/security/verified_boot/vboot_check.c @@ -3,6 +3,7 @@ #include <boot_device.h> #include <bootmem.h> #include <bootmode.h> +#include <cbfs_private.h> #include <cbfs.h> #include <vboot_check.h> #include <vboot_common.h> @@ -18,6 +19,20 @@ #define HASH_ALG VB2_HASH_SHA256 #endif +static void *cbfs_map_compressed(const char *name, size_t *size_out) +{ + struct region_device rdev; + union cbfs_mdata mdata; + + if (cbfs_boot_lookup(name, false, &mdata, &rdev)) + return NULL; + + if (size_out != NULL) + *size_out = region_device_sz(&rdev); + + return rdev_mmap_full(&rdev); +} + int verified_boot_check_manifest(void) { uint8_t *buffer; @@ -183,7 +198,7 @@ void *start; size_t size; - start = cbfs_map(name, &size); + start = cbfs_map_compressed(name, &size); if (start && size) { /* Speed up processing by copying the file content to memory first */ if (!ENV_ROMSTAGE_OR_BEFORE && (type & VERIFIED_BOOT_COPY_BLOCK)) { -- To view, visit https://review.coreboot.org/c/coreboot/+/52025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc799f49ee198100deab1ecf66336831d9aed415 Gerrit-Change-Number: 52025 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/prodrive/hermes: Properly pack EEPROM structures
by Name of user not set (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter, Angel Pons. wouter.eckhardt(a)prodrive-technologies.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51980 ) Change subject: mb/prodrive/hermes: Properly pack EEPROM structures ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/51980 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39d2c9ebc370605d5623b134189aa95a074ec7c3 Gerrit-Change-Number: 51980 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wouter.eckhardt(a)prodrive-technologies.com Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 12:37:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021