coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
5686 discussions

Change in coreboot[master]: vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed()

by Frans Hendriks (Code Review)

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52025 ) Change subject: vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed() ...................................................................... vc/eltan/security/verified_boot/vboot_check.c: Add cbfs_map_compressed() CB:49334 removes possibility to use cbfs_map() for retrieving CBFS map info of compressed files. cbfs_map() will return a NULL pointer for compressed files. The mapping and size of compressed items are used for verification and measuring. Add cbfs_map_compressed() which will return mapping and compressed size of compressed files. For non-compressed items the BUG = N/A TEST = Boot Facebook FBG7101 Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> Change-Id: Idc799f49ee198100deab1ecf66336831d9aed415 --- M src/vendorcode/eltan/security/verified_boot/vboot_check.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/52025/1 diff --git a/src/vendorcode/eltan/security/verified_boot/vboot_check.c b/src/vendorcode/eltan/security/verified_boot/vboot_check.c index 0de2f0a..6a27cad 100644 --- a/src/vendorcode/eltan/security/verified_boot/vboot_check.c +++ b/src/vendorcode/eltan/security/verified_boot/vboot_check.c @@ -3,6 +3,7 @@ #include <boot_device.h> #include <bootmem.h> #include <bootmode.h> +#include <cbfs_private.h> #include <cbfs.h> #include <vboot_check.h> #include <vboot_common.h> @@ -18,6 +19,20 @@ #define HASH_ALG VB2_HASH_SHA256 #endif +static void *cbfs_map_compressed(const char *name, size_t *size_out) +{ + struct region_device rdev; + union cbfs_mdata mdata; + + if (cbfs_boot_lookup(name, false, &mdata, &rdev)) + return NULL; + + if (size_out != NULL) + *size_out = region_device_sz(&rdev); + + return rdev_mmap_full(&rdev); +} + int verified_boot_check_manifest(void) { uint8_t *buffer; @@ -183,7 +198,7 @@ void *start; size_t size; - start = cbfs_map(name, &size); + start = cbfs_map_compressed(name, &size); if (start && size) { /* Speed up processing by copying the file content to memory first */ if (!ENV_ROMSTAGE_OR_BEFORE && (type & VERIFIED_BOOT_COPY_BLOCK)) { -- To view, visit https://review.coreboot.org/c/coreboot/+/52025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc799f49ee198100deab1ecf66336831d9aed415 Gerrit-Change-Number: 52025 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-MessageType: newchange

1 year, 2 months

Change in coreboot[master]: mb/prodrive/hermes: Properly pack EEPROM structures

by Name of user not set (Code Review)

Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter, Angel Pons. wouter.eckhardt(a)prodrive-technologies.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51980 ) Change subject: mb/prodrive/hermes: Properly pack EEPROM structures ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/51980 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39d2c9ebc370605d5623b134189aa95a074ec7c3 Gerrit-Change-Number: 51980 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wouter.eckhardt(a)prodrive-technologies.com Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 12:37:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

Change in coreboot[master]: vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT

by Wim Vervoorn (Code Review)

Attention is currently required from: Frans Hendriks. Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52021 ) Change subject: vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac57103431cc7efac5b6019f180572d255e683ab Gerrit-Change-Number: 52021 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 12:32:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

Change in coreboot[master]: include/cbfsglue.h: Use BIOS_INFO for LOG macro

by Frans Hendriks (Code Review)

Attention is currently required from: Julius Werner, Wim Vervoorn. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52019 ) Change subject: include/cbfsglue.h: Use BIOS_INFO for LOG macro ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3827a7d65a9d70045a36fb8db4b2c129e1045122 Gerrit-Change-Number: 52019 Gerrit-PatchSet: 1 Gerrit-Owner: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 12:19:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

Change in coreboot[master]: vendorcode/intel/FSP2_0/CPX-SP: Declare struct RC_VERSION non-packed

by Deomid "rojer" Ryabkov (Code Review)

Attention is currently required from: Jonathan Zhang, Paul Menzel, Christian Walter, Arthur Heymans, Patrick Rudolph. Deomid "rojer" Ryabkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51545 ) Change subject: vendorcode/intel/FSP2_0/CPX-SP: Declare struct RC_VERSION non-packed ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > Thanks for the insight! I'd update the commit message, as we know it's a bug and will most likely no […] updated -- To view, visit https://review.coreboot.org/c/coreboot/+/51545 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5248734e2f086d39bb75b7b1359e60dfd8704200 Gerrit-Change-Number: 51545 Gerrit-PatchSet: 4 Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 12:15:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-MessageType: comment

1 year, 2 months

Change in coreboot[master]: vendorcode/intel/FSP2_0/CPX-SP: Declare struct RC_VERSION non-packed

by Deomid "rojer" Ryabkov (Code Review)

Attention is currently required from: Jonathan Zhang, Paul Menzel, Christian Walter, Arthur Heymans, Patrick Rudolph. Hello build bot (Jenkins), Jonathan Zhang, Christian Walter, Angel Pons, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51545 to look at the new patch set (#4). Change subject: vendorcode/intel/FSP2_0/CPX-SP: Declare struct RC_VERSION non-packed ...................................................................... vendorcode/intel/FSP2_0/CPX-SP: Declare struct RC_VERSION non-packed It is a bug acknowledged by Intel (IPS case 00600003) that has been fixed for SRP but won't be fixed for CPX. This fixes field offsets for fields that follow SYSTEM_STATUS.RcVersion Change-Id: I5248734e2f086d39bb75b7b1359e60dfd8704200 Signed-off-by: Deomid "rojer" Ryabkov <rojer9(a)fb.com> --- M src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_iiouds.h 1 file changed, 12 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/51545/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/51545 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5248734e2f086d39bb75b7b1359e60dfd8704200 Gerrit-Change-Number: 51545 Gerrit-PatchSet: 4 Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 year, 2 months

Change in coreboot[master]: vendorcode/intel/FSP2_0/CPX-SP: Declare struct RC_VERSION non-packed

by Deomid "rojer" Ryabkov (Code Review)

Attention is currently required from: Jonathan Zhang, Paul Menzel, Christian Walter, Arthur Heymans, Patrick Rudolph, Deomid "rojer" Ryabkov. Hello build bot (Jenkins), Jonathan Zhang, Christian Walter, Angel Pons, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51545 to look at the new patch set (#3). Change subject: vendorcode/intel/FSP2_0/CPX-SP: Declare struct RC_VERSION non-packed ...................................................................... vendorcode/intel/FSP2_0/CPX-SP: Declare struct RC_VERSION non-packed It is a bug acknowledged by Intel (IPS case 00600003) that has been fixed for SRP but won't be fixed for CPX. This fixes field offsets for fields that follow SYSTEM_STATUS.RcVersion Change-Id: I5248734e2f086d39bb75b7b1359e60dfd8704200 Signed-off-by: Deomid "rojer" Ryabkov <rojer9(a)fb.com> --- M src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_iiouds.h 1 file changed, 12 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/51545/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/51545 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5248734e2f086d39bb75b7b1359e60dfd8704200 Gerrit-Change-Number: 51545 Gerrit-PatchSet: 3 Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-MessageType: newpatchset

1 year, 2 months

Change in coreboot[master]: vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT

by Frans Hendriks (Code Review)

Attention is currently required from: Wim Vervoorn. Hello Wim Vervoorn, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52021 to look at the new patch set (#2). Change subject: vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT ...................................................................... vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT VENDORCODE_ELTAN_MBOOT should not be used when VBOOT is enabled. Hide VENDOCODE_ELTAN_MBOOT when VBOOT is enabled. BUG = N/A TEST = run `make menuconfig` and boot Facebook FBG1701 Change-Id: Iac57103431cc7efac5b6019f180572d255e683ab Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M src/vendorcode/eltan/security/mboot/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/52021/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac57103431cc7efac5b6019f180572d255e683ab Gerrit-Change-Number: 52021 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Attention: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-MessageType: newpatchset

1 year, 2 months

Change in coreboot[master]: vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT

by Frans Hendriks (Code Review)

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52021 ) Change subject: vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT ...................................................................... vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT VENDORCODE_ELTAN_MBOOT should not be used when VBOOT is enabled. Hide VENDOCODE_ELTAN_MBOOT when VBOOT is enabled. BUG = N/A TEST = run `make menuconfig` and boot Facebook FBG1701 vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT VENDORCODE_ELTAN_MBOOT can be enabled when VBOOT is enabled. Hide VENDOCODE_ELTAN_MBOOT when VBOOT is enabled. Change-Id: Iac57103431cc7efac5b6019f180572d255e683ab Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M src/vendorcode/eltan/security/mboot/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/52021/1 diff --git a/src/vendorcode/eltan/security/mboot/Kconfig b/src/vendorcode/eltan/security/mboot/Kconfig index 540b7b2..4e30cf5 100644 --- a/src/vendorcode/eltan/security/mboot/Kconfig +++ b/src/vendorcode/eltan/security/mboot/Kconfig @@ -4,6 +4,7 @@ config VENDORCODE_ELTAN_MBOOT bool "Measure firmware with mboot." + depends on !VBOOT default n select VBOOT_LIB help -- To view, visit https://review.coreboot.org/c/coreboot/+/52021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac57103431cc7efac5b6019f180572d255e683ab Gerrit-Change-Number: 52021 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-MessageType: newchange

1 year, 2 months

Change in coreboot[master]: [WIP] alderlake: enable DPTF functionality for ADL-RVP board

by Sumeet R Pawnikar (Code Review)

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52020 ) Change subject: [WIP] alderlake: enable DPTF functionality for ADL-RVP board ...................................................................... [WIP] alderlake: enable DPTF functionality for ADL-RVP board Enable DPTF functionality for alderlake based ADL-RVP board BRANCH=None BUG=None TEST=Built for adlrvp and tested on adlrvp board Change-Id: I319bb0ddb9cd9bbe48c8ee09c2742a78da230b7b Signed-off-by: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> --- M src/drivers/intel/dptf/dptf.c M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/adlrvp/devicetree.cb 3 files changed, 73 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/52020/1 diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index 1713e72..d816847 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -18,9 +18,17 @@ #define GENERIC_HID_EISAID "INT3403" #define FAN_HID_EISAID "INT3404" +#if 0 +/* Below are ACPI IDs for Tiger Lake SoC */ #define DPTF_DEVICE_HID "INTC1040" #define GENERIC_HID "INTC1043" #define FAN_HID "INTC1044" +#endif + +/* Below are ACPI IDs for Alder Lake SoC */ +#define DPTF_DEVICE_HID "INTC1041" +#define GENERIC_HID "INTC1046" +#define FAN_HID "INTC1048" /* * Helper method to determine if a device is "used" (called out anywhere as a source or a target diff --git a/src/mainboard/intel/adlrvp/Kconfig b/src/mainboard/intel/adlrvp/Kconfig index c1c4586..8a64e49 100644 --- a/src/mainboard/intel/adlrvp/Kconfig +++ b/src/mainboard/intel/adlrvp/Kconfig @@ -10,6 +10,7 @@ select DRIVERS_I2C_HID select DRIVERS_I2C_GENERIC select DRIVERS_INTEL_SOUNDWIRE + select DRIVERS_INTEL_DPTF select DRIVERS_INTEL_PMC if BOARD_INTEL_ADLRVP_P_EXT_EC || BOARD_INTEL_ADLRVP_M_EXT_EC select DRIVERS_USB_ACPI select DRIVERS_SPI_ACPI diff --git a/src/mainboard/intel/adlrvp/devicetree.cb b/src/mainboard/intel/adlrvp/devicetree.cb index cade987..dc531d5 100644 --- a/src/mainboard/intel/adlrvp/devicetree.cb +++ b/src/mainboard/intel/adlrvp/devicetree.cb @@ -132,6 +132,12 @@ register "TcssAuxOri" = "0" register "s0ix_enable" = "1" + register "dptf_enable" = "1" + + register "power_limits_config" = "{ + .tdp_pl1_override = 45, + .tdp_pl2_override = 56, + }" register "SerialIoI2cMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, @@ -209,7 +215,64 @@ device pci 00.0 on end # Host Bridge device pci 01.0 on end # PEG10 device pci 02.0 on end # Graphics - device pci 04.0 on end # DPTF + device pci 04.0 on + chip drivers/intel/dptf + + ## sensor information + register "options.tsr[0].desc" = ""Ambient"" + register "options.tsr[1].desc" = ""Battery"" + register "options.tsr[2].desc" = ""DDR"" + register "options.tsr[3].desc" = ""Skin"" + + ## Passive Policy + # TODO: below values are initial reference values only + register "policies.passive" = "{ + [0] = DPTF_PASSIVE(CPU, CPU, 95, 10000), + [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 85, 50000), + [2] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 85, 50000), + [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 85, 50000), + [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 85, 50000), + }" + + ## Critical Policy + # TODO: below values are initial reference values only + register "policies.critical" = "{ + [0] = DPTF_CRITICAL(CPU, 105, SHUTDOWN), + [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 95, SHUTDOWN), + [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 95, SHUTDOWN), + [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 95, SHUTDOWN), + [4] = DPTF_CRITICAL(TEMP_SENSOR_3, 95, SHUTDOWN), + }" + + ## Power Limits Control + register "controls.power_limits" = "{ + .pl1 = { + .min_power = 35000, + .max_power = 45000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 32 * MSECS_PER_SEC, + .granularity = 200, + }, + .pl2 = { + .min_power = 56000, + .max_power = 56000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 32 * MSECS_PER_SEC, + .granularity = 1000, + } + }" + + ## Charger Performance Control (Control, mA) + register "controls.charger_perf" = "{ + [0] = { 255, 3000 }, + [1] = { 24, 1500 }, + [2] = { 16, 1000 }, + [3] = { 8, 500 } + }" + + device generic 0 on end + end + end # DPTF device pci 05.0 on end # IPU device pci 06.0 on end # PEG60 device pci 06.2 on end # PEG62 -- To view, visit https://review.coreboot.org/c/coreboot/+/52020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I319bb0ddb9cd9bbe48c8ee09c2742a78da230b7b Gerrit-Change-Number: 52020 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: newchange

1 year, 2 months

Jump to page:

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021