coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
5704 discussions

Change in coreboot[master]: security/intel/cbnt: Allow for an externally provided bg-prov bin
by Arthur Heymans (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Martin Roth, Arthur Heymans. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51982 to look at the new patch set (#4). Change subject: security/intel/cbnt: Allow for an externally provided bg-prov bin ...................................................................... security/intel/cbnt: Allow for an externally provided bg-prov bin Building the bg-prov tool requires godeps which does not work if offline. Therefor add an option to provide this binary via Kconfig. It's the responsibility of the user to use a compatible binary then. Change-Id: I06ff4ee01bf58cae45648ddb8a30a30b9a7e027a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/security/intel/cbnt/Kconfig M src/security/intel/cbnt/Makefile.inc 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/51982/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/51982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06ff4ee01bf58cae45648ddb8a30a30b9a7e027a Gerrit-Change-Number: 51982 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vc/amd/fsp/cezanne: add platform_descriptors.h
by Marshall Dawson (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Justin Frodsham, Raul Rangel, Matt Papageorge, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 ) Change subject: vc/amd/fsp/cezanne: add platform_descriptors.h ...................................................................... Patch Set 10: (1 comment) File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h: https://review.coreboot.org/c/coreboot/+/51197/comment/1e4d7e0a_79a51db5 PS10, Line 196: Currently unused by FSP Based on Matt's comment, I infer this should change too. -- To view, visit https://review.coreboot.org/c/coreboot/+/51197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474 Gerrit-Change-Number: 51197 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 01 Apr 2021 16:04:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/amd/fsp/picasso/platform_descriptors: fix typos in enum element names
by Raul Rangel (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52028 ) Change subject: vc/amd/fsp/picasso/platform_descriptors: fix typos in enum element names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cad6a6a585320b33bfab7b3950888241f7c179c Gerrit-Change-Number: 52028 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 01 Apr 2021 15:52:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/sapphire/pureplatinum/cmos.default: Remove `volume` entry
by Angel Pons (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Nicola Corna. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52027 ) Change subject: mb/sapphire/pureplatinum/cmos.default: Remove `volume` entry ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52027/comment/a2c240c7_c0d01e68 PS1, Line 9: de50d39 commit de50d39 (mb/**/cmos.layout: Drop copy-pasted `volume` entries) -- To view, visit https://review.coreboot.org/c/coreboot/+/52027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieebafffa0d2fbf6cdd24cff4ddefe090a727cbfa Gerrit-Change-Number: 52027 Gerrit-PatchSet: 1 Gerrit-Owner: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicola Corna <nicola(a)corna.info> Gerrit-Comment-Date: Thu, 01 Apr 2021 15:50:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/amd/fsp/picasso/platform_descriptors: fix typos in enum element names
by Felix Held (Code Review) 01 Apr '21

01 Apr '21

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52028 ) Change subject: vc/amd/fsp/picasso/platform_descriptors: fix typos in enum element names ...................................................................... vc/amd/fsp/picasso/platform_descriptors: fix typos in enum element names Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I5cad6a6a585320b33bfab7b3950888241f7c179c --- M src/vendorcode/amd/fsp/picasso/platform_descriptors.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/52028/1 diff --git a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h index 81293c6..717be1f 100644 --- a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h +++ b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h @@ -31,7 +31,7 @@ /* Upstream Auto Speed Change Allowed */ typedef enum { SPDC_DEFAULT = 0, // Enabled for Gen2 and Gen3 - SPDC_DISBLED, + SPDC_DISABLED, SPDC_ENABLED, SPDC_INVALID } dxio_upstream_auto_speed_change; @@ -105,7 +105,7 @@ EDP_TO_LVDS, // eDP-to-LVDS translator chip without AMD SW init EDP_TO_LVDS_SW, // eDP-to-LVDS translator which requires AMD SW init AUTO_DETECT, // VBIOS auto detect connector type - UNUSED_PTYPE, // UnusedType + UNUSED_TYPE, // UnusedType MAX_CONNECTOR_TYPE // Not valid value, used to verify input } ddi_connector_type; -- To view, visit https://review.coreboot.org/c/coreboot/+/52028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cad6a6a585320b33bfab7b3950888241f7c179c Gerrit-Change-Number: 52028 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/facebook/fbg1701/vboot-rw.fmd: Expand RO_SECTION
by Arthur Heymans (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Frans Hendriks. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52026 ) Change subject: mb/facebook/fbg1701/vboot-rw.fmd: Expand RO_SECTION ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f1020acb3ec99d4cddbaa05b0998fe32b470d3e Gerrit-Change-Number: 52026 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 15:42:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Add IRQ numbers
by Felix Held (Code Review) 01 Apr '21

01 Apr '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51959 ) Change subject: mb/google/guybrush: Add IRQ numbers ...................................................................... mb/google/guybrush: Add IRQ numbers BUG=b:183737011 TEST=cat /proc/interrupts and see i2c controllers and gpio controller listed Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I5b2f23b2c2a7c4cec198276814d80f545e85aa41 Reviewed-on: https://review.coreboot.org/c/coreboot/+/51959 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Mathew King <mathewk(a)chromium.org> Reviewed-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/guybrush/mainboard.c 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Mathew King: Looks good to me, approved diff --git a/src/mainboard/google/guybrush/mainboard.c b/src/mainboard/google/guybrush/mainboard.c index 72ad7a8..57f658c 100644 --- a/src/mainboard/google/guybrush/mainboard.c +++ b/src/mainboard/google/guybrush/mainboard.c @@ -50,9 +50,11 @@ { PIRQ_SDIO, PIRQ_NC, PIRQ_NC }, { PIRQ_SATA, PIRQ_NC, PIRQ_NC }, { PIRQ_EMMC, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPIO, PIRQ_NC, PIRQ_NC }, - { PIRQ_I2C2, PIRQ_NC, PIRQ_NC }, - { PIRQ_I2C3, PIRQ_NC, PIRQ_NC }, + { PIRQ_GPIO, 11, 11 }, + { PIRQ_I2C0, 10, 10 }, + { PIRQ_I2C1, 7, 7 }, + { PIRQ_I2C2, 6, 6 }, + { PIRQ_I2C3, 5, 5 }, { PIRQ_UART0, 4, 4 }, { PIRQ_UART1, 3, 3 }, -- To view, visit https://review.coreboot.org/c/coreboot/+/51959 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b2f23b2c2a7c4cec198276814d80f545e85aa41 Gerrit-Change-Number: 51959 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/amd/cezanne: Enable GENERIC_GPIO_LIB
by Felix Held (Code Review) 01 Apr '21

01 Apr '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51961 ) Change subject: soc/amd/cezanne: Enable GENERIC_GPIO_LIB ...................................................................... soc/amd/cezanne: Enable GENERIC_GPIO_LIB Needed so we write the correct resource into the ACPI tables. BUG=b:183737011 TEST=Boot OS and see GPIO devices working Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I2ba4349e0ed500912db40aa6ef9b649046f4358f Reviewed-on: https://review.coreboot.org/c/coreboot/+/51961 Reviewed-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/amd/cezanne/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Marshall Dawson: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved diff --git a/src/soc/amd/cezanne/Kconfig b/src/soc/amd/cezanne/Kconfig index 3d672d8..d682892 100644 --- a/src/soc/amd/cezanne/Kconfig +++ b/src/soc/amd/cezanne/Kconfig @@ -20,6 +20,7 @@ select DRIVERS_USB_PCI_XHCI select FSP_COMPRESS_FSP_M_LZMA select FSP_COMPRESS_FSP_S_LZMA + select GENERIC_GPIO_LIB select HAVE_ACPI_TABLES select HAVE_CF9_RESET select HAVE_EM100_SUPPORT -- To view, visit https://review.coreboot.org/c/coreboot/+/51961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ba4349e0ed500912db40aa6ef9b649046f4358f Gerrit-Change-Number: 51961 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mathew King <mathewk(a)chromium.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/amd/cezanne: Add device tree support for I2C
by Felix Held (Code Review) 01 Apr '21

01 Apr '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51958 ) Change subject: soc/amd/cezanne: Add device tree support for I2C ...................................................................... soc/amd/cezanne: Add device tree support for I2C This allows the cr50 on guybrush to show up in ACPI. BUG=b:183737011 TEST=Boot OS and see I2C devices initialized Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Ifb5679b7bbefbf753217981874bb1bdaef35f6db Reviewed-on: https://review.coreboot.org/c/coreboot/+/51958 Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Mathew King <mathewk(a)chromium.org> Reviewed-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/amd/cezanne/chip.c 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Marshall Dawson: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Mathew King: Looks good to me, approved diff --git a/src/soc/amd/cezanne/chip.c b/src/soc/amd/cezanne/chip.c index 2612243..c2d7af7 100644 --- a/src/soc/amd/cezanne/chip.c +++ b/src/soc/amd/cezanne/chip.c @@ -10,6 +10,8 @@ #include <types.h> #include "chip.h" +/* Supplied by i2c.c */ +extern struct device_operations soc_amd_i2c_mmio_ops; /* Supplied by uart.c */ extern struct device_operations cezanne_uart_mmio_ops; @@ -42,6 +44,12 @@ static void set_mmio_dev_ops(struct device *dev) { switch (dev->path.mmio.addr) { + case APU_I2C0_BASE: + case APU_I2C1_BASE: + case APU_I2C2_BASE: + case APU_I2C3_BASE: + dev->ops = &soc_amd_i2c_mmio_ops; + break; case APU_UART0_BASE: case APU_UART1_BASE: dev->ops = &cezanne_uart_mmio_ops; -- To view, visit https://review.coreboot.org/c/coreboot/+/51958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb5679b7bbefbf753217981874bb1bdaef35f6db Gerrit-Change-Number: 51958 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/sapphire/pureplatinum/cmos.default: Remove `volume` entry
by Nicola Corna (Code Review) 01 Apr '21

01 Apr '21

Nicola Corna has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52027 ) Change subject: mb/sapphire/pureplatinum/cmos.default: Remove `volume` entry ...................................................................... mb/sapphire/pureplatinum/cmos.default: Remove `volume` entry Following de50d39, remove the `volume` entry from cmos.default. Change-Id: Ieebafffa0d2fbf6cdd24cff4ddefe090a727cbfa Signed-off-by: Nicola Corna <nicola(a)corna.info> --- M src/mainboard/sapphire/pureplatinumh61/cmos.default 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/52027/1 diff --git a/src/mainboard/sapphire/pureplatinumh61/cmos.default b/src/mainboard/sapphire/pureplatinumh61/cmos.default index 579945d..7cd30cc 100644 --- a/src/mainboard/sapphire/pureplatinumh61/cmos.default +++ b/src/mainboard/sapphire/pureplatinumh61/cmos.default @@ -2,6 +2,5 @@ debug_level=Debug power_on_after_fail=Enable nmi=Enable -volume=0x3 sata_mode=AHCI hyper_threading=Enable -- To view, visit https://review.coreboot.org/c/coreboot/+/52027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieebafffa0d2fbf6cdd24cff4ddefe090a727cbfa Gerrit-Change-Number: 52027 Gerrit-PatchSet: 1 Gerrit-Owner: Nicola Corna <nicola(a)corna.info> Gerrit-MessageType: newchange

1 0

Jump to page:

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021