Change in coreboot[master]: mb/google/zork: Disable USB_OC0_L on transition to S3

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Martin Roth (Code Review)

16 Dec 2020 16 Dec '20

4:04 a.m.

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48650 )

Change subject: mb/google/zork: Disable USB_OC0_L on transition to S3 ......................................................................

mb/google/zork: Disable USB_OC0_L on transition to S3

One of the second source USB charging port chips is erroneous triggering the overcurrent pin when we go into S3. Because this is used mainly to report the overcurrent situation to the OS and there is additional overcurrent protection, we can disable the function when the system goes into S3. It will get switched back to the overcurrent function when the system resumes.

BUG=b:175646274 TEST=Build. Still needs to be functionally tested BRANCH=Zork

Change-Id: I9d280c793a7989ebaa2fcc28531fe14e2adbfaef --- M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c 1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/48650/1

diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c index a2ad517..234cd7d 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c @@ -336,6 +336,9 @@ PAD_GPO(GPIO_40, LOW), /* EN_PWR_CAMERA */ PAD_GPO(GPIO_76, LOW), + /* USB_OC0_L - USB C0 + USB A0 */ + PAD_GPI(GPIO_16, PULL_NONE), + };

static const struct soc_amd_gpio gpio_fp_shutdown_table[] = { @@ -348,6 +351,9 @@ PAD_GPO(GPIO_11, LOW), /* EN_PWR_FP */ PAD_GPO(GPIO_32, LOW), + + /* USB_OC0_L - USB C0 + USB A0 */ + PAD_GPI(GPIO_16, PULL_NONE), };

const __weak struct soc_amd_gpio *variant_sleep_gpio_table(size_t *size, int slp_typ)

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

Martin Roth (Code Review)

16 Dec 16 Dec

4:11 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48650

to look at the new patch set (#2).

Change subject: mb/google/zork: Disable USB_OC0_L on transition to S3 ......................................................................

mb/google/zork: Disable USB_OC0_L on transition to S3

BUG=b:175646274 TEST=Build. Still needs to be functionally tested BRANCH=Zork

Change-Id: I9d280c793a7989ebaa2fcc28531fe14e2adbfaef Signed-off-by: Martin Roth martinroth@chromium.org --- M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c 1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/48650/2

Martin Roth (Code Review)

4:16 a.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48650 )

Change subject: mb/google/zork: Disable USB_OC0_L on transition to S3 ......................................................................

Patch Set 2:

Hi Kevin & Lucas, I believe Amadis was debugging this issue on b/172528124 - If one of you has the time, could you get him an ezkinil build with this patch to test? Hopefully the system goes into S3 correctly with this patch.

Thanks!

Felix Held (Code Review)

16 Jan 16 Jan

12:20 a.m.

Attention is currently required from: Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48650 )

Change subject: mb/google/zork: Disable USB_OC0_L on transition to S3 ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2: does the same issue need to be addressed for USB_OC1_L? the patch looks good to me, but i'll wait with a +2 until it's tested on hardware

-- To view, visit https://review.coreboot.org/c/coreboot/+/48650 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d280c793a7989ebaa2fcc28531fe14e2adbfaef Gerrit-Change-Number: 48650 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Lucas Chen lucas.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-Attention: Martin Roth martinroth@google.com Gerrit-Comment-Date: Fri, 15 Jan 2021 23:20:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

19 Jan 19 Jan

5:48 p.m.

Attention is currently required from: Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48650 )

Change subject: mb/google/zork: Disable USB_OC0_L on transition to S3 ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:

...

does the same issue need to be addressed for USB_OC1_L? […]

My understanding is that it's not required the way it is for USB_OC0, but it shouldn't hurt. I'm waiting to see if it's actually needed since it's been ignored for a month.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48650 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d280c793a7989ebaa2fcc28531fe14e2adbfaef Gerrit-Change-Number: 48650 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Lucas Chen lucas.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-Comment-Date: Tue, 19 Jan 2021 16:48:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de Gerrit-MessageType: comment

Martin Roth (Code Review)

5:59 p.m.

Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48650 )

Change subject: mb/google/zork: Disable USB_OC0_L on transition to S3 ......................................................................

Abandoned

Not sure what happened, but the hardware issue was closed as not reproducible.

Kevin Chiu (Code Review)

20 Jan 20 Jan

1:45 a.m.

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48650 )

Change subject: mb/google/zork: Disable USB_OC0_L on transition to S3 ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2: Hi Martin, so sorry for lost this one, since I can't access b:175646274, I will check with Lucas to get more detail info. Thank you!

-- To view, visit https://review.coreboot.org/c/coreboot/+/48650 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d280c793a7989ebaa2fcc28531fe14e2adbfaef Gerrit-Change-Number: 48650 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Lucas Chen lucas.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-Comment-Date: Wed, 20 Jan 2021 00:45:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

25 Jan 25 Jan

7:40 p.m.

Martin Roth has restored this change. ( https://review.coreboot.org/c/coreboot/+/48650 )

Change subject: mb/google/zork: Disable USB_OC0_L on transition to S3 ......................................................................

Restored

-- To view, visit https://review.coreboot.org/c/coreboot/+/48650 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d280c793a7989ebaa2fcc28531fe14e2adbfaef Gerrit-Change-Number: 48650 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Lucas Chen lucas.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-MessageType: restore

Lucas Chen (Code Review)

27 Jan 27 Jan

7:04 a.m.

Attention is currently required from: Martin Roth. Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48650 )

Change subject: mb/google/zork: Disable USB_OC0_L on transition to S3 ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2: I am very sorry for miss the issue notify, i will check with test person.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48650 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d280c793a7989ebaa2fcc28531fe14e2adbfaef Gerrit-Change-Number: 48650 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Lucas Chen lucas.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-CC: Lucas Chen lucas.chen@quanta.corp-partner.google.com Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-Attention: Martin Roth martinroth@google.com Gerrit-Comment-Date: Wed, 27 Jan 2021 06:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chiu (Code Review)

20 Feb 20 Feb

9:58 a.m.

Attention is currently required from: Martin Roth. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48650 )

Change subject: mb/google/zork: Disable USB_OC0_L on transition to S3 ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2: Hi Martin, try to simulate the failed phenomenon that trigger USB overcurrent pin (GPIO16) during DUT entering S3, it looks DUT will still be woke up unexpectedly. thanks.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48650 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d280c793a7989ebaa2fcc28531fe14e2adbfaef Gerrit-Change-Number: 48650 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Lucas Chen lucas.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-CC: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-CC: Lucas Chen lucas.chen@quanta.corp-partner.google.com Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-Attention: Martin Roth martinroth@google.com Gerrit-Comment-Date: Sat, 20 Feb 2021 08:58:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

6 Apr 6 Apr

5:04 a.m.

Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48650 )

Change subject: mb/google/zork: Disable USB_OC0_L on transition to S3 ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/48650 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d280c793a7989ebaa2fcc28531fe14e2adbfaef Gerrit-Change-Number: 48650 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Lucas Chen lucas.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-CC: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-CC: Lucas Chen lucas.chen@quanta.corp-partner.google.com Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-MessageType: abandon

1126

days inactive

1237

days old

coreboot-gerrit@coreboot.org

10 comments

4 participants

tags (0)

participants (4)

Felix Held (Code Review)
Kevin Chiu (Code Review)
Lucas Chen (Code Review)
Martin Roth (Code Review)