Attention is currently required from: Paul Menzel.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52136 )
Change subject: tests/lib/malloc-test: Fix possible memory overrun
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52136/comment/31602c63_418d4946
PS1, Line 11:
> If it was found by Coverity, please add a tag `Found-by:`.
Yes. It was found by Coverity. Done :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/52136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19f0718c657d565e515157e66367573e08f51254
Gerrit-Change-Number: 52136
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 06 Apr 2021 17:40:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga.
Hello build bot (Jenkins), Patrick Georgi, Paul Fagerburg,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52136
to look at the new patch set (#2).
Change subject: tests/lib/malloc-test: Fix possible memory overrun
......................................................................
tests/lib/malloc-test: Fix possible memory overrun
Change memset address to use actual buffer instead of pointer
stored in symbol value.
Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com>
Change-Id: I19f0718c657d565e515157e66367573e08f51254
Found-by: Coverity CID 1452005
---
M tests/lib/malloc-test.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/52136/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19f0718c657d565e515157e66367573e08f51254
Gerrit-Change-Number: 52136
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Furquan Shaikh, Mathew King, EricR Lai.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52122 )
Change subject: mb/google/mancomb: Configure UART0 gpio in early stage
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52122/comment/879c63d2_4fd33d8a
PS1, Line 8:
Why? What behavior is improved?
--
To view, visit https://review.coreboot.org/c/coreboot/+/52122
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d4ec1556ac7136c454eb025ff99aafbf49b8982
Gerrit-Change-Number: 52122
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Mathew King <mathewk(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 17:25:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Stefan Reinauer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51504 )
Change subject: checkpatch_json: Mark robotic comments as robotic.
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51504/comment/26f1e0c2_fc305ad3
PS4, Line 7: checkpatch_json: Mark robotic comments as robotic.
Nit: It’d be great, if you removed the dot/period at the end.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51504
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a545d1cf6c04b331964becd2b24eb38018394eb
Gerrit-Change-Number: 51504
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Tue, 06 Apr 2021 17:23:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51747 )
Change subject: soc/amd/common: Add some ESPI register definitions
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/soc/amd/common/block/include/amdblocks/espi.h:
https://review.coreboot.org/c/coreboot/+/51747/comment/d452ba8d_7b2277db
PS6, Line 20: #define ESPI_IO_BASE_OFFSET_REG1 0x48
> Ack.
i'd say that those are unnecessary and probably not too useful, but it also doesn't really hurt to have those in here
--
To view, visit https://review.coreboot.org/c/coreboot/+/51747
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieae53b12e5303641fb3f180c47468aaa6906e9af
Gerrit-Change-Number: 51747
Gerrit-PatchSet: 7
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 06 Apr 2021 17:22:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Alexander Couzens.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51362 )
Change subject: util/genbuild_h: add support to print SOURCE_DATE_EPOCH
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/51362
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa79d3e7df8101a1ba1b37a361d8992f7eab2d52
Gerrit-Change-Number: 51362
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 06 Apr 2021 17:21:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52136 )
Change subject: tests/lib/malloc-test: Fix possible memory overrun
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52136/comment/dd075f63_fb4bfe04
PS1, Line 11:
If it was found by Coverity, please add a tag `Found-by:`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19f0718c657d565e515157e66367573e08f51254
Gerrit-Change-Number: 52136
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 17:19:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Martin Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51775 )
Change subject: chromeec: Fix google_chromeec_status_check timeout
......................................................................
Patch Set 6:
(2 comments)
File src/ec/google/chromeec/ec_lpc.c:
https://review.coreboot.org/c/coreboot/+/51775/comment/5c430618_704fa7b7
PS4, Line 105: return 0;
> This call happens pretty frequently. I'm not sure that's really useful.
True, maybe only if it’s above a certain threshold. But could be done in the future to optimize stuff.
https://review.coreboot.org/c/coreboot/+/51775/comment/a7d40852_8d140599
PS4, Line 108:
> As mentioned above, I don't think that it's particularly useful, except during board bringup.
Understood.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51775
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I363ff7453bcf81581884f92797629a6f96d42580
Gerrit-Change-Number: 51775
Gerrit-PatchSet: 6
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 17:19:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Martin Roth, Paul Menzel.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51775 )
Change subject: chromeec: Fix google_chromeec_status_check timeout
......................................................................
Patch Set 6:
(3 comments)
File src/ec/google/chromeec/ec_lpc.c:
https://review.coreboot.org/c/coreboot/+/51775/comment/7b8ca234_1545e496
PS4, Line 98: *
> nit: spaces around *
Done
https://review.coreboot.org/c/coreboot/+/51775/comment/c9a98c91_2464a73f
PS4, Line 105: return 0;
> Print the stopwatch value in a spew message?
This will be noisy.
https://review.coreboot.org/c/coreboot/+/51775/comment/f5266df2_baafeed6
PS4, Line 108:
> Please print a warning/error with the timeout value.
All the calls to this function already print a timeout error.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51775
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I363ff7453bcf81581884f92797629a6f96d42580
Gerrit-Change-Number: 51775
Gerrit-PatchSet: 6
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 06 Apr 2021 17:17:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: comment