coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: mb/google/volteer: Add EC_HOST_EVENT_PD_MCU
by John Zhao (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Li1 Feng. Hello Li1 Feng, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52137 to look at the new patch set (#2). Change subject: mb/google/volteer: Add EC_HOST_EVENT_PD_MCU ...................................................................... mb/google/volteer: Add EC_HOST_EVENT_PD_MCU This change adds the EC_HOST_EVENT_PD_MCU to be dark resume source. BUG=b:183140386 TEST=In S0ix, remove DP dongle, system does dark resume. AP and EC synchronized, AP got PD disconnection, working as we expected. Signed-off-by: John Zhao <john.zhao(a)intel.com> Change-Id: I44e4075f42e9a95d26fe766489630dac0bc61b05 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/52137/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44e4075f42e9a95d26fe766489630dac0bc61b05 Gerrit-Change-Number: 52137 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Li1 Feng <li1.feng(a)intel.com> Gerrit-Attention: Li1 Feng <li1.feng(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/volteer: Add EC_HOST_EVENT_PD_MCU
by John Zhao (Code Review) 06 Apr '21

06 Apr '21

John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52137 ) Change subject: mb/google/volteer: Add EC_HOST_EVENT_PD_MCU ...................................................................... mb/google/volteer: Add EC_HOST_EVENT_PD_MCU This change adds the EC_HOST_EVENT_PD_MCU to be dark resume source. BUG=b:183140386 TEST=In S0ix, remove DP dongle, system does dark resume. AP and EC synchronized, AP got PD disconnection, working as we expected. Signed-off-by: John Zhao <john.zhao(a)intel.com> Change-Id: I44e4075f42e9a95d26fe766489630dac0bc61b05 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/52137/1 diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h index 1428ec8..5e84adc 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h @@ -37,6 +37,7 @@ EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)) #define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS) -- To view, visit https://review.coreboot.org/c/coreboot/+/52137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44e4075f42e9a95d26fe766489630dac0bc61b05 Gerrit-Change-Number: 52137 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: tests/lib/malloc-test: Fix possible memory overrun
by Jakub Czapiga (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Paul Menzel. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52136 ) Change subject: tests/lib/malloc-test: Fix possible memory overrun ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52136/comment/31602c63_418d4946 PS1, Line 11: > If it was found by Coverity, please add a tag `Found-by:`. Yes. It was found by Coverity. Done :) -- To view, visit https://review.coreboot.org/c/coreboot/+/52136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19f0718c657d565e515157e66367573e08f51254 Gerrit-Change-Number: 52136 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 06 Apr 2021 17:40:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests/lib/malloc-test: Fix possible memory overrun
by Jakub Czapiga (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Jakub Czapiga. Hello build bot (Jenkins), Patrick Georgi, Paul Fagerburg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52136 to look at the new patch set (#2). Change subject: tests/lib/malloc-test: Fix possible memory overrun ...................................................................... tests/lib/malloc-test: Fix possible memory overrun Change memset address to use actual buffer instead of pointer stored in symbol value. Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: I19f0718c657d565e515157e66367573e08f51254 Found-by: Coverity CID 1452005 --- M tests/lib/malloc-test.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/52136/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19f0718c657d565e515157e66367573e08f51254 Gerrit-Change-Number: 52136 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/mancomb: Configure UART0 gpio in early stage
by Paul Menzel (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Martin Roth, Furquan Shaikh, Mathew King, EricR Lai. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52122 ) Change subject: mb/google/mancomb: Configure UART0 gpio in early stage ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52122/comment/879c63d2_4fd33d8a PS1, Line 8: Why? What behavior is improved? -- To view, visit https://review.coreboot.org/c/coreboot/+/52122 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d4ec1556ac7136c454eb025ff99aafbf49b8982 Gerrit-Change-Number: 52122 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 06 Apr 2021 17:25:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/shadowmountain: Enable RTD3 for SD card
by Paul Menzel (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Rizwan Qureshi. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52134 ) Change subject: mb/intel/shadowmountain: Enable RTD3 for SD card ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52134/comment/1c01d5f5_4400c9f2 PS1, Line 12: shadowmountai mountain -- To view, visit https://review.coreboot.org/c/coreboot/+/52134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeb99bea48d72b019cb2adcf38926c3ed39f7b84 Gerrit-Change-Number: 52134 Gerrit-PatchSet: 1 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Comment-Date: Tue, 06 Apr 2021 17:24:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: checkpatch_json: Mark robotic comments as robotic.
by Paul Menzel (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Martin Roth, Stefan Reinauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51504 ) Change subject: checkpatch_json: Mark robotic comments as robotic. ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51504/comment/26f1e0c2_fc305ad3 PS4, Line 7: checkpatch_json: Mark robotic comments as robotic. Nit: It’d be great, if you removed the dot/period at the end. -- To view, visit https://review.coreboot.org/c/coreboot/+/51504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a545d1cf6c04b331964becd2b24eb38018394eb Gerrit-Change-Number: 51504 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Apr 2021 17:23:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common: Add some ESPI register definitions
by Felix Held (Code Review) 06 Apr '21

06 Apr '21

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51747 ) Change subject: soc/amd/common: Add some ESPI register definitions ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File src/soc/amd/common/block/include/amdblocks/espi.h: https://review.coreboot.org/c/coreboot/+/51747/comment/d452ba8d_7b2277db PS6, Line 20: #define ESPI_IO_BASE_OFFSET_REG1 0x48 > Ack. i'd say that those are unnecessary and probably not too useful, but it also doesn't really hurt to have those in here -- To view, visit https://review.coreboot.org/c/coreboot/+/51747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieae53b12e5303641fb3f180c47468aaa6906e9af Gerrit-Change-Number: 51747 Gerrit-PatchSet: 7 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 06 Apr 2021 17:22:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/genbuild_h: add support to print SOURCE_DATE_EPOCH
by Paul Menzel (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Martin Roth, Alexander Couzens. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51362 ) Change subject: util/genbuild_h: add support to print SOURCE_DATE_EPOCH ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/51362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa79d3e7df8101a1ba1b37a361d8992f7eab2d52 Gerrit-Change-Number: 51362 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 06 Apr 2021 17:21:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests/lib/malloc-test: Fix possible memory overrun
by Paul Menzel (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Jakub Czapiga. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52136 ) Change subject: tests/lib/malloc-test: Fix possible memory overrun ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52136/comment/dd075f63_fb4bfe04 PS1, Line 11: If it was found by Coverity, please add a tag `Found-by:`. -- To view, visit https://review.coreboot.org/c/coreboot/+/52136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19f0718c657d565e515157e66367573e08f51254 Gerrit-Change-Number: 52136 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Tue, 06 Apr 2021 17:19:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021