Attention is currently required from: Matt Papageorge, Felix Held.
Hello Matt Papageorge,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52141
to look at the new patch set (#2).
Change subject: [WIP] mb/google/guybrush/port_descriptors: add dummy descriptors
......................................................................
[WIP] mb/google/guybrush/port_descriptors: add dummy descriptors
Signed-off-by: Matt Papageorge <matthewpapa07(a)gmail.com>
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Ie4c8ff8e827901112fd8b2e993898006bc133241
---
M src/mainboard/google/guybrush/port_descriptors.c
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/52141/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52141
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4c8ff8e827901112fd8b2e993898006bc133241
Gerrit-Change-Number: 52141
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Felix Held.
Felix Held has uploaded a new patch set (#4) to the change originally created by Martin Roth. ( https://review.coreboot.org/c/coreboot/+/52114 )
Change subject: mb/google/guybrush: Add aux PCIe reset GPIOs to dxio descriptors
......................................................................
mb/google/guybrush: Add aux PCIe reset GPIOs to dxio descriptors
pcie_rst isn't working correctly, so use the AUX resets to reset the
PCIe devices before training.
BUG=b:182202136
TEST=See PCIe devices train & enumerate
Change-Id: I6db21c79dcbd40c7a8c3f01c60b02882a3851278
Signed-off-by: Martin Roth <martinroth(a)chromium.org>
---
M src/mainboard/google/guybrush/port_descriptors.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/52114/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/52114
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6db21c79dcbd40c7a8c3f01c60b02882a3851278
Gerrit-Change-Number: 52114
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Matt Papageorge,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51956
to look at the new patch set (#9).
Change subject: [WIP] mb/amd/majolica: add DXIO and DDI descriptors
......................................................................
[WIP] mb/amd/majolica: add DXIO and DDI descriptors
TODO: The devices and function numbers of the PCIe bridges still need to
be tested. The values used in the Majolica UEFI reference implementation
weren't consistent with the PPR.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Signed-off-by: Matt Papageorge <matthewpapa07(a)gmail.com>
Change-Id: I65c7e0ebf1e43fd4608d46bae8a176cfc3d0236b
---
M src/mainboard/amd/majolica/port_descriptors.c
1 file changed, 110 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/51956/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/51956
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65c7e0ebf1e43fd4608d46bae8a176cfc3d0236b
Gerrit-Change-Number: 51956
Gerrit-PatchSet: 9
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52045
to look at the new patch set (#3).
Change subject: mb/amd/majolica: add PCIe devices to devicetree
......................................................................
mb/amd/majolica: add PCIe devices to devicetree
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I838aeda2e6c403eaa3388a6b934e7ab6b4e918e3
---
M src/mainboard/amd/majolica/devicetree.cb
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/52045/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/52045
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I838aeda2e6c403eaa3388a6b934e7ab6b4e918e3
Gerrit-Change-Number: 52045
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Marshall Dawson, Matt Papageorge, Felix Held.
Hello build bot (Jenkins), Matt Papageorge,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51957
to look at the new patch set (#8).
Change subject: mb/google/guybrush: add DXIO and DDI descriptors
......................................................................
mb/google/guybrush: add DXIO and DDI descriptors
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Signed-off-by: Matt Papageorge <matthewpapa07(a)gmail.com>
Change-Id: Ic8a4349315f8759c79dc6b087b2a933c307cd573
---
M src/mainboard/google/guybrush/port_descriptors.c
1 file changed, 71 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/51957/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/51957
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8a4349315f8759c79dc6b087b2a933c307cd573
Gerrit-Change-Number: 51957
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-CC: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Felix Held.
Felix Held has uploaded a new patch set (#8) to the change originally created by Matt Papageorge. ( https://review.coreboot.org/c/coreboot/+/51948 )
Change subject: soc/amd/cezanne: Pass DXIO and DDI Descriptors to FSP
......................................................................
soc/amd/cezanne: Pass DXIO and DDI Descriptors to FSP
This patch adds the functionality to write the DXIO and DDI descriptors
to the UPD data structure to the SoC code and adds the
mainboard_get_dxio_ddi_descriptors function to each mainboard using the
Cezanne SoC that gets called to get the descriptors from the board code.
Change-Id: I1cb36addcf0202cd56ce99e610a13d6d230bc981
Signed-off-by: Matt Papageorge <matthewpapa07(a)gmail.com>
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/mainboard/amd/majolica/Makefile.inc
A src/mainboard/amd/majolica/port_descriptors.c
M src/mainboard/google/guybrush/Makefile.inc
A src/mainboard/google/guybrush/port_descriptors.c
M src/mainboard/google/mancomb/Makefile.inc
A src/mainboard/google/mancomb/port_descriptors.c
M src/soc/amd/cezanne/fsp_m_params.c
A src/soc/amd/cezanne/include/soc/platform_descriptors.h
8 files changed, 126 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/51948/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/51948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cb36addcf0202cd56ce99e610a13d6d230bc981
Gerrit-Change-Number: 51948
Gerrit-PatchSet: 8
Gerrit-Owner: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held.
Hello build bot (Jenkins), Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51955
to look at the new patch set (#7).
Change subject: vc/amd/fsp/cezanne/FspmUpd: use arrays for DXIO/DDI descriptors
......................................................................
vc/amd/fsp/cezanne/FspmUpd: use arrays for DXIO/DDI descriptors
This allows coreboot to easily iterate over the descriptors.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I2ecb3b543f90b8c6a957794f0c55b0ba5c72d59d
---
M src/vendorcode/amd/fsp/cezanne/FspmUpd.h
1 file changed, 5 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/51955/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/51955
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ecb3b543f90b8c6a957794f0c55b0ba5c72d59d
Gerrit-Change-Number: 51955
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Marshall Dawson, Paul Menzel, Matt Papageorge, Felix Held.
Felix Held has uploaded a new patch set (#11) to the change originally created by Matt Papageorge. ( https://review.coreboot.org/c/coreboot/+/51806 )
Change subject: vc/amd/fsp/cezanne: update UPD headers
......................................................................
vc/amd/fsp/cezanne: update UPD headers
The UPD header files get generated as part of the FSP build process. For
the initial Cezanne development we took the Picasso UPD data structures
as a starting point. This patch replaces it with the first version of
the Cezanne-specific UPD data structures that is present in version 12
of the internal work-in-progress FSP binary drops.
The serial_port_stride UPD-M field is removed, since the information is
already given by serial_port_use_mmio. The stride is 4 bytes for the
MMIO UART case and 1 byte for the legacy I/O case.
BUG=b:182524631
TEST=NVMe works on google/guybrush when the rest of the patch train is
applied as well.
Change-Id: Idca235029bf2e68d403230d55308820cab61a6c0
Signed-off-by: Matt Papageorge <matthewpapa07(a)gmail.com>
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/soc/amd/cezanne/fsp_m_params.c
M src/soc/amd/cezanne/fsp_s_params.c
M src/vendorcode/amd/fsp/cezanne/FspmUpd.h
M src/vendorcode/amd/fsp/cezanne/FspsUpd.h
4 files changed, 109 insertions(+), 101 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/51806/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/51806
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idca235029bf2e68d403230d55308820cab61a6c0
Gerrit-Change-Number: 51806
Gerrit-PatchSet: 11
Gerrit-Owner: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset