Attention is currently required from: Michael Niewöhner, Alexander Couzens, HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52144 )
Change subject: ec/lenovo/h9/acpi: fix wrong calculation
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52144/comment/b4ba288a_46e344c1
PS1, Line 7: h9
--
h9 ---> h8
https://review.coreboot.org/c/coreboot/+/52144/comment/40b35d25_d4589354
PS1, Line 9: commit 5461662
this isn't the right commit. Also how about using a Fixes tag:
Fixes: commit 81d55cf6d62ac710df030fc02dd3ca00f3d80405
--
To view, visit https://review.coreboot.org/c/coreboot/+/52144
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701
Gerrit-Change-Number: 52144
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 06 Apr 2021 22:03:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Rob Barnes.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52143 )
Change subject: mb/google/guybrush: Unmask eSPI keyboard IRQ
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/52143/comment/af266e61_949859a0
PS1, Line 118: /* Unmask eSPI IRQ 1 and 12 */
> nit: It'd be helpful to comment what these IRQS map to.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/52143
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1
Gerrit-Change-Number: 52143
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 21:58:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52115 )
Change subject: mb/google/guybrush: PCIe GPIOs - enable enables, disable resets
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52115/comment/1e3c1a10_acf45f74
PS1, Line 54: HIGH
> Not in my experience, no. […]
Reasoning for my comment: Violating timings for PCIe can result in downstream device not being enumerated in some cases which can result in developers debugging issues that wouldn't occur if it was done the right way. It helps with the bringup rather than hurt. This was one of the things that had caused hacks to be added for zork and also had resulted in missed hardware changes until much later. That was the reason I raised this concern to ensure:
1. Either the timings are handled correctly here or
2. The bug you raised captured details about exactly what needs to be done so that it can be picked up by anyone who has cycles.
I will mark this as resolved to let you continue.
https://review.coreboot.org/c/coreboot/+/52115/comment/d0fad776_22441a6e
PS1, Line 169: /* EN_PP3300_WLAN */
> Yes, I absolutely agree with you. I'll get to that when I'm working on the other bug.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/52115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3807e02de1e9ae40b0a4162217afd6aabb5b04ed
Gerrit-Change-Number: 52115
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 21:58:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Rob Barnes.
Hello build bot (Jenkins), Martin Roth, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52143
to look at the new patch set (#3).
Change subject: mb/google/guybrush: Unmask eSPI keyboard IRQ
......................................................................
mb/google/guybrush: Unmask eSPI keyboard IRQ
PS/2 keyboard used IRQ 1.
BUG=none
TEST=Boot guybrush and see internal keyboard working
Signed-off-by: Raul E Rangel <rrangel(a)chromium.org>
Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1
---
M src/mainboard/google/guybrush/mainboard.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/52143/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/52143
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1
Gerrit-Change-Number: 52143
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52142 )
Change subject: soc/amd/common: Add PM_ESPI_INTR_CTRL
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52142
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia209539b2e0ce390e227757b16c2969b9124a845
Gerrit-Change-Number: 52142
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 06 Apr 2021 21:56:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment