coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: mb/google/guybrush: Unmask eSPI keyboard IRQ
by Raul Rangel (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Martin Roth, Rob Barnes. Hello build bot (Jenkins), Martin Roth, Rob Barnes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52143 to look at the new patch set (#3). Change subject: mb/google/guybrush: Unmask eSPI keyboard IRQ ...................................................................... mb/google/guybrush: Unmask eSPI keyboard IRQ PS/2 keyboard used IRQ 1. BUG=none TEST=Boot guybrush and see internal keyboard working Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1 --- M src/mainboard/google/guybrush/mainboard.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/52143/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1 Gerrit-Change-Number: 52143 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/common: Add PM_ESPI_INTR_CTRL
by Rob Barnes (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52142 ) Change subject: soc/amd/common: Add PM_ESPI_INTR_CTRL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia209539b2e0ce390e227757b16c2969b9124a845 Gerrit-Change-Number: 52142 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 06 Apr 2021 21:56:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Unmask eSPI keyboard IRQ
by Rob Barnes (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Raul Rangel, Rob Barnes. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52143 ) Change subject: mb/google/guybrush: Unmask eSPI keyboard IRQ ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/mainboard/google/guybrush/mainboard.c: https://review.coreboot.org/c/coreboot/+/52143/comment/bd3038fe_3762608e PS1, Line 118: /* Unmask eSPI IRQ 1 and 12 */ nit: It'd be helpful to comment what these IRQS map to. -- To view, visit https://review.coreboot.org/c/coreboot/+/52143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1 Gerrit-Change-Number: 52143 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Tue, 06 Apr 2021 21:56:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Remove PS/2 mouse config
by Raul Rangel (Code Review) 06 Apr '21

06 Apr '21

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52145 ) Change subject: mb/google/guybrush: Remove PS/2 mouse config ...................................................................... mb/google/guybrush: Remove PS/2 mouse config Guybrush doesn't have a PS/2 mouse. BUG=none TEST=boot guybrush to the OS Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I87e51d23b69cfd6ad7bb88b364714d679e92728f --- M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/52145/1 diff --git a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb index b90ea0b..9fd138c 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb @@ -35,7 +35,7 @@ .oob_ch_en = 0, .flash_ch_en = 0, - .vw_irq_polarity = ESPI_VW_IRQ_LEVEL_HIGH(1) | ESPI_VW_IRQ_LEVEL_HIGH(12), + .vw_irq_polarity = ESPI_VW_IRQ_LEVEL_HIGH(1), }" register "i2c_scl_reset" = "GPIO_I2C0_SCL | GPIO_I2C1_SCL | -- To view, visit https://review.coreboot.org/c/coreboot/+/52145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87e51d23b69cfd6ad7bb88b364714d679e92728f Gerrit-Change-Number: 52145 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush: Unmask eSPI keyboard IRQ
by Raul Rangel (Code Review) 06 Apr '21

06 Apr '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52143 to look at the new patch set (#2). Change subject: mb/google/guybrush: Unmask eSPI keyboard IRQ ...................................................................... mb/google/guybrush: Unmask eSPI keyboard IRQ PS/2 keyboard used IRQ 1. BUG=none TEST=Boot guybrush and see internal keyboard working Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1 --- M src/mainboard/google/guybrush/mainboard.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/52143/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1 Gerrit-Change-Number: 52143 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/lenovo/h9/acpi: fix wrong calculation
by Michael Niewöhner (Code Review) 06 Apr '21

06 Apr '21

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52144 ) Change subject: ec/lenovo/h9/acpi: fix wrong calculation ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/52144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701 Gerrit-Change-Number: 52144 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 06 Apr 2021 21:54:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "src/ec/lenovo/h8/acpi/battery.asl: Convert to ASL 2.0"
by Michael Niewöhner (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Angel Pons, Arthur Heymans, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51986 ) Change subject: Revert "src/ec/lenovo/h8/acpi/battery.asl: Convert to ASL 2.0" ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: why revert the whole thing, when this issue can be fixed? see CB:52144 -- To view, visit https://review.coreboot.org/c/coreboot/+/51986 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifffe0730fb6f204abf8b5fe99f4e37015bb8d5b7 Gerrit-Change-Number: 51986 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 06 Apr 2021 21:54:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common: Add PM_ESPI_INTR_CTRL
by Martin Roth (Code Review) 06 Apr '21

06 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52142 ) Change subject: soc/amd/common: Add PM_ESPI_INTR_CTRL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia209539b2e0ce390e227757b16c2969b9124a845 Gerrit-Change-Number: 52142 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 06 Apr 2021 21:45:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Unmask eSPI IRQs 1 and 12
by Raul Rangel (Code Review) 06 Apr '21

06 Apr '21

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52143 ) Change subject: mb/google/guybrush: Unmask eSPI IRQs 1 and 12 ...................................................................... mb/google/guybrush: Unmask eSPI IRQs 1 and 12 PS/2 keyboard used IRQ 1, and PS/2 mouse uses IRQ 12. BUG=none TEST=Boot guybrush and see internal keyboard working Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1 --- M src/mainboard/google/guybrush/mainboard.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/52143/1 diff --git a/src/mainboard/google/guybrush/mainboard.c b/src/mainboard/google/guybrush/mainboard.c index 57f658c..08333fb 100644 --- a/src/mainboard/google/guybrush/mainboard.c +++ b/src/mainboard/google/guybrush/mainboard.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +#include <amdblocks/acpimmio.h> #include <amdblocks/amd_pci_util.h> #include <baseboard/variants.h> #include <device/device.h> @@ -113,6 +114,9 @@ init_tables(); /* Initialize the PIRQ data structures for consumption */ pirq_setup(); + + /* Unmask eSPI IRQ 1 and 12 */ + pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1) | BIT(12))); } struct chip_operations mainboard_ops = { -- To view, visit https://review.coreboot.org/c/coreboot/+/52143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1 Gerrit-Change-Number: 52143 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/common: Add PM_ESPI_INTR_CTRL
by Raul Rangel (Code Review) 06 Apr '21

06 Apr '21

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52142 ) Change subject: soc/amd/common: Add PM_ESPI_INTR_CTRL ...................................................................... soc/amd/common: Add PM_ESPI_INTR_CTRL This register is used for masking/unmasking eSPI IRQs. BUG=none TEST=Build guybrush Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Ia209539b2e0ce390e227757b16c2969b9124a845 --- M src/soc/amd/common/block/include/amdblocks/acpimmio.h 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/52142/1 diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h index 9360650..9c007e7 100644 --- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h +++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h @@ -26,6 +26,8 @@ #define LEGACY_DMA_IO_EN (1 << 2) #define CF9_IO_EN (1 << 1) #define LEGACY_IO_EN (1 << 0) +#define PM_ESPI_INTR_CTRL 0x40 +#define PM_ESPI_DEV_INTR_MASK 0x00FFFFFF #define PM_RST_CTRL1 0xbe #define SLPTYPE_CONTROL_EN (1 << 5) #define KBRSTEN (1 << 4) -- To view, visit https://review.coreboot.org/c/coreboot/+/52142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia209539b2e0ce390e227757b16c2969b9124a845 Gerrit-Change-Number: 52142 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021