coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards
by Aseda Aboagye (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Furquan Shaikh, Aaron Durbin, Karthik Ramasubramanian. Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52147 ) Change subject: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/dedede/Kconfig: https://review.coreboot.org/c/coreboot/+/52147/comment/5aac99d9_1db793b6 PS1, Line 38: HECI_DISABLE_USING_SMM > I must have misunderstood your previous comment then. […] Yeah, I can give that a try after lunch. -- To view, visit https://review.coreboot.org/c/coreboot/+/52147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced84faaab8a0cca8400ccd3ec6e4cd525c30e92 Gerrit-Change-Number: 52147 Gerrit-PatchSet: 1 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 07 Apr 2021 18:46:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards
by Aaron Durbin (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Furquan Shaikh, Aseda Aboagye, Karthik Ramasubramanian. Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52147 ) Change subject: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/dedede/Kconfig: https://review.coreboot.org/c/coreboot/+/52147/comment/74d89153_136f5eed PS1, Line 38: HECI_DISABLE_USING_SMM > I did not understand the plan is to drop CONFIG(HECI_DISABLE_USING_SMM) check in smihandler.c too. […] I must have misunderstood your previous comment then. We'll need to remove the following: src/soc/intel/common/block/cse/Kconfig:config SOC_INTEL_COMMON_BLOCK_HECI_DISABLE_IN_SMM And always add this to SMM. src/soc/intel/common/block/cse/Makefile.inc:smm-$(CONFIG_SOC_INTEL_COMMON_BLOCK_HECI_DISABLE_IN_SMM) += disable_heci.c In addition, we'll need to remove all the HECI_DISABLE_USING_SMM options from all the existing paths as well to make that happen properly. Aseda, do you want to give that a go? We'll have to do a few CLs. Let me know if you want me to do that. -- To view, visit https://review.coreboot.org/c/coreboot/+/52147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced84faaab8a0cca8400ccd3ec6e4cd525c30e92 Gerrit-Change-Number: 52147 Gerrit-PatchSet: 1 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 07 Apr 2021 18:35:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lillupup: provide additional VBT for lillipup OLED sku
by YH Lin (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Kevin Chang, Nick Vaccaro, YH Lin, Zhuohao Lee. YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52150 ) Change subject: lillupup: provide additional VBT for lillipup OLED sku ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I576297b8296def3c37a01ae0223fa332aa9f02b1 Gerrit-Change-Number: 52150 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com> Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Wed, 07 Apr 2021 18:34:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/xeon_sp: Set MSR locks
by Marc Jones (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Jonathan Zhang, Stefan Reinauer, Arthur Heymans, Patrick Rudolph. Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52160 ) Change subject: soc/intel/xeon_sp: Set MSR locks ...................................................................... Patch Set 1: (2 comments) File src/soc/intel/xeon_sp/Kconfig: https://review.coreboot.org/c/coreboot/+/52160/comment/afddf2f1_82de4c10 PS1, Line 39: PARALLEL_MP_AP_WORK > remove from tiogapass Kconfig. Ack File src/soc/intel/xeon_sp/cpx/chip.c: https://review.coreboot.org/c/coreboot/+/52160/comment/3d8ecb59_56bd5e60 PS1, Line 146: set_msr_locks > This has to happen so late or can it happen during the CPU init? I think that this could happen in each_cpu_init, but I have been getting feedback to set the locks in finalize functions. *s, shrug* I guess someone might change turbo just prior to ACPI table setup. AES lock could be set anytime. -- To view, visit https://review.coreboot.org/c/coreboot/+/52160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacf495f0880d42b378cb0d2c37940d50a511c430 Gerrit-Change-Number: 52160 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 07 Apr 2021 18:29:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variants/copano: Modify touch controller power sequ...
by Nick Vaccaro (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Hao Chou, Paul2 Huang, Ken Lu. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52015 ) Change subject: mb/google/volteer/variants/copano: Modify touch controller power sequence ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Will +2 once Zhuohao's comment is responded to. -- To view, visit https://review.coreboot.org/c/coreboot/+/52015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea84046c1b1f3fe6ab8bb89d86d00b1e89325f71 Gerrit-Change-Number: 52015 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-CC: Ariel Chang <ariel_chang(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com> Gerrit-Attention: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 07 Apr 2021 18:23:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/acpi: Add APEI EINJ support
by Jonathan Zhang (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Marc Jones, Furquan Shaikh, Duncan Laurie, Angel Pons, Rocky Phagura. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49286 ) Change subject: src/acpi: Add APEI EINJ support ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49286 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29c6a861c564ec104f2c097f3e49b3e6d38b040e Gerrit-Change-Number: 49286 Gerrit-PatchSet: 6 Gerrit-Owner: Rocky Phagura Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <duncan(a)iceblink.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Duncan Laurie <duncan(a)iceblink.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Rocky Phagura Gerrit-Comment-Date: Wed, 07 Apr 2021 18:17:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards
by Karthik Ramasubramanian (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Furquan Shaikh, Aseda Aboagye, Aaron Durbin. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52147 ) Change subject: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/dedede/Kconfig: https://review.coreboot.org/c/coreboot/+/52147/comment/a777c4f3_9116f371 PS1, Line 38: HECI_DISABLE_USING_SMM > Why would we need to keep this in Kconfig based on your suggestion? […] I did not understand the plan is to drop CONFIG(HECI_DISABLE_USING_SMM) check in smihandler.c too. As you mentioned we can drop it and make it entirely devicetree driven. -- To view, visit https://review.coreboot.org/c/coreboot/+/52147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced84faaab8a0cca8400ccd3ec6e4cd525c30e92 Gerrit-Change-Number: 52147 Gerrit-PatchSet: 1 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Wed, 07 Apr 2021 18:17:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards
by Aaron Durbin (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Furquan Shaikh, Aseda Aboagye, Karthik Ramasubramanian. Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52147 ) Change subject: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/dedede/Kconfig: https://review.coreboot.org/c/coreboot/+/52147/comment/193bb576_4ab52404 PS1, Line 38: HECI_DISABLE_USING_SMM > Why would we need to keep this in Kconfig based on your suggestion? […] Digging into this a little further, the only thing I can see the point of HECI_DISABLE_USING_SMM is to perform dead code elimination. -- To view, visit https://review.coreboot.org/c/coreboot/+/52147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced84faaab8a0cca8400ccd3ec6e4cd525c30e92 Gerrit-Change-Number: 52147 Gerrit-PatchSet: 1 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 07 Apr 2021 18:13:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/mb/ocp: Update Delta Lake documentation
by Jonathan Zhang (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Johnny Lin, Paul Menzel, Stefan Reinauer, Sumeet R Pawnikar, Angel Pons, ron minnich, Tim Chu. Hello build bot (Jenkins), Marc Jones, Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, Stefan Reinauer, Angel Pons, Arthur Heymans, ron minnich, Tim Chu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51824 to look at the new patch set (#8). Change subject: Documentation/mb/ocp: Update Delta Lake documentation ...................................................................... Documentation/mb/ocp: Update Delta Lake documentation Update OCP Delta Lake documentation following OSF (Open System Firmware) solution reaching DVT exit parity. This alternative host firmware solution uses FSP/coreboot/Linuxboot stack. Signed-off-by: Jonathan Zhang <jonzhang(a)fb.com> Change-Id: Ifd6ab251cd7806cf8cd3f984ad88c091f85035cf --- M Documentation/mainboard/ocp/deltalake.md 1 file changed, 38 insertions(+), 30 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/51824/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/51824 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd6ab251cd7806cf8cd3f984ad88c091f85035cf Gerrit-Change-Number: 51824 Gerrit-PatchSet: 8 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake: Configure FSP UPDs for minimum assertion widths
by Tim Wawrzynczak (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Rizwan Qureshi, Nick Vaccaro, Sridhar Siricilla, Meera Ravindranath, Patrick Rudolph, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51846 ) Change subject: soc/intel/alderlake: Configure FSP UPDs for minimum assertion widths ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/alderlake/chip.h: https://review.coreboot.org/c/coreboot/+/51846/comment/fd48f92a_84331ee1 PS2, Line 316: /* : * SLP_S3 Minimum Assertion Width Policy : * 1 = 60us : * 2 = 1ms : * 3 = 50ms (default) : * 4 = 2s : */ : uint8_t PchPmSlpS3MinAssert; : : /* : * SLP_S4 Minimum Assertion Width Policy : * 1 = 1s (default) : * 2 = 2s : * 3 = 3s : * 4 = 4s : */ : uint8_t PchPmSlpS4MinAssert; : : /* : * SLP_SUS Minimum Assertion Width Policy : * 1 = 0ms : * 2 = 500ms : * 3 = 1s : * 4 = 4s (default) : */ : uint8_t PchPmSlpSusMinAssert; : : /* : * SLP_A Minimum Assertion Width Policy : * 1 = 0ms : * 2 = 4s : * 3 = 98ms : * 4 = 2s (default) : */ : uint8_t PchPmSlpAMinAssert; : : /* : * PCH PM Reset Power Cycle Duration : * 0 = 4s (default) : * 1 = 1s : * 2 = 2s : * 3 = 3s : * 4 = 4s : * : * NOTE: Duration programmed in the PchPmPwrCycDur should never be smaller than the : * stretch duration programmed in the following registers: : * - GEN_PMCON_A.SLP_S3_MIN_ASST_WDTH (PchPmSlpS3MinAssert) : * - GEN_PMCON_A.S4MAW (PchPmSlpS4MinAssert) : * - PM_CFG.SLP_A_MIN_ASST_WDTH (PchPmSlpAMinAssert) : * - PM_CFG.SLP_LAN_MIN_ASST_WDTH : */ : uint8_t PchPmPwrCycDur; > That sounds okay to me. […] Other option would be to just use the enums as symbolic only, and leave their values specified as the FSP values: ``` enum { SlpS3_MinAssert_60us = 1, SlpS3_MinAssert_1ms = 2, SlpS3_MinAssert_50ms = 3, SlpS3_MinAssert_2s = = 4, } PchPmSlpS3MinAssert; ``` etc. -- To view, visit https://review.coreboot.org/c/coreboot/+/51846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91bd49d35f80fbde4aa3b7ec816217d2c1a5853e Gerrit-Change-Number: 51846 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 07 Apr 2021 18:09:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021