coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: soc/intel/common/block/irq: Add support for intel_write_pci0_PRT
by Nick Vaccaro (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51159 ) Change subject: soc/intel/common/block/irq: Add support for intel_write_pci0_PRT ...................................................................... Patch Set 10: Code-Review+2 (1 comment) Patchset: PS10: Works on my voxel. -- To view, visit https://review.coreboot.org/c/coreboot/+/51159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21a4835890ca03bff83ed0e8791441b3af54cb62 Gerrit-Change-Number: 51159 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 07 Apr 2021 19:41:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Add new IRQ module
by Nick Vaccaro (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Nico Huber, Tim Wawrzynczak. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49408 ) Change subject: soc/intel/common: Add new IRQ module ...................................................................... Patch Set 26: Code-Review+2 (1 comment) Patchset: PS26: Works on my voxel. -- To view, visit https://review.coreboot.org/c/coreboot/+/49408 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c22a08ce589fa80d0bb1e637422304a3af2045c Gerrit-Change-Number: 49408 Gerrit-PatchSet: 26 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Duncan Laurie <duncan(a)iceblink.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 07 Apr 2021 19:40:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Add function to lpc_lib to return PIRQ routing
by Nick Vaccaro (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Tim Wawrzynczak, Angel Pons. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50858 ) Change subject: soc/intel/common: Add function to lpc_lib to return PIRQ routing ...................................................................... Patch Set 14: Code-Review+2 (2 comments) Patchset: PS14: > PIRQ_* are redefined somewhere in the last few patchsets of 50857 as Angel mentioned. Ah, my mistake. Initially, I tried cherry-picking that CL to the firmware branch and it ran into conflicts, which made me realize that I should be doing this on top-of-tree main, so I switched to main, but went on to cherry-pick the next CL in the stack instead of the base CL again as I had copied the next cherry-pick command before the previous one finished. PS14: Works on my voxel. -- To view, visit https://review.coreboot.org/c/coreboot/+/50858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib215fba54573c50a88aa4584442bd8d27ae017be Gerrit-Change-Number: 50858 Gerrit-PatchSet: 14 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Apr 2021 19:39:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/common: Refactor _PRT generation to support GSI-based tables
by Nick Vaccaro (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Patrick Rudolph. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50857 ) Change subject: sb/intel/common: Refactor _PRT generation to support GSI-based tables ...................................................................... Patch Set 19: Code-Review+2 (1 comment) Patchset: PS19: Works on my voxel. -- To view, visit https://review.coreboot.org/c/coreboot/+/50857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica420a3d12fd1d64c8fe6e4b326fd779b3f10868 Gerrit-Change-Number: 50857 Gerrit-PatchSet: 19 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 07 Apr 2021 19:38:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common: Handle power resume after power failure
by Karthik Ramasubramanian (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Martin Roth, Karthik Ramasubramanian, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Furquan Shaikh, Patrick Georgi, Martin Roth, Marshall Dawson, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51924 to look at the new patch set (#5). Change subject: soc/amd/common: Handle power resume after power failure ...................................................................... soc/amd/common: Handle power resume after power failure Introduce a power management library to handle the power resume after power failure. Enable HAVE_POWER_STATE_AFTER_FAILURE config when this library is enabled. BUG=b:183739671 TEST=Build Guybrush and Majolica mainboard. Change-Id: Iea4ea57d747425fe6714d40ba6e60f2447febf28 Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- A src/soc/amd/common/block/include/amdblocks/pmlib.h A src/soc/amd/common/block/pm/Kconfig A src/soc/amd/common/block/pm/Makefile.inc A src/soc/amd/common/block/pm/pmlib.c 4 files changed, 77 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/51924/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/51924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea4ea57d747425fe6714d40ba6e60f2447febf28 Gerrit-Change-Number: 51924 Gerrit-PatchSet: 5 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb with INTEL_HASWELL: Remove double APM finalize call
by Arthur Heymans (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Arthur Heymans. Hello Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52168 to look at the new patch set (#2). Change subject: mb with INTEL_HASWELL: Remove double APM finalize call ...................................................................... mb with INTEL_HASWELL: Remove double APM finalize call Calling APM_CNT_FINALIZE is already done in southbridge/intel/lynxpoint/lpc.c in lpc_final(). Change-Id: Ic615c39762840de1bd4583a359dd7da74f0ae062 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/google/beltino/mainboard.c M src/mainboard/google/slippy/mainboard.c M src/mainboard/intel/baskingridge/mainboard.c 3 files changed, 0 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/52168/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic615c39762840de1bd4583a359dd7da74f0ae062 Gerrit-Change-Number: 52168 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb with INTEL_HASWELL: Remove double APM finalize call
by Angel Pons (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52168 ) Change subject: mb with INTEL_HASWELL: Remove double APM finalize call ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I guess this was done to allow the chipset to be finalized later. However, this doesn't seem to be required anymore. -- To view, visit https://review.coreboot.org/c/coreboot/+/52168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic615c39762840de1bd4583a359dd7da74f0ae062 Gerrit-Change-Number: 52168 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 07 Apr 2021 19:31:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/{google/jecht,intel/wtm2}: Remove NOOP APM finalize call
by Angel Pons (Code Review) 07 Apr '21

07 Apr '21

Attention is currently required from: Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52167 ) Change subject: mb/{google/jecht,intel/wtm2}: Remove NOOP APM finalize call ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2bcec7cce00d433a197a9e2fb01434a2998e1452 Gerrit-Change-Number: 52167 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 07 Apr 2021 19:29:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb with INTEL_HASWELL: Remove double APM finalize call
by Arthur Heymans (Code Review) 07 Apr '21

07 Apr '21

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52168 ) Change subject: mb with INTEL_HASWELL: Remove double APM finalize call ...................................................................... mb with INTEL_HASWELL: Remove double APM finalize call Calling APM_CNT_FINALIZE is already done in southbridge/intel/lynxpoint/lpc.c in lpc_final(). Change-Id: Ic615c39762840de1bd4583a359dd7da74f0ae062 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/google/beltino/mainboard.c M src/mainboard/google/slippy/mainboard.c M src/mainboard/intel/baskingridge/mainboard.c 3 files changed, 0 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/52168/1 diff --git a/src/mainboard/google/beltino/mainboard.c b/src/mainboard/google/beltino/mainboard.c index 7eba3c2..cb4b454 100644 --- a/src/mainboard/google/beltino/mainboard.c +++ b/src/mainboard/google/beltino/mainboard.c @@ -1,19 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <acpi/acpi.h> -#include <cpu/x86/smm.h> #include <device/device.h> -#include <southbridge/intel/lynxpoint/pch.h> #include <vendorcode/google/chromeos/chromeos.h> #include "onboard.h" -void mainboard_suspend_resume(void) -{ - /* Call SMM finalize() handlers before resume */ - apm_control(APM_CNT_FINALIZE); -} - static void mainboard_init(struct device *dev) { lan_init(); diff --git a/src/mainboard/google/slippy/mainboard.c b/src/mainboard/google/slippy/mainboard.c index 90f28e7..63d81e5 100644 --- a/src/mainboard/google/slippy/mainboard.c +++ b/src/mainboard/google/slippy/mainboard.c @@ -1,21 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <smbios.h> -#include <cpu/x86/smm.h> #include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <acpi/acpi.h> #include <southbridge/intel/lynxpoint/pch.h> #include <vendorcode/google/chromeos/chromeos.h> #include "ec.h" #include "onboard.h" -void mainboard_suspend_resume(void) -{ - /* Call SMM finalize() handlers before resume */ - apm_control(APM_CNT_FINALIZE); -} - static void mainboard_init(struct device *dev) { mainboard_ec_init(); diff --git a/src/mainboard/intel/baskingridge/mainboard.c b/src/mainboard/intel/baskingridge/mainboard.c index 04803fa..e9583ac 100644 --- a/src/mainboard/intel/baskingridge/mainboard.c +++ b/src/mainboard/intel/baskingridge/mainboard.c @@ -1,18 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <cpu/x86/smm.h> #include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <acpi/acpi.h> -#include <southbridge/intel/lynxpoint/pch.h> #include <vendorcode/google/chromeos/chromeos.h> -void mainboard_suspend_resume(void) -{ - /* Call SMM finalize() handlers before resume */ - apm_control(APM_CNT_FINALIZE); -} - // mainboard_enable is executed as first thing after // enumerate_buses(). -- To view, visit https://review.coreboot.org/c/coreboot/+/52168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic615c39762840de1bd4583a359dd7da74f0ae062 Gerrit-Change-Number: 52168 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/{google/jecht,intel/wtm2}: Remove NOOP APM finalize call
by Arthur Heymans (Code Review) 07 Apr '21

07 Apr '21

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52167 ) Change subject: mb/{google/jecht,intel/wtm2}: Remove NOOP APM finalize call ...................................................................... mb/{google/jecht,intel/wtm2}: Remove NOOP APM finalize call The intel/soc/broadwell smihandler has no handler for this APM call. Change-Id: I2bcec7cce00d433a197a9e2fb01434a2998e1452 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/google/jecht/mainboard.c M src/mainboard/intel/wtm2/mainboard.c 2 files changed, 0 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/52167/1 diff --git a/src/mainboard/google/jecht/mainboard.c b/src/mainboard/google/jecht/mainboard.c index 786695d..7fdcce8 100644 --- a/src/mainboard/google/jecht/mainboard.c +++ b/src/mainboard/google/jecht/mainboard.c @@ -1,16 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <acpi/acpi.h> -#include <cpu/x86/smm.h> #include <vendorcode/google/chromeos/chromeos.h> #include "onboard.h" -void mainboard_suspend_resume(void) -{ - /* Call SMM finalize() handlers before resume */ - apm_control(APM_CNT_FINALIZE); -} - static void mainboard_init(struct device *dev) { lan_init(); diff --git a/src/mainboard/intel/wtm2/mainboard.c b/src/mainboard/intel/wtm2/mainboard.c index 48568cd..e9583ac 100644 --- a/src/mainboard/intel/wtm2/mainboard.c +++ b/src/mainboard/intel/wtm2/mainboard.c @@ -1,17 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <cpu/x86/smm.h> #include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <acpi/acpi.h> #include <vendorcode/google/chromeos/chromeos.h> -void mainboard_suspend_resume(void) -{ - /* Call SMM finalize() handlers before resume */ - apm_control(APM_CNT_FINALIZE); -} - // mainboard_enable is executed as first thing after // enumerate_buses(). -- To view, visit https://review.coreboot.org/c/coreboot/+/52167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2bcec7cce00d433a197a9e2fb01434a2998e1452 Gerrit-Change-Number: 52167 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021