coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: mb/google/guybrush/var/guybrush: Add FPMCU configration
by Ivy Jian (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Furquan Shaikh, Mathew King, Bhanu Prakash Maiya, Ivy Jian. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Mathew King, Bhanu Prakash Maiya, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52181 to look at the new patch set (#7). Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration ...................................................................... mb/google/guybrush/var/guybrush: Add FPMCU configration Enable CRFP in devicetree with power sequency control. BUG=b:182201937 BRANCH=None TEST=Boot into OS then FPMCU is responding. Signed-off-by: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Change-Id: I7c56b0db193be6804d07c2f333445c2a1dbf9f59 --- M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/guybrush/variants/guybrush/overridetree.cb 2 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/52181/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/52181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c56b0db193be6804d07c2f333445c2a1dbf9f59 Gerrit-Change-Number: 52181 Gerrit-PatchSet: 7 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mv/intel/shadowmountain: Enable Bluetooth flag in the devicetree
by Subrata Banik (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: V Sowmya, Rizwan Qureshi, Sridhar Siricilla, Meera Ravindranath, Balaji Manigandan, Deepti Deshatty. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52182 ) Change subject: mv/intel/shadowmountain: Enable Bluetooth flag in the devicetree ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/52182/comment/4a433649_33557d45 PS3, Line 7: mv mb https://review.coreboot.org/c/coreboot/+/52182/comment/f70aef9b_15d37185 PS3, Line 7: flag config https://review.coreboot.org/c/coreboot/+/52182/comment/21babd67_4a0e5bd4 PS3, Line 9: flag config https://review.coreboot.org/c/coreboot/+/52182/comment/b2602cae_59011283 PS3, Line 12: Verified on shadowmountain may be lsusb to list BT device something like that ? -- To view, visit https://review.coreboot.org/c/coreboot/+/52182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a54d344ef1b0418bee56e7308977a61604b954a Gerrit-Change-Number: 52182 Gerrit-PatchSet: 3 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 08:43:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: intel/common/block/tcss: Add a weak funtion for mainboard_tcss_get_po...
by Rizwan Qureshi (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Patrick Rudolph. Hello Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52183 to look at the new patch set (#2). Change subject: intel/common/block/tcss: Add a weak funtion for mainboard_tcss_get_port_info() ...................................................................... intel/common/block/tcss: Add a weak funtion for mainboard_tcss_get_port_info() Some of the TCSS code was moved to a common location. Add a weak funtion for mainboard hook. This will help unlink the mainboard and SoC patches and they can be pushed independently. Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Change-Id: I6ccc799f28d45f5ffd0e9b8179ed973744af8113 --- M src/soc/intel/common/block/tcss/tcss.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/52183/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ccc799f28d45f5ffd0e9b8179ed973744af8113 Gerrit-Change-Number: 52183 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: intel/common/block/tcss: Add a weak funtion mainboard_tcss_get_port_i...
by Rizwan Qureshi (Code Review) 08 Apr '21

08 Apr '21

Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52183 ) Change subject: intel/common/block/tcss: Add a weak funtion mainboard_tcss_get_port_info() ...................................................................... intel/common/block/tcss: Add a weak funtion mainboard_tcss_get_port_info() Some of the TCSS code was moved to a common location. Add a weak funtion for mainboard hook. This will help unlink the mainboard and SoC patches and they can be pushed independently. Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Change-Id: I6ccc799f28d45f5ffd0e9b8179ed973744af8113 --- M src/soc/intel/common/block/tcss/tcss.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/52183/1 diff --git a/src/soc/intel/common/block/tcss/tcss.c b/src/soc/intel/common/block/tcss/tcss.c index 6d1f3af..dd7c475 100644 --- a/src/soc/intel/common/block/tcss/tcss.c +++ b/src/soc/intel/common/block/tcss/tcss.c @@ -10,6 +10,12 @@ #include <soc/pci_devs.h> #include <stdlib.h> +__weak const struct tcss_port_map *mainboard_tcss_get_port_info(size_t *num_ports) +{ + printk(BIOS_ERR, "Mainboard TCSS port info missing\n"); + return NULL; +} + static uint32_t tcss_make_conn_cmd(int u, int u3, int u2, int ufp, int hsl, int sbu, int acc) { -- To view, visit https://review.coreboot.org/c/coreboot/+/52183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ccc799f28d45f5ffd0e9b8179ed973744af8113 Gerrit-Change-Number: 52183 Gerrit-PatchSet: 1 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/facebook/fbg1701/Kconfig: Remove TPM_INIT
by Erik van den Bogaert (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Michał Żygowski, Frans Hendriks, Arthur Heymans. Erik van den Bogaert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52051 ) Change subject: mb/facebook/fbg1701/Kconfig: Remove TPM_INIT ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91bde691d445d4210429c928e90e16653092f1cb Gerrit-Change-Number: 52051 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 08 Apr 2021 08:11:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Add lib/coreboot_table-test test case
by Jakub Czapiga (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Martin Roth, Jakub Czapiga, Paul Fagerburg, Julius Werner, Jan Dabros. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Fagerburg, Julius Werner, Jan Dabros, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52159 to look at the new patch set (#2). Change subject: tests: Add lib/coreboot_table-test test case ...................................................................... tests: Add lib/coreboot_table-test test case Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: I4d7d9ca43316bf514bb5ebd8909f441bcfa20eba --- M tests/lib/Makefile.inc A tests/lib/coreboot_table-test.c 2 files changed, 508 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/52159/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d7d9ca43316bf514bb5ebd8909f441bcfa20eba Gerrit-Change-Number: 52159 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/adlrvp: Enable HECI1 communication
by Maulik V Vaghela (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Sridhar Siricilla, Balaji Manigandan. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52149 ) Change subject: mb/intel/adlrvp: Enable HECI1 communication ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34ff842481bdfc7933a76555ff0fd70f4fbbb9a7 Gerrit-Change-Number: 52149 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 07:37:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/guybrush: Add FPMCU configration
by EricR Lai (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Furquan Shaikh, Mathew King, Bhanu Prakash Maiya, Ivy Jian. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 ) Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/guybrush/variants/guybrush/variant.c: https://review.coreboot.org/c/coreboot/+/52181/comment/39fcaf68_c31013b6 PS4, Line 8: variant_fpmcu_init > I think instead of adding a special function to handle the power-on, we should invest in adding a sp […] I think we can just use the has_power_resource since uart/acpi already support it. Will try :p -- To view, visit https://review.coreboot.org/c/coreboot/+/52181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c56b0db193be6804d07c2f333445c2a1dbf9f59 Gerrit-Change-Number: 52181 Gerrit-PatchSet: 6 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 07:29:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/boten: Add custom Wifi SAR for botenflex
by Stanley Wu (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Martin Roth, Furquan Shaikh, Karthik Ramasubramanian. Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51501 ) Change subject: mb/google/dedede/var/boten: Add custom Wifi SAR for botenflex ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/dedede/variants/boten/variant.c: https://review.coreboot.org/c/coreboot/+/51501/comment/c4a52428_add83631 PS4, Line 32: 0x90000 > Yes, it will. Can you build the variant. […] Add variant.c for ramstage and smm and build pass without failure. Wifi SAR also verify pass on boten and botenflex. Thanks for your comment. -- To view, visit https://review.coreboot.org/c/coreboot/+/51501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3f2529a7ad56ff306df98f77cda556656da52a5 Gerrit-Change-Number: 51501 Gerrit-PatchSet: 6 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Henry Sun <henrysun(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 07:29:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/boten: Add custom Wifi SAR for botenflex
by Stanley Wu (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Martin Roth, Furquan Shaikh, Stanley Wu. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51501 to look at the new patch set (#6). Change subject: mb/google/dedede/var/boten: Add custom Wifi SAR for botenflex ...................................................................... mb/google/dedede/var/boten: Add custom Wifi SAR for botenflex Add wifi sar for botenflex. Due to fw-config cannot distinguish between boten and botenflex. Using sku_id to decide to load botenflex custom wifi sar. Detail reason for using sku_id in b:182433707. BUG=b:182433707 TEST=build and test on boten/botenflex Cq-Depend: chrome-internal:3686313 Change-Id: Id3f2529a7ad56ff306df98f77cda556656da52a5 Signed-off-by: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/boten/Makefile.inc M src/mainboard/google/dedede/variants/boten/variant.c 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/51501/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/51501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3f2529a7ad56ff306df98f77cda556656da52a5 Gerrit-Change-Number: 51501 Gerrit-PatchSet: 6 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Henry Sun <henrysun(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021