coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: ec/lenovo/h8/acpi: fix wrong calculation
by Michael Niewöhner (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52144 ) Change subject: ec/lenovo/h8/acpi: fix wrong calculation ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52144/comment/f3b0a8b2_f80e8b08 PS3, Line 11: wrongly converted > nit: since this works as a compound adjective, it should be hyphenated: `wrongly-converted` both is correct, so I leave it as-is :) -- To view, visit https://review.coreboot.org/c/coreboot/+/52144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701 Gerrit-Change-Number: 52144 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 08 Apr 2021 22:01:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: revert renaming of CONFIG_MAX_PCIE_CLOCKS
by Rizwan Qureshi (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Rizwan Qureshi, Patrick Rudolph. Hello build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52194 to look at the new patch set (#2). Change subject: soc/intel/alderlake: revert renaming of CONFIG_MAX_PCIE_CLOCKS ...................................................................... soc/intel/alderlake: revert renaming of CONFIG_MAX_PCIE_CLOCKS CONFIG_MAX_PCIE_CLOCKS was renamed to MAX_PCIE_CLOCK_SRC in alderlake. However, this config is being used in common/block/pcie/rtd3 to check Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Change-Id: I747c94331b68c4ec0b6b5a04149856a4bb384829 --- M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/romstage/fsp_params.c 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/52194/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I747c94331b68c4ec0b6b5a04149856a4bb384829 Gerrit-Change-Number: 52194 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: fix wrong calculation
by Angel Pons (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Michael Niewöhner, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52144 ) Change subject: ec/lenovo/h8/acpi: fix wrong calculation ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/52144/comment/1fa69d32_c4799984 PS3, Line 10: BUG hmmm... ok, the kind of BUG that triggers a kernel warning, or a panic if enabled. https://review.coreboot.org/c/coreboot/+/52144/comment/17b2c31d_4c50a79e PS3, Line 11: wrongly converted nit: since this works as a compound adjective, it should be hyphenated: `wrongly-converted` -- To view, visit https://review.coreboot.org/c/coreboot/+/52144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701 Gerrit-Change-Number: 52144 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 08 Apr 2021 21:56:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: fix wrong calculation
by Michael Niewöhner (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52144 ) Change subject: ec/lenovo/h8/acpi: fix wrong calculation ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/52144/comment/bde8a745_ad99ad8f PS2, Line 8: > It’d be great, if you elaborated a bit. Done https://review.coreboot.org/c/coreboot/+/52144/comment/725ef869_6b58e179 PS2, Line 9: Fixes: commit 81d55cf6d62ac710df030fc02dd3ca00f3d80405 > Please use the common style referencing the commit (also known from the Linux kernel). well, git log doesn't really show a common style \o/ -- To view, visit https://review.coreboot.org/c/coreboot/+/52144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701 Gerrit-Change-Number: 52144 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 08 Apr 2021 21:51:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: fix wrong calculation
by Michael Niewöhner (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes. Hello build bot (Jenkins), Nico Huber, Angel Pons, Arthur Heymans, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52144 to look at the new patch set (#3). Change subject: ec/lenovo/h8/acpi: fix wrong calculation ...................................................................... ec/lenovo/h8/acpi: fix wrong calculation The conversion to ASL 2.0 syntax in commit 81d55cf introduced a regression triggering a BUG in Linux when reading the battery current. Correct the wrongly converted calculation. Fixes: 81d55cf ("src/ec/lenovo/h8/acpi/battery.asl: Convert to ASL 2.0") Tested-by: Andrew A. I. <aidron(a)yandex.ru> Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/ec/lenovo/h8/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/52144/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701 Gerrit-Change-Number: 52144 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/common: Handle power resume after power failure
by Felix Held (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51924 ) Change subject: soc/amd/common: Handle power resume after power failure ...................................................................... Patch Set 6: (1 comment) File src/soc/amd/common/block/pm/pmlib.c: https://review.coreboot.org/c/coreboot/+/51924/comment/5ccb120a_7ef72291 PS6, Line 40: val = pm_io_read8(PM_RTC_SHADOW_REG) & ~PWR_FAIL_MASK; had a look in the agesa reference code (FchAcLossControl) and it masks off the 4 least significant bits, sets bit 2 and sets bits 0 and 1 according to the setting. this code doesn't clear bit 3 -- To view, visit https://review.coreboot.org/c/coreboot/+/51924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea4ea57d747425fe6714d40ba6e60f2447febf28 Gerrit-Change-Number: 51924 Gerrit-PatchSet: 6 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 21:48:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F
by Michael Niewöhner (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Felix Singer, Christian Walter, Angel Pons, Arthur Heymans. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 ) Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F ...................................................................... Patch Set 67: (16 comments) File Documentation/mainboard/supermicro/x11-lga1151v2-series/x11-lga1151v2-series.md: https://review.coreboot.org/c/coreboot/+/37441/comment/337de7a8_d210319e PS67, Line 34: - Fix TODOs mentioned in code are there any? guess that was copypasta from x11-lga1151 File MAINTAINERS: https://review.coreboot.org/c/coreboot/+/37441/comment/64312263_611d8f94 PS67, Line 438: s missing trailing slash File src/mainboard/supermicro/x11-lga1151v2-series/Kconfig: https://review.coreboot.org/c/coreboot/+/37441/comment/c8deb5df_9f85cc49 PS67, Line 13: SUPERIO_ASPEED_COMMON_PRE_RAM selected by SUPERIO_ASPEED_AST2400 https://review.coreboot.org/c/coreboot/+/37441/comment/1e5d295d_dc282d47 PS67, Line 15: select NO_FADT_8042 File src/mainboard/supermicro/x11-lga1151v2-series/devicetree.cb: https://review.coreboot.org/c/coreboot/+/37441/comment/a8458d59_870bc358 PS67, Line 12: # SPS doesn't support all commands issued by FSP huh? heciretry is not a different command but just a for-loop for retry sending commands https://review.coreboot.org/c/coreboot/+/37441/comment/08919c8c_6968cb8f PS67, Line 38: nit: tab https://review.coreboot.org/c/coreboot/+/37441/comment/ddbf4b0c_2c34a93c PS67, Line 48: ataPortsEnable" = "{ \ : [0] = 1, \ : [1] = 1, \ : [2] = 1, \ : [3] = 1, \ : [4] = 1, \ : [5] = 1, \ : [6] = 1, \ : [7] = 1, \ : }" no escaping needed https://review.coreboot.org/c/coreboot/+/37441/comment/8ec41e9c_c4eb0b33 PS67, Line 92: device pci 1f.2 off end # PMC is the pmc really disabled on vendor fw? File src/mainboard/supermicro/x11-lga1151v2-series/ramstage.c: https://review.coreboot.org/c/coreboot/+/37441/comment/9cd7654c_96c3ff46 PS67, Line 7: mainboard_silicon_init_params this function should only be used for fsp params, as it's name says. better use mainboard ops. see for example: src/mainboard/supermicro/x11-lga1151-series/mainboard.c File src/mainboard/supermicro/x11-lga1151v2-series/romstage.c: https://review.coreboot.org/c/coreboot/+/37441/comment/ad999e59_10ff1e60 PS67, Line 38: .ect = 0, defaults to 0, doesn't it? File src/mainboard/supermicro/x11-lga1151v2-series/variants/x11sch-f/overridetree.cb: https://review.coreboot.org/c/coreboot/+/37441/comment/e67afe3e_7727a25e PS64, Line 6: > *poke* sry for the delay. it's not required, but makes matching acpi code easier, when gpe mapping matches. File src/mainboard/supermicro/x11-lga1151v2-series/variants/x11sch-f/overridetree.cb: https://review.coreboot.org/c/coreboot/+/37441/comment/0422c813_e6ff3650 PS67, Line 22: USB 2.0/3.0 : : # USB OC0 : register "usb2_ports[0]" = "USB2_PORT_MID(OC0)" : register "usb2_ports[2]" = "USB2_PORT_MID(OC0)" : : # USB OC1 : register "usb2_ports[1]" = "USB2_PORT_MID(OC1)" : register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC1)" : : # USB OC2 : register "usb2_ports[3]" = "USB2_PORT_MID(OC2)" : register "usb2_ports[5]" = "USB2_PORT_MID(OC2)" : register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC2)" : register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC2)" : : # USB OC3 : register "usb2_ports[4]" = "USB2_PORT_MID(OC3)" : register "usb2_ports[6]" = "USB2_PORT_MID(OC3)" : : # USB OC4 : register "usb2_ports[7]" = "USB2_PORT_MID(OC4)" : register "usb2_ports[9]" = "USB2_PORT_MID(OC4)" : : # USB OC5 : register "usb2_ports[8]" = "USB2_PORT_MID(OC5)" : register "usb2_ports[10]" = "USB2_PORT_MID(OC5)" : register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC5)" : register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC5)" : : # USB KCS : register "usb2_ports[13]" = "USB2_PORT_MID(OC_SKIP)" : : # USB OC6/7 - not xhci could be added below and this moved into it. not a must, though. feel free to just close. https://review.coreboot.org/c/coreboot/+/37441/comment/94d68938_174eb6f5 PS67, Line 58: On to avoid coalescing? what for? https://review.coreboot.org/c/coreboot/+/37441/comment/87790c3a_1569bd98 PS67, Line 75: On to avoid coalescing? what for? https://review.coreboot.org/c/coreboot/+/37441/comment/e4c2f5f7_4d008702 PS67, Line 87: smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" : "M.2-P_1" "SlotDataBusWidth4X" : iirc multiline for smbios_slot_desc doesn't work, does it? https://review.coreboot.org/c/coreboot/+/37441/comment/9be5c6f4_639a916c PS67, Line 94: smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" : "M.2-P_2" "SlotDataBusWidth4X" : iirc multiline for smbios_slot_desc doesn't work, does it? -- To view, visit https://review.coreboot.org/c/coreboot/+/37441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ab1cb9462607b9af068bc2374508d99c60d0a30 Gerrit-Change-Number: 37441 Gerrit-PatchSet: 67 Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Guido Beyer @ Prodrive Technologies <guido.beyer(a)prodrive-technologies.com> Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stef van Os <stef.van.os(a)prodrive-technologies.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wouter.eckhardt(a)prodrive-technologies.com Gerrit-CC: Jonas Löffelholz Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 08 Apr 2021 21:33:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne: Add GRXS and GTXS method
by Felix Held (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Mathew King, Ivy Jian, EricR Lai. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52184 ) Change subject: soc/amd/cezanne: Add GRXS and GTXS method ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > that's what i was planning for this; i'll take over this one had a look and i'll probably do the moving to common code as a follow-up patch, since stoneyridge is sufficiently different and i'll have to find out if that one could also just use the same code as picasso and cezanne -- To view, visit https://review.coreboot.org/c/coreboot/+/52184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e3512562f92de230cf2e6967ec90527fb3d62ee Gerrit-Change-Number: 52184 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 21:16:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mathew King <mathewk(a)chromium.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Add lib/coreboot_table-test test case
by Paul Fagerburg (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Martin Roth, Jakub Czapiga, Julius Werner, Jan Dabros. Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52159 ) Change subject: tests: Add lib/coreboot_table-test test case ...................................................................... Patch Set 2: (1 comment) File tests/lib/coreboot_table-test.c: https://review.coreboot.org/c/coreboot/+/52159/comment/d85741f6_5e95e606 PS2, Line 329: test_write_tables This seems like a very large test. What are you testing here, that each LB_TAG type is written correctly? If so, it seems like it should be multiple smaller tests. Or if you're testing that write_tables works correctly, should the test be so flexible as to allow the records in any order, or should it check that write_table put the records in the same order that was specified? -- To view, visit https://review.coreboot.org/c/coreboot/+/52159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d7d9ca43316bf514bb5ebd8909f441bcfa20eba Gerrit-Change-Number: 52159 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 20:31:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel: reintroduce PAD_CFG_NC macro for unconnected pads w/o pull
by Tim Wawrzynczak (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Felix Singer, Nico Huber, Furquan Shaikh, Matt DeVillier, Michael Niewöhner, Tim Wawrzynczak, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52139 ) Change subject: soc/intel: reintroduce PAD_CFG_NC macro for unconnected pads w/o pull ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Change of heart re: CB:46567 ? 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/52139 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id01b197ebe8f2b8bb4ecf3d119ec2298b26d9be0 Gerrit-Change-Number: 52139 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 08 Apr 2021 20:27:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021