coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: soc/amd/{common,picasso}: Move generate_cpu_entries to common
by Felix Held (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52004 ) Change subject: soc/amd/{common,picasso}: Move generate_cpu_entries to common ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: i'd move that to a separate c file, add some kconfig option (SOC_AMD_COMMON_BLOCK_ACPI_CPU_ZEN maybe?) to include this and only select that option in picasso and cezanne -- To view, visit https://review.coreboot.org/c/coreboot/+/52004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If75bceae57ada82060416b43cdcc947603368a42 Gerrit-Change-Number: 52004 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Apr 2021 22:07:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: fix wrong calculation
by Angel Pons (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52144 ) Change subject: ec/lenovo/h8/acpi: fix wrong calculation ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52144/comment/1221b8c9_794a5379 PS3, Line 11: wrongly converted > Done :) I would say you need more coffee, but it's past midnight already. Then, you (and I as well) need more bed 😄 -- To view, visit https://review.coreboot.org/c/coreboot/+/52144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701 Gerrit-Change-Number: 52144 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 08 Apr 2021 22:05:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/mancomb: add DXIO and DDI descriptors
by Felix Held (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Raul Rangel, Martin Roth, Mathew King, EricR Lai. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52180 ) Change subject: mb/google/mancomb: add DXIO and DDI descriptors ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: i wonder if the missing pcie engine for lane 4 will result in running into the power management issue where the dummy descriptors were added as a workaround. maybe that's fixed when the prototype is ready, but it's probably something to keep in mind -- To view, visit https://review.coreboot.org/c/coreboot/+/52180 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica4e6511a5106a958567565b96d5888b8c829ff2 Gerrit-Change-Number: 52180 Gerrit-PatchSet: 2 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 22:03:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: fix wrong calculation
by Michael Niewöhner (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52144 ) Change subject: ec/lenovo/h8/acpi: fix wrong calculation ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52144/comment/8c27835a_3bb4f2ea PS3, Line 11: wrongly converted > wait. you're right. […] Done :) -- To view, visit https://review.coreboot.org/c/coreboot/+/52144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701 Gerrit-Change-Number: 52144 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 08 Apr 2021 22:03:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: fix wrong calculation
by Michael Niewöhner (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes. Hello build bot (Jenkins), Nico Huber, Angel Pons, Arthur Heymans, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52144 to look at the new patch set (#4). Change subject: ec/lenovo/h8/acpi: fix wrong calculation ...................................................................... ec/lenovo/h8/acpi: fix wrong calculation The conversion to ASL 2.0 syntax in commit 81d55cf introduced a regression triggering a BUG in Linux when reading the battery current. Correct the wrongly-converted calculation. Fixes: 81d55cf ("src/ec/lenovo/h8/acpi/battery.asl: Convert to ASL 2.0") Tested-by: Andrew A. I. <aidron(a)yandex.ru> Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/ec/lenovo/h8/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/52144/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/52144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701 Gerrit-Change-Number: 52144 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: fix wrong calculation
by Michael Niewöhner (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52144 ) Change subject: ec/lenovo/h8/acpi: fix wrong calculation ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52144/comment/d83ef3e5_8507d3b8 PS3, Line 11: wrongly converted > both is correct, so I leave it as-is :) wait. you're right. I should have actually read what I wrote \o/ -- To view, visit https://review.coreboot.org/c/coreboot/+/52144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701 Gerrit-Change-Number: 52144 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 08 Apr 2021 22:02:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: revert renaming of CONFIG_MAX_PCIE_CLOCKS
by Rizwan Qureshi (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52194 ) Change subject: soc/intel/alderlake: revert renaming of CONFIG_MAX_PCIE_CLOCKS ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/common/block/pcie/rtd3/rtd3.c: https://review.coreboot.org/c/coreboot/+/52194/comment/4e868ba6_00c007b1 PS1, Line 203: CONFIG_MAX_PCIE_CLOCK_REQ > Couple of things: […] ugh...oversight...fixed -- To view, visit https://review.coreboot.org/c/coreboot/+/52194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I747c94331b68c4ec0b6b5a04149856a4bb384829 Gerrit-Change-Number: 52194 Gerrit-PatchSet: 3 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 08 Apr 2021 22:02:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/shadowmountain: Enable RTD3 for SD card
by Rizwan Qureshi (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Rizwan Qureshi. Hello build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52134 to look at the new patch set (#6). Change subject: mb/intel/shadowmountain: Enable RTD3 for SD card ...................................................................... mb/intel/shadowmountain: Enable RTD3 for SD card Enable the PCIe RTD3 driver for the PCIe attached SD card interface and specify the srcclk pin and reset GPIO. TEST=Tested on shadowmountain platform to ensure the system can enter the S0i3.2 substate and suspend/resume is stable Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Change-Id: Ibeb99bea48d72b019cb2adcf38926c3ed39f7b84 --- M src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/52134/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/52134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeb99bea48d72b019cb2adcf38926c3ed39f7b84 Gerrit-Change-Number: 52134 Gerrit-PatchSet: 6 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake: Enable PCIE RTD3 driver
by Rizwan Qureshi (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52195 to look at the new patch set (#3). Change subject: soc/intel/alderlake: Enable PCIE RTD3 driver ...................................................................... soc/intel/alderlake: Enable PCIE RTD3 driver Include the PCIE RTD3 driveri for Alder Lake SoC. Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Change-Id: I4732e4663feff503b249b76aaf70ec142a888963 --- M src/soc/intel/alderlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/52195/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4732e4663feff503b249b76aaf70ec142a888963 Gerrit-Change-Number: 52195 Gerrit-PatchSet: 3 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake: revert renaming of CONFIG_MAX_PCIE_CLOCKS
by Rizwan Qureshi (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52194 to look at the new patch set (#3). Change subject: soc/intel/alderlake: revert renaming of CONFIG_MAX_PCIE_CLOCKS ...................................................................... soc/intel/alderlake: revert renaming of CONFIG_MAX_PCIE_CLOCKS CONFIG_MAX_PCIE_CLOCKS was renamed to MAX_PCIE_CLOCK_SRC in alderlake. However, this config is being used in common/block/pcie/rtd3 to validate clksrc range. Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Change-Id: I747c94331b68c4ec0b6b5a04149856a4bb384829 --- M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/romstage/fsp_params.c 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/52194/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I747c94331b68c4ec0b6b5a04149856a4bb384829 Gerrit-Change-Number: 52194 Gerrit-PatchSet: 3 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021