Attention is currently required from: Felix Singer, Raul Rangel, Nico Huber, Furquan Shaikh, Matt DeVillier, Patrick Rudolph, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 )
Change subject: [RFC] soc/intel/skylake: Introduce new method for setting device states
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/skylake/fspdevmap.h:
https://review.coreboot.org/c/coreboot/+/52493/comment/a0794383_856522a0
PS9, Line 9: const uint8_t inverted;
> Actually, I have thought about this but decided against doing it, because IMO it would make the list […]
When I write tables in C, I generally format them so that all columns are aligned, including the closing braces. I'd only omit the inverted field if all entries are non-inverted.
TL;DR: I don't care.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52493
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70fde306c65a8881f565c5f923be20f380ea64d3
Gerrit-Change-Number: 52493
Gerrit-PatchSet: 9
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 30 Apr 2021 08:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Timofey Komarov, Nico Huber, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Allow to use Amber Lake FSP
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52692/comment/2c0831b3_83f16531
PS5, Line 7: to use
> using
AFAIK, "allow to use" is correct. Google says it's much more popular, too:
"allow to use" -> About 84,900,000 results
"allow using" -> About 1,150,000 results
"allows to use" -> About 55,900,000 results
"allows using" -> About 2,240,000 results
--
To view, visit https://review.coreboot.org/c/coreboot/+/52692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c
Gerrit-Change-Number: 52692
Gerrit-PatchSet: 5
Gerrit-Owner: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 30 Apr 2021 08:05:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Xi Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48869 )
Change subject: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob
......................................................................
TEST-ONLY: src/mediatek/mt8192: force full calibration for blob
Signed-off-by: Xi Chen <xixi.chen(a)mediatek.com>
Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19
---
M src/soc/mediatek/mt8192/memory.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/48869/1
diff --git a/src/soc/mediatek/mt8192/memory.c b/src/soc/mediatek/mt8192/memory.c
index 07c4b9f..ad84ad7 100644
--- a/src/soc/mediatek/mt8192/memory.c
+++ b/src/soc/mediatek/mt8192/memory.c
@@ -10,6 +10,8 @@
#include <symbols.h>
#include <timer.h>
+#define FORCE_FULL_K
+
static int mt_mem_test(const struct dramc_data *dparam)
{
if (CONFIG(MEMORY_TEST)) {
@@ -148,7 +150,11 @@
/* Load calibration params from flash and run fast calibration */
mem_init_set_default_config(dparam, dram_info);
+#ifdef FORCE_FULL_K
+ if (0) {
+#else
if (dparam_ops->read_from_flash(dparam)) {
+#endif
printk(BIOS_INFO, "DRAM-K: Running fast calibration\n");
stopwatch_init(&sw);
--
To view, visit https://review.coreboot.org/c/coreboot/+/48869
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19
Gerrit-Change-Number: 48869
Gerrit-PatchSet: 1
Gerrit-Owner: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Michael Niewöhner.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52627 )
Change subject: soc/intel/skylake: Clean up root port structs
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
There's no benefit here. The compiler will optimise the always true/false conditional and remove dead code and data.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52627
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d5155356bd302ef938c76eb60688276fec67502
Gerrit-Change-Number: 52627
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Fri, 30 Apr 2021 06:54:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment