Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52785 )
Change subject: drivers/intel/fsp1_1: Remove verstage compilation units
......................................................................
drivers/intel/fsp1_1: Remove verstage compilation units
Only SOC_INTEL_BRASWELL is using FSP1.1. It has too little CAR
available set up by FSP-T to have VBOOT_STARTS_IN_BOOTBLOCK and
therefore verstage is not possible either.
Change-Id: I54361c835055907c2a4414ec26a1495425d4ef09
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/drivers/intel/fsp1_1/Makefile.inc
D src/drivers/intel/fsp1_1/verstage.c
2 files changed, 0 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/52785/1
diff --git a/src/drivers/intel/fsp1_1/Makefile.inc b/src/drivers/intel/fsp1_1/Makefile.inc
index 4b8e0a8..c890f35 100644
--- a/src/drivers/intel/fsp1_1/Makefile.inc
+++ b/src/drivers/intel/fsp1_1/Makefile.inc
@@ -2,10 +2,6 @@
ifeq ($(CONFIG_PLATFORM_USES_FSP1_1),y)
-verstage-y += car.c
-verstage-y += fsp_util.c
-verstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += verstage.c
-
bootblock-$(CONFIG_USE_GENERIC_FSP_CAR_INC) += cache_as_ram.S
bootblock-y += fsp_util.c
bootblock-y += ../../../cpu/intel/microcode/microcode_asm.S
diff --git a/src/drivers/intel/fsp1_1/verstage.c b/src/drivers/intel/fsp1_1/verstage.c
deleted file mode 100644
index c001b62..0000000
--- a/src/drivers/intel/fsp1_1/verstage.c
+++ /dev/null
@@ -1,11 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <fsp/car.h>
-#include <program_loading.h>
-
-void *cache_as_ram_stage_main(FSP_INFO_HEADER *fih)
-{
- run_romstage();
- /* Will actually never return. */
- return NULL;
-}
--
To view, visit https://review.coreboot.org/c/coreboot/+/52785
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54361c835055907c2a4414ec26a1495425d4ef09
Gerrit-Change-Number: 52785
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52578 )
Change subject: Makefile,tests: Move cmocka checkout into top level Makefile
......................................................................
Makefile,tests: Move cmocka checkout into top level Makefile
cmocka is currently ignoring the UPDATED_SUBMODULES flag. Move the
cmocka checkout with the other submodule checkouts.
BUG=none
TEST=Make sure cmocka is not checked out if UPDATED_SUBMODULES=1
Signed-off-by: Raul E Rangel <rrangel(a)chromium.org>
Change-Id: I2a1db809368a77d2c0f9c9a796d62555ec476dc7
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52578
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Jakub Czapiga <jacz(a)semihalf.com>
---
M Makefile.inc
M tests/Makefile.inc
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
build bot (Jenkins): Verified
Jakub Czapiga: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc
index a372efa..ce70a30 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -193,6 +193,8 @@
ifneq ($(UPDATED_SUBMODULES),1)
# try to fetch non-optional submodules if the source is under git
forgetthis:=$(if $(GIT),$(shell git submodule update --init))
+# Checkout Cmocka repository
+forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/cmocka))
ifeq ($(CONFIG_USE_BLOBS),y)
# These items are necessary because each has update=none in .gitmodules. They are ignored
# until expressly requested and enabled with --checkout
diff --git a/tests/Makefile.inc b/tests/Makefile.inc
index 48bd18b..fd3cd9f 100644
--- a/tests/Makefile.inc
+++ b/tests/Makefile.inc
@@ -41,9 +41,6 @@
TEST_CFLAGS += -D__TEST__
-# Checkout Cmocka repository
-forgetthis:=$(shell git submodule update --init --checkout 3rdparty/cmocka)
-
TEST_CFLAGS += -I$(cmockasrc)/include
# Link against Cmocka
--
To view, visit https://review.coreboot.org/c/coreboot/+/52578
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a1db809368a77d2c0f9c9a796d62555ec476dc7
Gerrit-Change-Number: 52578
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Nico Huber, Martin Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51673 )
Change subject: [POC]lint: Add alphabetical sorting check
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/51673
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia60743fadbd7e5c044726eb566bcf976098c4162
Gerrit-Change-Number: 51673
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Fri, 30 Apr 2021 12:43:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52642 )
Change subject: cpu/x86/mtrr: Prefer keeping WRCOMB requests to reserving MTRRs for OS
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
The change seems harmless but it leaves config RESERVE_MTRRS_FOR_OS
somewhat dangling. I did not follow the discussion on the parent
change. What is the relation? Doesn't this destroy what the other
change achieved, i.e. to give Kconfig control over this?
--
To view, visit https://review.coreboot.org/c/coreboot/+/52642
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I108c743d25baaeae1860732601cc7abda2f05932
Gerrit-Change-Number: 52642
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Apr 2021 11:58:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52775 )
Change subject: soc/intel/cannonlake/include: Drop unused code
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52775
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21689d1eae6952a80c98096443e7506a1466c07e
Gerrit-Change-Number: 52775
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 30 Apr 2021 11:42:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52776 )
Change subject: soc/intel/cannonlake: Rename `SOC_INTEL_COMETLAKE`
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I would prefer not to. For coreboot, it's always just "Comet Lake"
the distinction is only done for FSP and shouldn't affect our code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52776
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I993f96f032c3b76a464474c83fee4442968be152
Gerrit-Change-Number: 52776
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 30 Apr 2021 11:41:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment