coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7266 discussions

Change in coreboot[master]: configs/config.google_volteer.build_test_purposes: Add file
by Francois Toguo Fotso (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Angel Pons. Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51155 ) Change subject: configs/config.google_volteer.build_test_purposes: Add file ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Doesn't look like this build failure is related to CrashLog -- To view, visit https://review.coreboot.org/c/coreboot/+/51155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9bbfa538e38a4d835c1f8b0d45feb2f0fe803f8 Gerrit-Change-Number: 51155 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Mar 2021 17:29:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/majolica: Enable required devices in devicetree
by Felix Held (Code Review) 02 Mar '21

02 Mar '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51095 ) Change subject: mb/amd/majolica: Enable required devices in devicetree ...................................................................... mb/amd/majolica: Enable required devices in devicetree Most devices are now disabled by default in the chipset. Enable the iGPU and two XHCI controllers that are required to boot the board. BUG=b:180528708 TEST=To be tested Signed-off-by: Mathew King <mathewk(a)chromium.org> Change-Id: I54a4547217fb8e9f67fc0c8e1e36e96dfaae331c Reviewed-on: https://review.coreboot.org/c/coreboot/+/51095 Reviewed-by: Raul Rangel <rrangel(a)chromium.org> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/amd/majolica/devicetree.cb 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Raul Rangel: Looks good to me, approved diff --git a/src/mainboard/amd/majolica/devicetree.cb b/src/mainboard/amd/majolica/devicetree.cb index a141552..2695f60 100644 --- a/src/mainboard/amd/majolica/devicetree.cb +++ b/src/mainboard/amd/majolica/devicetree.cb @@ -3,6 +3,11 @@ chip soc/amd/cezanne device domain 0 on + device ref gpp_bridge_a on # Internal GPP Bridge 0 to Bus A + device ref gfx on end # Internal GPU (GFX) + device ref xhci_0 on end # USB 3.1 (USB0) + device ref xhci_1 on end # USB 3.1 (USB1) + end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/51095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54a4547217fb8e9f67fc0c8e1e36e96dfaae331c Gerrit-Change-Number: 51095 Gerrit-PatchSet: 4 Gerrit-Owner: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/guybrush: Enable Chrome EC
by Martin Roth (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Mathew King. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51043 ) Change subject: mb/google/guybrush: Enable Chrome EC ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: It looks like you need to add at least 'select EC_GOOGLE_CHROMEEC' into Kconfig. File src/mainboard/google/guybrush/ec.c: https://review.coreboot.org/c/coreboot/+/51043/comment/1c590672_1927b699 PS2, Line 18: google_chromeec_events_init(&info, acpi_is_wakeup_s3()); i386-elf-ld.bfd: /cb-build/coreboot-gerrit.0/default/GOOGLE_GUYBRUSH/generated/ramstage.o: in function `mainboard_ec_init': /home/coreboot/node-root/workspace/coreboot-gerrit/src/mainboard/google/guybrush/ec.c:18: undefined reference to `google_chromeec_events_init' -- To view, visit https://review.coreboot.org/c/coreboot/+/51043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3cdd6422b1bc53ea934346327359cbc6d86baeeb Gerrit-Change-Number: 51043 Gerrit-PatchSet: 2 Gerrit-Owner: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Mar 2021 17:24:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/majolica: Enable required devices in devicetree
by Raul Rangel (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Mathew King, Paul Menzel, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51095 ) Change subject: mb/amd/majolica: Enable required devices in devicetree ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54a4547217fb8e9f67fc0c8e1e36e96dfaae331c Gerrit-Change-Number: 51095 Gerrit-PatchSet: 3 Gerrit-Owner: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 Mar 2021 17:22:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/majolica: Enable required devices in devicetree
by Felix Held (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Mathew King, Paul Menzel. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51095 ) Change subject: mb/amd/majolica: Enable required devices in devicetree ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51095/comment/f3cc56be_923edd73 PS2, Line 10: devices that are requred to boot the board. > It’d be great to list the three devices here, so it can be compared with the actual change. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54a4547217fb8e9f67fc0c8e1e36e96dfaae331c Gerrit-Change-Number: 51095 Gerrit-PatchSet: 3 Gerrit-Owner: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 02 Mar 2021 17:20:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/majolica: Enable required devices in devicetree
by Felix Held (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Mathew King, Felix Held. Felix Held has uploaded a new patch set (#3) to the change originally created by Mathew King. ( https://review.coreboot.org/c/coreboot/+/51095 ) Change subject: mb/amd/majolica: Enable required devices in devicetree ...................................................................... mb/amd/majolica: Enable required devices in devicetree Most devices are now disabled by default in the chipset. Enable the iGPU and two XHCI controllers that are required to boot the board. BUG=b:180528708 TEST=To be tested Signed-off-by: Mathew King <mathewk(a)chromium.org> Change-Id: I54a4547217fb8e9f67fc0c8e1e36e96dfaae331c --- M src/mainboard/amd/majolica/devicetree.cb 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/51095/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/51095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54a4547217fb8e9f67fc0c8e1e36e96dfaae331c Gerrit-Change-Number: 51095 Gerrit-PatchSet: 3 Gerrit-Owner: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Add DRAM support for Micron MT53E1G32D2NP-046 and MT5...
by Tim Wawrzynczak (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Furquan Shaikh, Martin Roth, Amanda Hwang, Ivy Jian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51170 ) Change subject: mb/google/brya: Add DRAM support for Micron MT53E1G32D2NP-046 and MT53E2G32D4NQ-046 ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51170/comment/0e89e77c_fecb475a PS1, Line 7: mb/google/brya: Add DRAM support for Micron MT53E1G32D2NP-046 and MT53E2G32D4NQ-046 suggestion: ``` mb/google/brya: Add support for 2 new DRAM parts 1) Micron MT53E1G32D2NP-046 2) Micron MT53E2G32D4NQ-046 ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/51170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I413e35cdb7c34388c3e159f8f9584fae2d21a355 Gerrit-Change-Number: 51170 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 02 Mar 2021 17:18:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Set CNVi Bluetooth pin muxes
by Tim Wawrzynczak (Code Review) 02 Mar '21

02 Mar '21

Tim Wawrzynczak has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/51111 ) Change subject: mb/google/brya: Set CNVi Bluetooth pin muxes ...................................................................... Abandoned GpioOverride UPD makes this unnecessary -- To view, visit https://review.coreboot.org/c/coreboot/+/51111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I067ebbfb28fff52f93982493f5d54147a61591a3 Gerrit-Change-Number: 51111 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/guybrush: Set up FW_CONFIG fields
by Martin Roth (Code Review) 02 Mar '21

02 Mar '21

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50882 ) Change subject: mb/google/guybrush: Set up FW_CONFIG fields ...................................................................... mb/google/guybrush: Set up FW_CONFIG fields BUG=b:180523962 TEST=builds Signed-off-by: Mathew King <mathewk(a)chromium.org> Change-Id: Ic8f30f6d7c4781d4e8451546b39395a74393608f Reviewed-on: https://review.coreboot.org/c/coreboot/+/50882 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/guybrush/variants/guybrush/overridetree.cb 2 files changed, 33 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index 4884cf18d1..050cfc7 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -9,6 +9,7 @@ def_bool y select AMD_SOC_CONSOLE_UART select BOARD_ROMSIZE_KB_16384 + select FW_CONFIG select MAINBOARD_HAS_CHROMEOS select SOC_AMD_CEZANNE select SOC_AMD_COMMON_BLOCK_USE_ESPI diff --git a/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb b/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb index 519bd07..80c04ee 100644 --- a/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb @@ -1,4 +1,36 @@ # SPDX-License-Identifier: GPL-2.0-or-later +fw_config + field USB_DB 0 1 + option USB_DB_A1_PS8811_C1_PS8818 0 + option USB_DB_A1_ANX7491_C1_ANX7451 1 + end + field FORM_FACTOR 2 + option FORM_FACTOR_CLAMSHELL 0 + option FORM_FACTOR_CONVERTIBLE 1 + end + field KB_BL 3 + option KB_BL_ABSENT 0 + option KB_BL_PRESENT 1 + end + field FP 4 + option FP_ABSENT 0 + option FP_PRESENT 1 + end + field WLAN 5 6 + option WLAN_WCN6856 0 + option WLAN_RTL8852 1 + end + field WWAN 7 8 + option WWAN_DIASABLED 0 + option WWAN_L850GL 1 + option WWAN_FM350GL 2 + end + field BEEP_MODE 9 + option BEEP_MODE_AMP 0 + option BEEP_MODE_BIT_BANG 1 + end +end + chip soc/amd/cezanne device domain 0 on end # domain -- To view, visit https://review.coreboot.org/c/coreboot/+/50882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8f30f6d7c4781d4e8451546b39395a74393608f Gerrit-Change-Number: 50882 Gerrit-PatchSet: 8 Gerrit-Owner: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/guybrush: Set up FW_CONFIG fields
by Martin Roth (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Mathew King, Tim Wawrzynczak, Paul Menzel, Rob Barnes, Karthik Ramasubramanian. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50882 ) Change subject: mb/google/guybrush: Set up FW_CONFIG fields ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Patchset: PS5: > Tim do we need an empty fw_config in devicetree? In discussing this with Tim, neither of us feel that we should need the empty fw_config. -- To view, visit https://review.coreboot.org/c/coreboot/+/50882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8f30f6d7c4781d4e8451546b39395a74393608f Gerrit-Change-Number: 50882 Gerrit-PatchSet: 7 Gerrit-Owner: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 02 Mar 2021 17:11:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Mathew King <mathewk(a)chromium.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021