coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7265 discussions

Change in coreboot[master]: mb/google/brya: Fix a few mistakes in brya0 overridetree
by EricR Lai (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Tim Wawrzynczak. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 ) Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/brya0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/51145/comment/b2e72a78_eeb63443 PS2, Line 72: sx9324 > This driver isn't even in our 5. […] I agree, but I checked with our kernel guy. No idea how to determine it value unless vendor help upstream this. -- To view, visit https://review.coreboot.org/c/coreboot/+/51145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc Gerrit-Change-Number: 51145 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Mar 2021 16:33:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/acpi: Add APEI EINJ support
by Rocky Phagura (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Marc Jones, Furquan Shaikh, Duncan Laurie, Angel Pons. Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Jonathan Zhang, Duncan Laurie, Paul Menzel, Rocky Phagura, Subrata Banik, Angel Pons, Patrick Rudolph, Lance Zhao, Marc Jones, Martin Roth, Marshall Dawson, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49286 to look at the new patch set (#5). Change subject: src/acpi: Add APEI EINJ support ...................................................................... src/acpi: Add APEI EINJ support This adds full EINJ support with trigger action tables. The actual error injection functionality is HW specific. Therefore, HW specific code should call acpi_create_einj with an address where action table resides. The default params of the action table are filled out by the common code. Control is then returned back to the caller to modify or override default parameters. If no changes are needed, caller can simply add the acpi table. At runtime, FW is responsible for filling out the action table with the proper entries. The action table memory is shared between FW and OS. This memory should be marked as reserved in E820 table. Tested on Deltalake mainboard. Boot to OS, load the EINJ driver ( modprobe EINJ) and verify EINJ memory entries are in /proc/iomem. Further tested by injecting errors via the APEI file nodes. More information on error injection is here. https://www.kernel.org/doc/Documentation/acpi/apei/einj.txt Change-Id: I29c6a861c564ec104f2c097f3e49b3e6d38b040e Signed-off-by: Rocky Phagura <rphagura(a)fb.com> --- M src/acpi/Kconfig M src/acpi/acpi.c M src/include/acpi/acpi.h 3 files changed, 290 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/49286/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/49286 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29c6a861c564ec104f2c097f3e49b3e6d38b040e Gerrit-Change-Number: 49286 Gerrit-PatchSet: 5 Gerrit-Owner: Rocky Phagura Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/acpi: Add APEI EINJ support
by Rocky Phagura (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Marc Jones, Furquan Shaikh, Duncan Laurie, Angel Pons. Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49286 ) Change subject: src/acpi: Add APEI EINJ support ...................................................................... Patch Set 4: (21 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/49286/comment/2baa6e4f_27ab5fbe PS4, Line 9: This adds full EINJ support with trigger action tables. The actual error injection functionality is HW specific. Therefore, HW specific code should call acpi_create_einj with an address where action table resides. The default params of the action table are filled out by the common code. Control is then returned back to the caller to modify or override default parameters. If no changes are needed, caller can simply add the acpi table. At runtime, FW is responsible for filling out the action table with the proper entries. The action table memory is shared between FW and OS. This memory should be marked as reserved in E820 table. > Please break commit message lines at 72 characters Done File src/acpi/Kconfig: https://review.coreboot.org/c/coreboot/+/49286/comment/8d0d7315_237cbf7a PS4, Line 42: This variable provides control for ACPI error injection table (EINJ) > This does absolutely nothing. it was added for completeness. For anyone that will add the SOC specific code can use this instead of creating some new config option. It's used currently by me for the code that is not "upstreamable" yet. Since it doesn't hurt anything and it will be used later, we can leave it here for now. File src/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/49286/comment/f85573f8_9fdffe41 PS4, Line 925: > Seems unrelated? Done https://review.coreboot.org/c/coreboot/+/49286/comment/3c6662eb_22126023 PS4, Line 778: u64 > Why not use `uintptr_t` instead? Done https://review.coreboot.org/c/coreboot/+/49286/comment/cb134426_0b5c30ba PS4, Line 785: intptr_t > *u*intptr_t ? […] Done https://review.coreboot.org/c/coreboot/+/49286/comment/804eb1d2_72c8c2b8 PS4, Line 787: sizeof(acpi_einj_smi_t) > sizeof(*einj_smi) Done https://review.coreboot.org/c/coreboot/+/49286/comment/4247a0eb_0b69397b PS4, Line 787: (void *) > Are all these (void *) casts really necessary? Done https://review.coreboot.org/c/coreboot/+/49286/comment/6d4f24cf_cc92990d PS4, Line 796: actions > The way the struct type is defined, `actions` can only be less than 1. That's correct, but this piece of the table belongs to the caller defined memory and this code initializes to the defaults. The caller has the option to override these settings once control is returned. https://review.coreboot.org/c/coreboot/+/49286/comment/05dd06cb_417d2e6c PS4, Line 809: [] > [ACTION_COUNT] Done https://review.coreboot.org/c/coreboot/+/49286/comment/94b91177_a22dc734 PS4, Line 810: /* Action 0 */ > Instead of having these comments, you could initialise the array indices explicitly: […] Done https://review.coreboot.org/c/coreboot/+/49286/comment/89a1d07d_53fbaeb0 PS4, Line 825: 0x0 > Why not simply 0? Done https://review.coreboot.org/c/coreboot/+/49286/comment/44b56cf4_2bb34218 PS4, Line 894: > Casts are unary operators and do not use spaces Done https://review.coreboot.org/c/coreboot/+/49286/comment/5682faf1_71afe093 PS4, Line 902: default_actions[8].reg.addr = (u64) (uintptr_t)&einj_smi->setaddrtable; > Why not add the addresses in the initializer? Done https://review.coreboot.org/c/coreboot/+/49286/comment/d2e409b7_b09557b3 PS4, Line 906: (unsigned int long) > Uh, drop the cast and use %p instead? Done https://review.coreboot.org/c/coreboot/+/49286/comment/3c0c9d8d_9d944602 PS4, Line 908: acpi_einj_t > *einj Done https://review.coreboot.org/c/coreboot/+/49286/comment/288a74d5_bbc4638f PS4, Line 910: return; > Maybe exit early? Done https://review.coreboot.org/c/coreboot/+/49286/comment/fa23bd92_4c8140e9 PS4, Line 925: unsigned int long > Uh, drop the cast and use %p instead? Done https://review.coreboot.org/c/coreboot/+/49286/comment/86916a2d_1b81ec0d PS4, Line 927: sizeof(acpi_einj_action_table_t) * ACTION_COUNT > `sizeof(einj->action_table)` or `sizeof(default_actions)` please Done https://review.coreboot.org/c/coreboot/+/49286/comment/dac4dc0e_5ef5da38 PS4, Line 928: acpi_einj_t > *einj Done File src/include/acpi/acpi.h: https://review.coreboot.org/c/coreboot/+/49286/comment/15a910ad_3bd79c4a PS4, Line 963: + > Um, these are bitmasks. […] Done https://review.coreboot.org/c/coreboot/+/49286/comment/e59e6c9e_8e9fe410 PS4, Line 1055: 0 > Pass the address through a macro parameter? that is an option but at this point I will leave it as is to reduce complexity and increase clarity. -- To view, visit https://review.coreboot.org/c/coreboot/+/49286 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29c6a861c564ec104f2c097f3e49b3e6d38b040e Gerrit-Change-Number: 49286 Gerrit-PatchSet: 4 Gerrit-Owner: Rocky Phagura Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Mar 2021 16:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/tpm/tss/vendor/cr50: Introduce vendor sub-command to reset EC
by Vadim Bendebury (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Mary Ruthven, Joel Kitching, Furquan Shaikh, Vadim Bendebury, Christian Walter, Julius Werner, Karthik Ramasubramanian. Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51164 ) Change subject: security/tpm/tss/vendor/cr50: Introduce vendor sub-command to reset EC ...................................................................... Patch Set 2: (1 comment) File src/security/tpm/tss/vendor/cr50/cr50.h: https://review.coreboot.org/c/coreboot/+/51164/comment/136745e3_437fc71a PS1, Line 104: Issue a halt() after triggering EC reset because cr50 leaves 50 ms after receiving : * the command to reset the EC. > I don't have a strong opinion. […] I agree that it does not make sense to return in case of success. -- To view, visit https://review.coreboot.org/c/coreboot/+/51164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46063678511d27fea5eabbd12fc3af0b1df68143 Gerrit-Change-Number: 51164 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Mary Ruthven <mruthven(a)google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Attention: Mary Ruthven <mruthven(a)google.com> Gerrit-Attention: Joel Kitching <kitching(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 02 Mar 2021 16:10:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Fix a few mistakes in brya0 overridetree
by Tim Wawrzynczak (Code Review) 02 Mar '21

02 Mar '21

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 ) Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/brya0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/51145/comment/4c5def92_1fcb7ddf PS2, Line 72: sx9324 > Not sure vendor have this plan or not. […] This driver isn't even in our 5.10 tree right now 😊 Hopefully we can make similar changes to the sx9324 driver that were made to sx9310, that interface was so much cleaner! -- To view, visit https://review.coreboot.org/c/coreboot/+/51145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc Gerrit-Change-Number: 51145 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Mar 2021 15:57:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/majolica: Add eSPI support
by Raul Rangel (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Zheng Bao, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49966 ) Change subject: mb/amd/majolica: Add eSPI support ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e82a51173f561df560c36528a9b7ec26cf489b5 Gerrit-Change-Number: 49966 Gerrit-PatchSet: 9 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 Mar 2021 15:55:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm_loaderv2: Use the permanent stack top during relocation
by build bot (Jenkins) (Code Review) 02 Mar '21

02 Mar '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51186 ) Change subject: cpu/x86/smm_loaderv2: Use the permanent stack top during relocation ...................................................................... Patch Set 2: (1 comment) File src/cpu/x86/mp_init.c: https://review.coreboot.org/c/coreboot/+/51186/comment/3d49c021_835fc4af PS2, Line 787: if (smm_setup_relocation_handler((void*)perm_smbase, &smm_params)) { "(foo*)" should be "(foo *)" -- To view, visit https://review.coreboot.org/c/coreboot/+/51186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a0a890e8b1c2408301564c22772032cfee4d296 Gerrit-Change-Number: 51186 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Mar 2021 15:55:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/blipper: Enable touchpad support
by zanxi chen (Code Review) 02 Mar '21

02 Mar '21

zanxi chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/51188 ) Change subject: mb/google/dedede/var/blipper: Enable touchpad support ...................................................................... mb/google/dedede/var/blipper: Enable touchpad support Add touchpad into devicetree for blipper. BUG=b:172787208 BRANCH=dedede TEST=built blipper firmware and verified touchpad function Change-Id: I2c9b61ba9d282f994e2f756bafe4af1091d4d617 Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/blipper/overridetree.cb 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/51188/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51188 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c9b61ba9d282f994e2f756bafe4af1091d4d617 Gerrit-Change-Number: 51188 Gerrit-PatchSet: 2 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/blipper: Enable touchpad support
by zanxi chen (Code Review) 02 Mar '21

02 Mar '21

zanxi chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51188 ) Change subject: mb/google/dedede/var/blipper: Enable touchpad support ...................................................................... mb/google/dedede/var/blipper: Enable touchpad support Add touchpad into devicetree for blipper. BUG=b:172787208 BRANCH=dedede TEST=built storo firmware and verified touchpad function Change-Id: I2c9b61ba9d282f994e2f756bafe4af1091d4d617 Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/blipper/overridetree.cb 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/51188/1 diff --git a/src/mainboard/google/dedede/variants/blipper/overridetree.cb b/src/mainboard/google/dedede/variants/blipper/overridetree.cb index 404024b..82f15c6 100644 --- a/src/mainboard/google/dedede/variants/blipper/overridetree.cb +++ b/src/mainboard/google/dedede/variants/blipper/overridetree.cb @@ -37,6 +37,24 @@ }" device domain 0 on - device pci 15.0 on end + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "wake" = "GPE0_DW0_03" + register "probed" = "1" + device i2c 15 on end + end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_B3_IRQ)" + register "generic.wake" = "GPE0_DW0_03" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end + end # I2C 0 end end -- To view, visit https://review.coreboot.org/c/coreboot/+/51188 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c9b61ba9d282f994e2f756bafe4af1091d4d617 Gerrit-Change-Number: 51188 Gerrit-PatchSet: 1 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/generic/max98357a: Use depends HAVE_ACPI_TABLES
by Tim Wawrzynczak (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51166 ) Change subject: drivers/generic/max98357a: Use depends HAVE_ACPI_TABLES ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie6ebfde49f0f3c205e174c5113feb75444dedba8 Gerrit-Change-Number: 51166 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 02 Mar 2021 15:36:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021