Attention is currently required from: Martin Roth, zanxi chen.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Tao Xia,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51018
to look at the new patch set (#4).
Change subject: mb/google/dedede/var/storo: Add USB Port Configuration
......................................................................
mb/google/dedede/var/storo: Add USB Port Configuration
Add USB Port into devicetree for storo
BUG=b:177389444
BRANCH=dedede
TEST=build firmware and verified USB3.0 function is OK
Change-Id: I7c070206ba0ec789710e5200a37d3f6d662ef9de
Signed-off-by: chenzanxi <chenzanxi(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/storo/Makefile.inc
M src/mainboard/google/dedede/variants/storo/overridetree.cb
2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/51018/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/51018
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c070206ba0ec789710e5200a37d3f6d662ef9de
Gerrit-Change-Number: 51018
Gerrit-PatchSet: 4
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Andy Shevchenko, Paul Menzel, Werner Zeh.
Johannes Hahn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51176 )
Change subject: src/drivers/i2c/rx6110sa: Add official ACPI ID
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
Cherry-Picked the patch and double checked it successfully against the pending Linux Kernel driver patch. Will update when patch is committed officially.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51176
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45838162f014a760520692c6dcaae329ad98547d
Gerrit-Change-Number: 51176
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Andy Shevchenko <andy.shevchenko(a)gmail.com>
Gerrit-Reviewer: Johannes Hahn <johannes-hahn(a)siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Andy Shevchenko <andy.shevchenko(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 14:36:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Mariusz Szafrański, Michal Motyl.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51180 )
Change subject: util/sconfig: Fix for multidomain support sconfig/devicetree.cb
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/51180/comment/2d220daa_f0a823fa
PS1, Line 1222: DEVTREE_CONST
Keep `const` here. See CB:49242 for the reasoning
https://review.coreboot.org/c/coreboot/+/51180/comment/097f3249_848a8e24
PS1, Line 1224: DEVTREE_CONST
Keep `const` here too
--
To view, visit https://review.coreboot.org/c/coreboot/+/51180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd639d0cb3ed1a49ed7c7b1c77ac747ba6f77672
Gerrit-Change-Number: 51180
Gerrit-PatchSet: 1
Gerrit-Owner: Mariusz Szafrański <mariuszx.szafranski(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com>
Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 14:35:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Mariusz Szafrański, Angel Pons, Michal Motyl.
Suresh Bellampalli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51180 )
Change subject: util/sconfig: Fix for multidomain support sconfig/devicetree.cb
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/51180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd639d0cb3ed1a49ed7c7b1c77ac747ba6f77672
Gerrit-Change-Number: 51180
Gerrit-PatchSet: 1
Gerrit-Owner: Mariusz Szafrański <mariuszx.szafranski(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 14:34:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Aamir Bohra.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51178 )
Change subject: mb/google/brya: fix BT enumeration issue
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Disable pin should be used for RF-kill? So maybe just remove this? Not sure the design..
--
To view, visit https://review.coreboot.org/c/coreboot/+/51178
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I589fc2b55ee2947cc638fe17540bbd24f5bfb8f4
Gerrit-Change-Number: 51178
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 14:34:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, EricR Lai.
Hello build bot (Jenkins), Tim Wawrzynczak, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51178
to look at the new patch set (#2).
Change subject: mb/google/brya: fix BT enumeration issue
......................................................................
mb/google/brya: fix BT enumeration issue
Current implementation exposes GPP_F4 cnvi reset pin as reset
gpio instead of GPP_D4(BT_DISABLE_L). GPP_F4 is native and driven
by SoC. It should not be driven by driver.
BUG=b:180875586
Change-Id: I589fc2b55ee2947cc638fe17540bbd24f5bfb8f4
Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com>
---
M src/mainboard/google/brya/variants/brya0/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/51178/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51178
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I589fc2b55ee2947cc638fe17540bbd24f5bfb8f4
Gerrit-Change-Number: 51178
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Marc Jones, Patrick Rudolph, Jonathan Zhang, Johnny Lin, Rocky Phagura, Jingle Hsu, Angel Pons, Morgan Jang.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49460 )
Change subject: cpu/x86/smm: Add log_level that can be overridden for SMM log level
......................................................................
Patch Set 4:
(1 comment)
File src/cpu/x86/smm/smm_module_loaderv2.c:
https://review.coreboot.org/c/coreboot/+/49460/comment/f361d8e8_c7eaef2e
PS4, Line 613: if (CONFIG(CONSOLE_OVERRIDE_LOGLEVEL)) {
How about always passing the ramstage loglevel, with an override possible if CONSOLE_OVERRIDE_LOGLEVEL is set, which makes an implementation of get_smm_loglevel mandatory (no __weak function).
The motivation for this is that there are other ways to set the loglevel (fetching rtc cmos option) that you also want to avoid doing in smm.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81722a4f1bf75ec942cc06e403ad702dfe938e71
Gerrit-Change-Number: 49460
Gerrit-PatchSet: 4
Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Rocky Phagura <rphagura(a)fb.com>
Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 14:25:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Patrick Rudolph.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51179
to look at the new patch set (#3).
Change subject: T440P: Add FN Lock inversion
......................................................................
T440P: Add FN Lock inversion
The current f1 to f12 as primary just enables FN Lock and causes a light to enable on the keyboard of the T440P.
Newer machine firmware has the option to invert FN Lock so that the unlocked state has the light on and locked has
it off. This way you have no light and can use the F keys instead of hotkeys unless you hold FN or enable FN lock.
Obviously now we don't want FN lock on by default. This was tested on both the T440P and X250 so should be present in
all thinkpads with a FN light that had the option in the bios.
Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Signed-off-by: Ph0rk0z <Crabstorage(a)getbackinthe.kitchen>
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/h8.c
M src/mainboard/lenovo/t440p/cmos.default
M src/mainboard/lenovo/t440p/cmos.layout
4 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/51179/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/51179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Gerrit-Change-Number: 51179
Gerrit-PatchSet: 3
Gerrit-Owner: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Forkoz, Alexander Couzens, Patrick Rudolph.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51179
to look at the new patch set (#2).
Change subject: The current f1 to f12 as primary just enables FN Lock and causes a light to enable on the keyboard of the T440P. Newer machine firmware has the option to invert FN Lock so that the unlocked state has the light on and locked has it off. This way you have no light and can use the F keys instead of hotkeys unless you hold FN or enable FN lock.
......................................................................
The current f1 to f12 as primary just enables FN Lock and causes a light to enable on the keyboard of the T440P.
Newer machine firmware has the option to invert FN Lock so that the unlocked state has the light on and locked has
it off. This way you have no light and can use the F keys instead of hotkeys unless you hold FN or enable FN lock.
Obviously now we don't want FN lock on by default. This was tested on both the T440P and X250 so should be present in
all thinkpads with a FN light that had the option in the bios.
Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Signed-off-by: Ph0rk0z <Crabstorage(a)getbackinthe.kitchen>
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/h8.c
M src/mainboard/lenovo/t440p/cmos.default
M src/mainboard/lenovo/t440p/cmos.layout
4 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/51179/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Gerrit-Change-Number: 51179
Gerrit-PatchSet: 2
Gerrit-Owner: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51180 )
Change subject: util/sconfig: Fix for multidomain support sconfig/devicetree.cb
......................................................................
Patch Set 1:
(2 comments)
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/51180/comment/66269495_150dcd21
PS1, Line 1222: fprintf(head, "extern DEVTREE_CONST struct device *DEVTREE_CONST __pci_%d_%02x_%d;\n",
line over 96 characters
https://review.coreboot.org/c/coreboot/+/51180/comment/67770e53_a0de83f5
PS1, Line 1224: fprintf(fil, "DEVTREE_CONST struct device *DEVTREE_CONST __pci_%d_%02x_%d = &%s;\n",
line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/51180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd639d0cb3ed1a49ed7c7b1c77ac747ba6f77672
Gerrit-Change-Number: 51180
Gerrit-PatchSet: 1
Gerrit-Owner: Mariusz Szafrański <mariuszx.szafranski(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 14:14:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment