Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51176 )
Change subject: src/drivers/i2c/rx6110sa: Add official ACPI ID
......................................................................
src/drivers/i2c/rx6110sa: Add official ACPI ID
In patch CB:47706 the randomly and therefore wrong assigned ACPI ID for
RTC RX6110SA was removed. In the meantime Seiko-Epson did a great job
and have registered an official vendor ID in the ACPI database [1].
Further on, Seiko-Epson have now assigned the unique Product Identifier
for the RX6110SA, which is '6110'. The assignment of the Product
Identifier is controlled by the vendor and there is no official database
where this ID is stored in. It is up to the vendor to make sure that
this ID stays unique.
This patch adds this new vendor and product ID to the driver. Together
with a pending Linux patch this RTC is now useable as ACPI device in
Linux.
[1] https://uefi.org/ACPI_ID_List?search=SECC
Change-Id: I45838162f014a760520692c6dcaae329ad98547d
Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com>
---
M src/drivers/i2c/rx6110sa/rx6110sa.c
M src/drivers/i2c/rx6110sa/rx6110sa.h
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/51176/1
diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.c b/src/drivers/i2c/rx6110sa/rx6110sa.c
index 210444e..2b8b9b2 100644
--- a/src/drivers/i2c/rx6110sa/rx6110sa.c
+++ b/src/drivers/i2c/rx6110sa/rx6110sa.c
@@ -198,6 +198,7 @@
/* Device */
acpigen_write_scope(scope);
acpigen_write_device(acpi_device_name(dev));
+ acpigen_write_name_string("_HID", RX6110SA_HID_NAME);
acpigen_write_name_string("_DDN", RX6110SA_HID_DESC);
acpigen_write_STA(acpi_device_status(dev));
diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.h b/src/drivers/i2c/rx6110sa/rx6110sa.h
index fc0109d..5be6be7 100644
--- a/src/drivers/i2c/rx6110sa/rx6110sa.h
+++ b/src/drivers/i2c/rx6110sa/rx6110sa.h
@@ -4,6 +4,7 @@
#define _I2C_RX6110SA_H_
#define RX6110SA_ACPI_NAME "ERX6"
+#define RX6110SA_HID_NAME "SECC6110"
#define RX6110SA_HID_DESC "Real Time Clock"
/* Register layout */
--
To view, visit https://review.coreboot.org/c/coreboot/+/51176
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45838162f014a760520692c6dcaae329ad98547d
Gerrit-Change-Number: 51176
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: newchange
Attention is currently required from: Iru Cai.
Hello Iru Cai,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/51175
to review the following change.
Change subject: autoport: add a go.mod file
......................................................................
autoport: add a go.mod file
Go 1.16 needs this when running `go build`.
Change-Id: I9dcb134a68b7a726f1466a472a415c9558f60524
Signed-off-by: Iru Cai <mytbk920423(a)gmail.com>
---
A util/autoport/go.mod
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/51175/1
diff --git a/util/autoport/go.mod b/util/autoport/go.mod
new file mode 100644
index 0000000..55a89cc
--- /dev/null
+++ b/util/autoport/go.mod
@@ -0,0 +1 @@
+module autoport
--
To view, visit https://review.coreboot.org/c/coreboot/+/51175
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dcb134a68b7a726f1466a472a415c9558f60524
Gerrit-Change-Number: 51175
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Hung-Te Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51174 )
Change subject: soc/mediatek/mt8192: Increase PRERAM_CBMEM_CONSOLE to 128K
......................................................................
Patch Set 1:
(1 comment)
File src/soc/mediatek/mt8192/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/51174/comment/b235bab5_db2484ee
PS1, Line 51: 128K
For full calibration, the romstage log can be as large as 430K, which is larger than the default cbmem size 128K. Therefore, it's still impossible to store all full-k logs.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51174
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I896884d298e197149f75865e9d00579124a34404
Gerrit-Change-Number: 51174
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 11:16:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin.
Yu-Ping Wu has removed Julius Werner from this change. ( https://review.coreboot.org/c/coreboot/+/51174 )
Change subject: soc/mediatek/mt8192: Increase PRERAM_CBMEM_CONSOLE to 128K
......................................................................
Removed reviewer Julius Werner.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51174
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I896884d298e197149f75865e9d00579124a34404
Gerrit-Change-Number: 51174
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Hung-Te Lin, Xi Chen, Nico Huber, Martin Roth, Paul Menzel, Julius Werner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50294 )
Change subject: vendor: mediatek: Add mediatek mt8192 dram initialization codes
......................................................................
Patch Set 16:
(1 comment)
File src/vendorcode/mediatek/Kconfig:
https://review.coreboot.org/c/coreboot/+/50294/comment/ceae23b5_9afb7945
PS16, Line 3: config DEBUG_DRAM
: bool "Output verbose DRAM related debug messages"
: default y
: help
: This option enables additional DRAM related debug messages.
> this is the only config in dramc. […]
I'd suggest reusing the existing `DEBUG_RAM_SETUP` Kconfig option. It is shown when `HAVE_DEBUG_RAM_SETUP` is selected.
For the debug macro, I'd use the Kconfig value directly so that the compiler can optimize unused code away in non-debug builds:
#define dramc_dbg(_x_...) do { \
if (CONFIG(DEBUG_DRAM)) \
printk(BIOS_INFO, _x_); \
} while (0)
The do-while construct in macros is used to "swallow the semicolon": https://gcc.gnu.org/onlinedocs/cpp/Swallowing-the-Semicolon.html
--
To view, visit https://review.coreboot.org/c/coreboot/+/50294
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3853204578069c6abf52689ea6f5d88841414bd4
Gerrit-Change-Number: 50294
Gerrit-PatchSet: 16
Gerrit-Owner: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Cindy Ching <cindy.ching(a)mediatek.corp-partner.google.com>
Gerrit-CC: Joel Kitching <kitching(a)google.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Stefan Reinauer <reinauer(a)chromium.org>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-CC: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-CC: Yidi Lin <yidi.lin(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 10:48:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Michael Niewöhner, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51148 )
Change subject: soc/intel/cannonlake: Move `gpi_clear_int_cfg()` call
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/cannonlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/51148/comment/2d59438d_412ac0fa
PS1, Line 139: gpi_clear_int_cfg
> Not for this change: […]
I see. I was wondering why this was done so early. Thanks for the insight!
--
To view, visit https://review.coreboot.org/c/coreboot/+/51148
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f40ee7fd47f7f9f582f314dfcd1b4b93b1db791
Gerrit-Change-Number: 51148
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 10:41:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Martin Roth, Paul Menzel, Julius Werner, Ron Minnich, HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50966 )
Change subject: Documentation/coding_style: Issues not mentioned and cleanup patches
......................................................................
Patch Set 2:
(1 comment)
File Documentation/coding_style.md:
https://review.coreboot.org/c/coreboot/+/50966/comment/71f35826_6bb93e83
PS1, Line 22: improvement. By default the style choices of the original author should
> Sure, I would not consider that a "cleanup patch" in this sense because deduplicating is an actual c […]
I honestly don't remember if I wanted anything to be added.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88efd5f1006bd1fd82cea14ea65422d9958dc197
Gerrit-Change-Number: 50966
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Ron Minnich <rminnich(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Ron Minnich <rminnich(a)google.com>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 02 Mar 2021 10:36:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Martin Roth, Kangheui Won, EricR Lai.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51171 )
Change subject: mb/google/zork/var/vilboz: Update WiFi SAR for Vilboz
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Here is the detail:
https://partnerissuetracker.corp.google.com/issues/177684735#comment72
--
To view, visit https://review.coreboot.org/c/coreboot/+/51171
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I477b55d64fd9d33d753b10b2de443041a12d13e2
Gerrit-Change-Number: 51171
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 10:35:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment