Attention is currently required from: Martin Roth, zanxi chen, Henry Sun, Paul Menzel, Weimin Wu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51016 )
Change subject: mb/google/dedede/var/storo:Add P-sensor for storo
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iced4ab7d94b38ef8b1807955cbb887454accb1e8
Gerrit-Change-Number: 51016
Gerrit-PatchSet: 5
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 08:21:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, zanxi chen, Henry Sun, Paul Menzel.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51003 )
Change subject: mb/google/dedede/var/storo: Add codec and speaker amplifier support
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51003
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia864ac47223adb80463966209f6ff3640b715378
Gerrit-Change-Number: 51003
Gerrit-PatchSet: 4
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 02 Mar 2021 08:20:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Henry Sun, zanxi chen, Paul Menzel, Andy Yeh, Weimin Wu, ShawnX Tu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50995 )
Change subject: mb/google/dedede/var/storo: Add camera support
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> henry is correct. no need check whether EEPROM is provisioned in coreboot.
If a second source is introduced at a later point in time, we need to differentiate identify unprovisioned scenario.
Because in the factory on the first boot, SSFC will be unprovisioned and read as 0. That will cause us to apply the power sequencing for the first camera because the default SSFC value is 0.
Andy,
I am not sure why camera EEPROM does not need to be provisioned. If we don't do it now, then it will be hard to identify the camera source at the factory and provision the SSFC fields in CBI EEPROM.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98d5708d1955406c2e46db972903057bb3d12dcc
Gerrit-Change-Number: 50995
Gerrit-PatchSet: 2
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: ShawnX Tu <shawnx.tu(a)intel.com>
Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Attention: ShawnX Tu <shawnx.tu(a)intel.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 08:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Henry Sun <henrysun(a)google.com>
Comment-In-Reply-To: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Andy Yeh <andy.yeh(a)intel.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Paul Menzel, Arthur Heymans.
Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51168 )
Change subject: util/chromeos: Verify sha1sums of downloaded recovery images
......................................................................
Patch Set 2:
(1 comment)
File util/chromeos/crosfirmware.sh:
https://review.coreboot.org/c/coreboot/+/51168/comment/b06ba21d_c61541b9
PS1, Line 51: sha1_list="$(grep sha1 ${_cfgfile} | sed 's/sha1=//g')"
> > Because the way the inventory is structured, there's no way to reliably do that. […]
How would I do that in bash? that is,' read the line 2 lines up
--
To view, visit https://review.coreboot.org/c/coreboot/+/51168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b21c89f2d2d89f4a161a0aa5eea904ca547cb80
Gerrit-Change-Number: 51168
Gerrit-PatchSet: 2
Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 02 Mar 2021 08:09:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Benjamin Doron, Patrick Rudolph.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50726 )
Change subject: soc/intel/skylake: Enable compression on FSP-S
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/50726
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idace01227cfd2312b2c4c4ea1e6aaac8c21cd6b0
Gerrit-Change-Number: 50726
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 08:08:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Paul Menzel, Leah Rowe.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51168 )
Change subject: util/chromeos: Verify sha1sums of downloaded recovery images
......................................................................
Patch Set 2:
(1 comment)
File util/chromeos/crosfirmware.sh:
https://review.coreboot.org/c/coreboot/+/51168/comment/63f6a9ba_dbc62bb4
PS1, Line 51: sha1_list="$(grep sha1 ${_cfgfile} | sed 's/sha1=//g')"
> Because the way the inventory is structured, there's no way to reliably do that. So I currently make an assumption that google always has the correct sha1sum defined for each image.
>
> With that assumption in mind, the logic works just fine.
The structure of the inventory seem such that it can be done in a very reliable way. E.g. the sha1= entry is always 2 lines above the file= entry.
A checksum for a file makes sense, a checksum list of which one has to match the file partially defeats the purpose of doing it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b21c89f2d2d89f4a161a0aa5eea904ca547cb80
Gerrit-Change-Number: 51168
Gerrit-PatchSet: 2
Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 08:06:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Paul Menzel, Arthur Heymans.
Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51168 )
Change subject: util/chromeos: Verify sha1sums of downloaded recovery images
......................................................................
Patch Set 1:
(3 comments)
File util/chromeos/crosfirmware.sh:
https://review.coreboot.org/c/coreboot/+/51168/comment/4a42e1c8_0008e200
PS1, Line 51: sha1_list="$(grep sha1 ${_cfgfile} | sed 's/sha1=//g')"
> Why check against all sha1sums and not just the one for the board you need?
Because the way the inventory is structured, there's no way to reliably do that. So I currently make an assumption that google always has the correct sha1sum defined for each image.
With that assumption in mind, the logic works just fine.
https://review.coreboot.org/c/coreboot/+/51168/comment/e575d939_34f0dfad
PS1, Line 138:
> Please remove.
done
https://review.coreboot.org/c/coreboot/+/51168/comment/58f463c6_196287ef
PS1, Line 168:
> Please remove.
done
--
To view, visit https://review.coreboot.org/c/coreboot/+/51168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b21c89f2d2d89f4a161a0aa5eea904ca547cb80
Gerrit-Change-Number: 51168
Gerrit-PatchSet: 1
Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 02 Mar 2021 07:51:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Paul Menzel, Leah Rowe.
Hello build bot (Jenkins), Matt DeVillier, Paul Menzel, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51168
to look at the new patch set (#2).
Change subject: util/chromeos: Verify sha1sums of downloaded recovery images
......................................................................
util/chromeos: Verify sha1sums of downloaded recovery images
coreboot wasn't doing any integrity checks. This change adds sha1sum checking
on all downloaded recovery images, using sha1sums defined inside Google's own
inventory file.
If downloading multiple recovery images, the process does not stop. For example
if one file fails verification, the script will still download other files if
*those* pass verification.
Change-Id: I2b21c89f2d2d89f4a161a0aa5eea904ca547cb80
Signed-off-by: Leah Rowe <leah(a)retroboot.org>
---
M util/chromeos/crosfirmware.sh
1 file changed, 29 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/51168/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b21c89f2d2d89f4a161a0aa5eea904ca547cb80
Gerrit-Change-Number: 51168
Gerrit-PatchSet: 2
Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Ivy Jian, Patrick Rudolph, EricR Lai.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Ivy Jian, Patrick Rudolph, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51167
to look at the new patch set (#6).
Change subject: util: Add new memory part for brya boards
......................................................................
util: Add new memory part for brya boards
Add memory part MT53E2G32D4NQ-046 to LP4x global list. Attributes
are derived from data sheets.
BUG=b:181378727
TEST=Compared generated SPD with data sheets and checked in SPD
Change-Id: Ic06e9d672a2d3db2b4ea12d15b462843c90db8f6
Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com>
---
A src/soc/intel/alderlake/spd/lp4x-spd-6.hex
A src/soc/intel/alderlake/spd/lp4x-spd-7.hex
M src/soc/intel/alderlake/spd/lp4x_spd_manifest.generated.txt
M util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt
4 files changed, 79 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/51167/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/51167
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic06e9d672a2d3db2b4ea12d15b462843c90db8f6
Gerrit-Change-Number: 51167
Gerrit-PatchSet: 6
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Amanda Hwang, Ivy Jian, Patrick Rudolph, EricR Lai.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Ivy Jian, Patrick Rudolph, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51167
to look at the new patch set (#5).
Change subject: util: Add new memory part for brya boards
......................................................................
util: Add new memory part for brya boards
Add memory part MT53E2G32D4NQ-046 to LP4x global list. Attributes
are derived from data sheets.
BUG=b:181378727
TEST=Compared generated SPD with data sheets and checked in SPD
Change-Id: Ic06e9d672a2d3db2b4ea12d15b462843c90db8f6
Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com>
---
A src/soc/intel/alderlake/spd/lp4x-spd-6.hex
A src/soc/intel/alderlake/spd/lp4x-spd-7.hex
M src/soc/intel/alderlake/spd/lp4x_spd_manifest.generated.txt
M util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt
4 files changed, 105 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/51167/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/51167
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic06e9d672a2d3db2b4ea12d15b462843c90db8f6
Gerrit-Change-Number: 51167
Gerrit-PatchSet: 5
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset