Attention is currently required from: Philipp Deppenwiese, Jonathan Zhang, Johnny Lin, Julius Werner, Arthur Heymans, Deomid "rojer" Ryabkov.
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51099 )
Change subject: lib/cbfs.c: Fix return value of failure to measure
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> This error case is most likely a TPM communication issue or something like that, it's not really rel […]
True - you got it wrong Philipp. Dieing is not an option here because you brick machines which have measured boot enabled, and the TPM starts failing for what-ever reasons.
That's okay for me for now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51099
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd20e543d3b30de045c0656eccdcc494c2fb10ce
Gerrit-Change-Number: 51099
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 12:08:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Iru Cai.
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51175 )
Change subject: autoport: add a go.mod file
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I've just checked the Go 1.16 release notes (https://golang.org/doc/go1.16), the current code can still be built with GO111MODULE=auto. And it seems to be the easiest way to build util/intelp2m with Go 1.16.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51175
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dcb134a68b7a726f1466a472a415c9558f60524
Gerrit-Change-Number: 51175
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 11:56:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51177 )
Change subject: libpayload: Enable LTO by default
......................................................................
libpayload: Enable LTO by default
Link Time Optimization (LTO) decreases the size of the binaries, which
is important for firmware with small flash ROM chip sizes. Using LTO
might result in longer build times, which is not an issue for a small
project like libpayload.
Therefore, enable LTO by default.
Change-Id: I4bc58034ea8a9510ddc08d61d19e75a7c6f9cbc7
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
---
M payloads/libpayload/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/51177/1
diff --git a/payloads/libpayload/Kconfig b/payloads/libpayload/Kconfig
index 7a502b5..ae4d1d8 100644
--- a/payloads/libpayload/Kconfig
+++ b/payloads/libpayload/Kconfig
@@ -81,7 +81,7 @@
config LTO
bool "Use link time optimization (LTO)"
- default n
+ default y
depends on COMPILER_GCC
help
Compile with link time optimization. This can often decrease the
--
To view, visit https://review.coreboot.org/c/coreboot/+/51177
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bc58034ea8a9510ddc08d61d19e75a7c6f9cbc7
Gerrit-Change-Number: 51177
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newchange
Attention is currently required from: Paul Menzel.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51176 )
Change subject: src/drivers/i2c/rx6110sa: Add official ACPI ID
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51176/comment/91344f43_c2ceb3d0
PS1, Line 9: wrong
> wrongly?
It was assigned randomly and was therefore wrong. It was not wrongly assigned but on purpose. Or am I mistaken?
https://review.coreboot.org/c/coreboot/+/51176/comment/c73da299_72c5538f
PS1, Line 9: CB:47706
> I’d prefer commit hashes.
OK, will update.
https://review.coreboot.org/c/coreboot/+/51176/comment/de56f098_488483a1
PS1, Line 11: have registered
> registered […]
Ack
https://review.coreboot.org/c/coreboot/+/51176/comment/f242ea38_d789ac63
PS1, Line 12: have
> has?
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/51176
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45838162f014a760520692c6dcaae329ad98547d
Gerrit-Change-Number: 51176
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 02 Mar 2021 11:48:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: comment
Attention is currently required from: Frank Wu, Furquan Shaikh, Martin Roth, Kangheui Won, EricR Lai.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51171 )
Change subject: mb/google/zork/var/vilboz: Update WiFi SAR for Vilboz
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/51171
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I477b55d64fd9d33d753b10b2de443041a12d13e2
Gerrit-Change-Number: 51171
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 11:44:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51174 )
Change subject: soc/mediatek/mt8192: Increase PRERAM_CBMEM_CONSOLE to 128K
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51174/comment/836c5bd2_ff8d3fc0
PS1, Line 9: 128K
What is the current default?
Patchset:
PS1:
I would have thought some Kconfig value also needs to be set.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51174
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I896884d298e197149f75865e9d00579124a34404
Gerrit-Change-Number: 51174
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 11:44:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Iru Cai, Iru Cai (vimacs).
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51175 )
Change subject: autoport: add a go.mod file
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/51175
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dcb134a68b7a726f1466a472a415c9558f60524
Gerrit-Change-Number: 51175
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Attention: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 11:43:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Tim Wawrzynczak, Subrata Banik, Michael Niewöhner, Andrey Petrov, Nathaniel L Desimone.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49899 )
Change subject: soc/intel/*: Update microcode as specified for MP-init
......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS13:
Looks like, on client platforms, FIT µcode update gets applied to all cores, so updating µcode in MP-init is a no-op. https://software.intel.com/security-software-guidance/best-practices/microc…
If my understanding is correct, the only platforms which could run into issues with this change are model_206ax and earlier.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49899
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf2b009ac9dd7cd462abe0f787f27b09feb6ec5b
Gerrit-Change-Number: 49899
Gerrit-PatchSet: 13
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 11:43:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Henry Sun, Paul Menzel, Weimin Wu.
zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51016 )
Change subject: mb/google/dedede/var/storo:Add P-sensor for storo
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51016/comment/c2115bc5_8d37b267
PS2, Line 8: Add P-sensor into devicetree for storo.
> It seems to be there again.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/51016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iced4ab7d94b38ef8b1807955cbb887454accb1e8
Gerrit-Change-Number: 51016
Gerrit-PatchSet: 5
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 11:34:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: comment