coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7266 discussions

Change in coreboot[master]: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
by Paul Menzel (Code Review) 03 Mar '21

03 Mar '21

Attention is currently required from: Kevin Chang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 ) Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51200/comment/7376b486_a4f714d0 PS3, Line 9: because some MB is using wrong Samsung date code memory. I do not understand this part. Can you please rephrase it? -- To view, visit https://review.coreboot.org/c/coreboot/+/51200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Gerrit-Change-Number: 51200 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Comment-Date: Wed, 03 Mar 2021 10:07:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
by build bot (Jenkins) (Code Review) 03 Mar '21

03 Mar '21

Attention is currently required from: Kevin Chang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 ) Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB ...................................................................... Patch Set 3: (2 comments) File src/mainboard/google/volteer/variants/lindar/memory.c: https://review.coreboot.org/c/coreboot/+/51200/comment/9ed83cab_c1f0e257 PS3, Line 72: if ((google_chromeec_get_board_version(&board_version) == 0) && (board_version == 1)) suspect code indent for conditional statements (8, 8) File src/soc/intel/tigerlake/include/soc/romstage.h: https://review.coreboot.org/c/coreboot/+/51200/comment/5cf5cb42_a905ef19 PS3, Line 10: void __weak memcfg_variant_init(FSPM_UPD *mupd); Using weak declarations can have unintended link defects -- To view, visit https://review.coreboot.org/c/coreboot/+/51200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Gerrit-Change-Number: 51200 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com> Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Comment-Date: Wed, 03 Mar 2021 10:05:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
by Kevin Chang (Code Review) 03 Mar '21

03 Mar '21

Attention is currently required from: Kevin Chang. Hello build bot (Jenkins), Patrick Rudolph, Zhuohao Lee, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51200 to look at the new patch set (#3). Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB ...................................................................... mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB Disable SA GV in EVT MB, because some MB is using wrong Samsung date code memory. BUG=b:179747696 BRANCH=firmware-volteer-13672.B TEST=Built and booted into OS. Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> --- M src/mainboard/google/volteer/romstage.c M src/mainboard/google/volteer/variants/lindar/memory.c M src/soc/intel/tigerlake/include/soc/romstage.h 3 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/51200/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/51200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Gerrit-Change-Number: 51200 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com> Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
by build bot (Jenkins) (Code Review) 03 Mar '21

03 Mar '21

Attention is currently required from: Kevin Chang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 ) Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB ...................................................................... Patch Set 2: (2 comments) File src/mainboard/google/volteer/variants/lindar/memory.c: https://review.coreboot.org/c/coreboot/+/51200/comment/a949718a_f8dec7d5 PS2, Line 72: if (google_chromeec_get_board_version(&board_version) == 0 && board_version == 1) suspect code indent for conditional statements (8, 8) File src/soc/intel/tigerlake/include/soc/romstage.h: https://review.coreboot.org/c/coreboot/+/51200/comment/177fbcfb_fe3fb1a3 PS2, Line 10: void __weak memcfg_variant_init(FSPM_UPD *mupd); Using weak declarations can have unintended link defects -- To view, visit https://review.coreboot.org/c/coreboot/+/51200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Gerrit-Change-Number: 51200 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com> Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Comment-Date: Wed, 03 Mar 2021 09:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
by Kevin Chang (Code Review) 03 Mar '21

03 Mar '21

Hello Patrick Rudolph, Zhuohao Lee, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51200 to look at the new patch set (#2). Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB ...................................................................... mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB Disable SA GV in EVT MB, because some MB is using wrong Samsung date code memory. BUG=b:179747696 BRANCH=firmware-volteer-13672.B TEST=Built and booted into OS. Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> --- M src/mainboard/google/volteer/romstage.c M src/mainboard/google/volteer/variants/lindar/memory.c M src/soc/intel/tigerlake/include/soc/romstage.h 3 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/51200/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Gerrit-Change-Number: 51200 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
by Kevin Chang (Code Review) 03 Mar '21

03 Mar '21

Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 ) Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/51200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Gerrit-Change-Number: 51200 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 03 Mar 2021 09:49:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/blipper: Generate SPD ID for supported memory parts
by zanxi chen (Code Review) 03 Mar '21

03 Mar '21

zanxi chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51201 ) Change subject: mb/google/dedede/var/blipper: Generate SPD ID for supported memory parts ...................................................................... mb/google/dedede/var/blipper: Generate SPD ID for supported memory parts Add supported memory parts in the mem_parts_used.txt and generate the SPD ID for the memory parts. The memory parts being added are: MT53E512M32D2NP-046 WT:E K4U6E3S4AA-MGCR H9HCNNNBKMMLXR-NEE BUG=None TEST=Build the blipper board. Change-Id: Ia7e4c1d5c06013c1902816d6dcafb5a8a0386bb3 Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/blipper/memory/Makefile.inc M src/mainboard/google/dedede/variants/blipper/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/blipper/memory/mem_parts_used.txt 3 files changed, 8 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/51201/1 diff --git a/src/mainboard/google/dedede/variants/blipper/memory/Makefile.inc b/src/mainboard/google/dedede/variants/blipper/memory/Makefile.inc index b0ca222..d0960c7 100644 --- a/src/mainboard/google/dedede/variants/blipper/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/blipper/memory/Makefile.inc @@ -1,5 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. -SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE diff --git a/src/mainboard/google/dedede/variants/blipper/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/blipper/memory/dram_id.generated.txt index fa24790..0df7bfc 100644 --- a/src/mainboard/google/dedede/variants/blipper/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/blipper/memory/dram_id.generated.txt @@ -1 +1,4 @@ DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:E 0 (0000) +K4U6E3S4AA-MGCR 0 (0000) +H9HCNNNBKMMLXR-NEE 0 (0000) diff --git a/src/mainboard/google/dedede/variants/blipper/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/blipper/memory/mem_parts_used.txt index e4258b5..47159f8 100644 --- a/src/mainboard/google/dedede/variants/blipper/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/blipper/memory/mem_parts_used.txt @@ -1,11 +1,3 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# One part per line with an optional fixed ID in column 2. -# Only include a fixed ID if it is required for legacy reasons! -# Generated IDs are dependent on the order of parts in this file, -# so new parts must always be added at the end of the file! -# -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/{ddr4,lp4x}. -# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions. - -# Part Name +MT53E512M32D2NP-046 WT:E +K4U6E3S4AA-MGCR +H9HCNNNBKMMLXR-NEE -- To view, visit https://review.coreboot.org/c/coreboot/+/51201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7e4c1d5c06013c1902816d6dcafb5a8a0386bb3 Gerrit-Change-Number: 51201 Gerrit-PatchSet: 1 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
by build bot (Jenkins) (Code Review) 03 Mar '21

03 Mar '21

Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 ) Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/volteer/variants/lindar/memory.c: https://review.coreboot.org/c/coreboot/+/51200/comment/e6391d1f_2f74f024 PS1, Line 72: if (google_chromeec_get_board_version(&board_version) == 0 suspect code indent for conditional statements (8, 8) File src/soc/intel/tigerlake/include/soc/romstage.h: https://review.coreboot.org/c/coreboot/+/51200/comment/e70868b0_24c8d1bf PS1, Line 10: void __weak memcfg_variant_init(FSPM_UPD *mupd); Using weak declarations can have unintended link defects -- To view, visit https://review.coreboot.org/c/coreboot/+/51200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Gerrit-Change-Number: 51200 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 03 Mar 2021 09:48:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
by Kevin Chang (Code Review) 03 Mar '21

03 Mar '21

Kevin Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51200 ) Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB ...................................................................... mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB Disable SA GV in EVT MB, because some MB is using wrong Samsung date code memory. BUG=b:179747696 BRANCH=firmware-volteer-13672.B TEST=Built and booted into OS. Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f --- M src/mainboard/google/volteer/romstage.c M src/mainboard/google/volteer/variants/lindar/memory.c M src/soc/intel/tigerlake/include/soc/romstage.h 3 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/51200/1 diff --git a/src/mainboard/google/volteer/romstage.c b/src/mainboard/google/volteer/romstage.c index f3fb454..dadaccc 100644 --- a/src/mainboard/google/volteer/romstage.c +++ b/src/mainboard/google/volteer/romstage.c @@ -22,4 +22,5 @@ bool half_populated = gpio_get(GPIO_MEM_CH_SEL); memcfg_init(mem_cfg, board_cfg, &spd_info, half_populated); + memcfg_variant_init(mupd); } diff --git a/src/mainboard/google/volteer/variants/lindar/memory.c b/src/mainboard/google/volteer/variants/lindar/memory.c index f9350d1..52a0061 100644 --- a/src/mainboard/google/volteer/variants/lindar/memory.c +++ b/src/mainboard/google/volteer/variants/lindar/memory.c @@ -1,6 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <baseboard/variants.h> +#include <memory_info.h> +#include <fw_config.h> +#include <ec/google/chromeec/ec.h> +#include <soc/romstage.h> static const struct mb_cfg board_memcfg = { .type = MEM_TYPE_LP4X, @@ -59,3 +63,13 @@ { return &board_memcfg; } + +void __weak memcfg_variant_init(FSPM_UPD *mupd) +{ + uint32_t board_version; + FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig; + + if (google_chromeec_get_board_version(&board_version) == 0 + && board_version == 1) + mem_cfg->SaGv = 0x00; +} diff --git a/src/soc/intel/tigerlake/include/soc/romstage.h b/src/soc/intel/tigerlake/include/soc/romstage.h index ba44f2d..3c7c545 100644 --- a/src/soc/intel/tigerlake/include/soc/romstage.h +++ b/src/soc/intel/tigerlake/include/soc/romstage.h @@ -7,6 +7,7 @@ void mainboard_memory_init_params(FSPM_UPD *mupd); void systemagent_early_init(void); +void __weak memcfg_variant_init(FSPM_UPD *mupd); /* Board type */ enum board_type { -- To view, visit https://review.coreboot.org/c/coreboot/+/51200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Gerrit-Change-Number: 51200 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/mediatek/mt8192: use Mediatek mt8192 vendor code (CB:50294)
by Xi Chen (Code Review) 03 Mar '21

03 Mar '21

Attention is currently required from: Hung-Te Lin, Cindy Ching, Martin Roth, Shaoming Chen, Paul Menzel, Duan huayang. Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51125 ) Change subject: src/mediatek/mt8192: use Mediatek mt8192 vendor code (CB:50294) ...................................................................... Patch Set 13: (2 comments) Patchset: PS12: > this patch has too many things in one patch. Please split into: […] I have created a new TOT, which process the patch split, will update the patchlist later. PS12: > also, the message macros (especially those related to 73/83) should be moved to a new patch. Yes, will split the seperate patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/51125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b2f41d774c6b85f106867144fb0b29a4a1bdfcf Gerrit-Change-Number: 51125 Gerrit-PatchSet: 13 Gerrit-Owner: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Cindy Ching <cindy.ching(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Duan huayang <huayang.duan(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Cindy Ching <cindy.ching(a)mediatek.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Duan huayang <huayang.duan(a)mediatek.com> Gerrit-Comment-Date: Wed, 03 Mar 2021 09:42:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021