Attention is currently required from: Furquan Shaikh, Martin Roth.
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50007 )
Change subject: mb/google/mancomb: Add new mainboard
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/google/monkey_island/variants/baseboard/mancomb/gpio.c:
https://review.coreboot.org/c/coreboot/+/50007/comment/558e72e1_ffae4d7c
PS5, Line 8: 0
> Not required.
Ack
https://review.coreboot.org/c/coreboot/+/50007/comment/0d67791b_8d6ee4cc
PS5, Line 13: 0
> Not required.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/50007
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1264f44a0b986f7f7c89ac7b42f1e4e4119a35e6
Gerrit-Change-Number: 50007
Gerrit-PatchSet: 7
Gerrit-Owner: Mathew King <mathewk(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 19:59:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Furquan Shaikh, Bhanu Prakash Maiya, Eric Peers, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50283 )
Change subject: mb/google/zork: update telemetry settings for dirinboz
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
The -25 seems odd to me, but that's what the bug specifies, so LGTM.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50283
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0c941815d062d9af01858faf2121bc69f23ab44
Gerrit-Change-Number: 50283
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 04 Feb 2021 19:11:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Meera Ravindranath, Andrey Petrov, Patrick Rudolph, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50241 )
Change subject: drivers/intel/fsp2_0/memory_init: check if UPD struct has expected size
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/50241/comment/58e346bf_08aa1b25
PS1, Line 242: !=
> you mean >, since <= would be break the good case as well? if hdr->cfg_region_size is bigger than si […]
After looking at the code again, yes you're right. We set up the UPD region to be sizeof(fspm_upd) so we need to ensure the FSP's cfg_region doesn't exceed that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50241
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7e9f6f20d0091bbb4abfd42abb40b485da2079d
Gerrit-Change-Number: 50241
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 04 Feb 2021 19:08:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50270 )
Change subject: soc/amd/cezanne/fch: add ACPI I/O port setup
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File src/soc/amd/cezanne/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/50270/comment/31854bf9_d85658b8
PS1, Line 19: 0x0400
Curious why not use CONFIG_CEZANNE_ACPI_IO_BASE. 0x400 should be fine though.
https://review.coreboot.org/c/coreboot/+/50270/comment/664ef160_31ed8c83
PS1, Line 25: 0x10
This differs from Picasso. Was changed in CB:44135 however I believe we stripped it from AGESA so it shouldn't be an issue.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50270
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If80b841df12d351d5a0c1e0d2e7bf1e31b03447f
Gerrit-Change-Number: 50270
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 04 Feb 2021 18:58:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Benjamin Doron, Angel Pons.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50013 )
Change subject: mb/purism/librem_cnl: Implement `die_notify`
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> GPP_E8 is SATALED# for the SoC. […]
GPP_E8 is NC on the Librem 14
--
To view, visit https://review.coreboot.org/c/coreboot/+/50013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ffac0ab02e52e9fbba7990f401d87e50a1b5154
Gerrit-Change-Number: 50013
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 18:51:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Matt DeVillier, Angel Pons.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50013 )
Change subject: mb/purism/librem_cnl: Implement `die_notify`
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Hmmm... Good point. […]
GPP_E8 is SATALED# for the SoC. Unless the GPIO is known to be routed differently for some variants, I assume it's safe to move die.c out of variants.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ffac0ab02e52e9fbba7990f401d87e50a1b5154
Gerrit-Change-Number: 50013
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 18:29:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50006 )
Change subject: mb/google/mi: Add guybrush baseboard
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> @Mat, would you like to add the topic for the series change of monkey island? I can find it easily
I need to abandon this, we are splitting guybrush and mancomb
--
To view, visit https://review.coreboot.org/c/coreboot/+/50006
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4594a30cb40b05ca480f4fcf15768b64a079b6c5
Gerrit-Change-Number: 50006
Gerrit-PatchSet: 4
Gerrit-Owner: Mathew King <mathewk(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 04 Feb 2021 18:26:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Furquan Shaikh, Bhanu Prakash Maiya, Eric Peers, Felix Held.
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Bhanu Prakash Maiya, Eric Peers, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50282
to look at the new patch set (#3).
Change subject: mb/google/zork: update USB 3 controller phy Parameter for dirinboz
......................................................................
mb/google/zork: update USB 3 controller phy Parameter for dirinboz
Recommendation from SOC to config IQ=8 for U3 port0,
vboost for all U3 ports for passing ESD pin test.
BUG=b:175192931
BRANCH=zork
TEST=1. emerge-zork coreboot
2. run U3 SI/ESD pin test => pass
Change-Id: I42a94e03fb6f8230d4356d16b8e0d2164bc61e3f
Signed-off-by: Kevin Chiu <kevin.chiu(a)quantatw.com>
---
M src/mainboard/google/zork/variants/dirinboz/overridetree.cb
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/50282/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/50282
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42a94e03fb6f8230d4356d16b8e0d2164bc61e3f
Gerrit-Change-Number: 50282
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset