Attention is currently required from: Furquan Shaikh, Nick Vaccaro.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50129 )
Change subject: mb/google/volteer/variant/copano: support regular/numpad touchpad
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Logic looks okay to me. […]
Yes. We need two device nodes and use the FW_CONFIG to switch it at runtime.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50129
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5d61f19fd385600cfdcdd045dab1e61b06e4663
Gerrit-Change-Number: 50129
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Mon, 01 Feb 2021 01:07:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment