Attention is currently required from: Furquan Shaikh, Meera Ravindranath, Andrey Petrov, Patrick Rudolph, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50241 )
Change subject: drivers/intel/fsp2_0/memory_init: check if UPD struct has expected size
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/50241/comment/58e346bf_08aa1b25
PS1, Line 242: !=
you mean >, since <= would be break the good case as well? if hdr->cfg_region_size is bigger than si […]
After looking at the code again, yes you're right. We set up the UPD region to be sizeof(fspm_upd) so we need to ensure the FSP's cfg_region doesn't exceed that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50241
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7e9f6f20d0091bbb4abfd42abb40b485da2079d
Gerrit-Change-Number: 50241
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 04 Feb 2021 19:08:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment