coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: lib: Fix edge case of log2_ceil()
by Yu-Ping Wu (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Julius Werner, Yu-Ping Wu. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59834 ) Change subject: lib: Fix edge case of log2_ceil() ...................................................................... Patch Set 1: (1 comment) File tests/lib/lib-test.c: https://review.coreboot.org/c/coreboot/+/59834/comment/8fccd3fe_c9c3f83d PS1, Line 46: log2_ceil(0xffffffff) In the original implementation this will be 31: log2_ceil(0xffffffff) = log2((u32)0xffffffff * 2 - 1) = log2(0xfffffffd) = 31 -- To view, visit https://review.coreboot.org/c/coreboot/+/59834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If868f793b909a6ad7fc48a7affac15e2c714fa2e Gerrit-Change-Number: 59834 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 08:20:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib: Fix edge case of log2_ceil()
by Jakub Czapiga (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Julius Werner, Yu-Ping Wu. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59834 ) Change subject: lib: Fix edge case of log2_ceil() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/59834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If868f793b909a6ad7fc48a7affac15e2c714fa2e Gerrit-Change-Number: 59834 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 08:16:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib: Fix edge case of log2_ceil()
by Yu-Ping Wu (Code Review) 02 Dec '21

02 Dec '21

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59834 ) Change subject: lib: Fix edge case of log2_ceil() ...................................................................... lib: Fix edge case of log2_ceil() Current log2_ceil(x) is defined as log2(x * 2 - 1). When x is larger than (1 << 31), (x * 2 - 1) won't fit in u32, leading to incorrect result. Therefore, correct it by using log2_64() instead. Also add unit tests for inline functions in lib.h. BUG=none TEST=make tests/lib/lib-test BRANCH=none Change-Id: If868f793b909a6ad7fc48a7affac15e2c714fa2e Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/include/lib.h M tests/lib/Makefile.inc A tests/lib/lib-test.c 3 files changed, 66 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/59834/1 diff --git a/src/include/lib.h b/src/include/lib.h index 8e8bab5..15cfccc 100644 --- a/src/include/lib.h +++ b/src/include/lib.h @@ -54,12 +54,12 @@ /* Find First Set: __ffs(1) == 0, __ffs(0) == -1, __ffs(1<<31) == 31 */ static inline int __ffs(u32 x) { return log2(x & (u32)(-(s32)x)); } -/* Integer binary logarithm (rounding up): log2_ceil(0) == -1, log2(5) == 3 */ -static inline int log2_ceil(u32 x) { return (x == 0) ? -1 : log2(x * 2 - 1); } - static inline int popcnt64(u64 x) { return __builtin_popcountll(x); } static inline int clz64(u64 x) { return x ? __builtin_clzll(x) : sizeof(x) * 8; } static inline int log2_64(u64 x) { return sizeof(x) * 8 - clz64(x) - 1; } static inline int __ffs64(u64 x) { return log2_64(x & (u64)(-(s64)x)); } +/* Integer binary logarithm (rounding up): log2_ceil(0) == -1, log2_ceil(5) == 3 */ +static inline int log2_ceil(u32 x) { return (x == 0) ? -1 : log2_64((u64)x * 2 - 1); } + #endif /* __LIB_H__ */ diff --git a/tests/lib/Makefile.inc b/tests/lib/Makefile.inc index 0aea0ce..9a62476 100644 --- a/tests/lib/Makefile.inc +++ b/tests/lib/Makefile.inc @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only +tests-y += lib-test tests-y += string-test tests-y += b64_decode-test tests-y += hexstrtobin-test @@ -40,6 +41,8 @@ tests-y += cbfs-lookup-has-mcache-test tests-y += lzma-test +lib-test-srcs += tests/lib/lib-test.c + string-test-srcs += tests/lib/string-test.c string-test-srcs += src/lib/string.c diff --git a/tests/lib/lib-test.c b/tests/lib/lib-test.c new file mode 100644 index 0000000..adaa2f9 --- /dev/null +++ b/tests/lib/lib-test.c @@ -0,0 +1,60 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <lib.h> +#include <tests/test.h> + +void test_popcnt(void **state) +{ + assert_int_equal(popcnt(0x0), 0); + assert_int_equal(popcnt(0x10), 1); + assert_int_equal(popcnt(0x10010010), 3); + assert_int_equal(popcnt(0xffffffff), 32); +} + +void test_clz(void **state) +{ + assert_int_equal(clz(0x0), 32); + assert_int_equal(clz(0xf), 28); + assert_int_equal(clz(0x80000000), 0); + assert_int_equal(clz(0xffffffff), 0); +} + +void test_log2(void **state) +{ + assert_int_equal(log2(0x0), -1); + assert_int_equal(log2(0x1), 0); + assert_int_equal(log2(0x5), 2); + assert_int_equal(log2(0x80000000), 31); + assert_int_equal(log2(0xffffffff), 31); +} + +void test_ffs(void **state) +{ + assert_int_equal(__ffs(0x0), -1); + assert_int_equal(__ffs(0x1), 0); + assert_int_equal(__ffs(0x1010), 4); + assert_int_equal(__ffs(0x10000000), 28); + assert_int_equal(__ffs(0xffffffff), 0); +} + +void test_log2_ceil(void **state) +{ + assert_int_equal(log2_ceil(0x0), -1); + assert_int_equal(log2_ceil(0x1), 0); + assert_int_equal(log2_ceil(0x5), 3); + assert_int_equal(log2_ceil(0x80000000), 31); + assert_int_equal(log2_ceil(0xffffffff), 32); +} + +int main(void) +{ + const struct CMUnitTest tests[] = { + cmocka_unit_test(test_popcnt), + cmocka_unit_test(test_clz), + cmocka_unit_test(test_log2), + cmocka_unit_test(test_ffs), + cmocka_unit_test(test_log2_ceil), + }; + + return cb_run_group_tests(tests, NULL, NULL); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/59834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If868f793b909a6ad7fc48a7affac15e2c714fa2e Gerrit-Change-Number: 59834 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

Change in gerrit-avatars[master]: 1001940.jpg: add face for mkopec
by Michał Kopeć (Code Review) 02 Dec '21

02 Dec '21

Michał Kopeć has uploaded this change for review. ( https://review.coreboot.org/c/gerrit-avatars/+/59833 ) Change subject: 1001940.jpg: add face for mkopec ...................................................................... 1001940.jpg: add face for mkopec Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Change-Id: If7a6f8345ef4b2ffb086e35ac0c6e96796cd02bd --- A 1001940.jpg 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/gerrit-avatars refs/changes/33/59833/1 diff --git a/1001940.jpg b/1001940.jpg new file mode 100644 index 0000000..0a32cbd --- /dev/null +++ b/1001940.jpg Binary files differ -- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/59833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: If7a6f8345ef4b2ffb086e35ac0c6e96796cd02bd Gerrit-Change-Number: 59833 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation: Add warning about "private" changes on Gerrit
by Paul Menzel (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Patrick Georgi. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59229 ) Change subject: Documentation: Add warning about "private" changes on Gerrit ...................................................................... Patch Set 3: (2 comments) File Documentation/tutorial/part2.md: https://review.coreboot.org/c/coreboot/+/59229/comment/a9123c33_bd4e2874 PS3, Line 175: but is only visible to : yourself and those you add as reviewers. > … only visible in Gerrit’s Web interface … Obsolete. https://review.coreboot.org/c/coreboot/+/59229/comment/166f4e41_b6bfd4cb PS3, Line 177: ID > hash Obsolete. -- To view, visit https://review.coreboot.org/c/coreboot/+/59229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c8c6cccfd023bc1d839dc5d9544204c88f89c7e Gerrit-Change-Number: 59229 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Dec 2021 08:03:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add warning about "private" changes on Gerrit
by Paul Menzel (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Patrick Georgi. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59229 ) Change subject: Documentation: Add warning about "private" changes on Gerrit ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I didn’t see that it’s already merged. -- To view, visit https://review.coreboot.org/c/coreboot/+/59229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c8c6cccfd023bc1d839dc5d9544204c88f89c7e Gerrit-Change-Number: 59229 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Dec 2021 08:02:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add warning about "private" changes on Gerrit
by Paul Menzel (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Patrick Georgi. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59229 ) Change subject: Documentation: Add warning about "private" changes on Gerrit ...................................................................... Patch Set 3: (3 comments) File Documentation/getting_started/gerrit_guidelines.md: https://review.coreboot.org/c/coreboot/+/59229/comment/641a12a4_620e5b17 PS3, Line 197: Note that private Nit: Note, private … File Documentation/tutorial/part2.md: https://review.coreboot.org/c/coreboot/+/59229/comment/de75d3a4_c022709e PS3, Line 175: but is only visible to : yourself and those you add as reviewers. … only visible in Gerrit’s Web interface … https://review.coreboot.org/c/coreboot/+/59229/comment/920dae55_929ac6cc PS3, Line 177: ID hash -- To view, visit https://review.coreboot.org/c/coreboot/+/59229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c8c6cccfd023bc1d839dc5d9544204c88f89c7e Gerrit-Change-Number: 59229 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Dec 2021 08:01:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add support for ADL-N PCH
by Maulik V Vaghela (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Reka Norman, Paul Menzel, Rizwan Qureshi, Subrata Banik, Angel Pons, Krishna P Bhat D, Usha P, Patrick Rudolph, Kangheui Won. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59752 ) Change subject: soc/intel/alderlake: Add support for ADL-N PCH ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/59752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ebbcdcdb1ccc34b80ec71ac3e591fe4ad6b1904 Gerrit-Change-Number: 59752 Gerrit-PatchSet: 4 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kangheui Won <khwon(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Kangheui Won <khwon(a)google.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 07:55:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add support for ADL-N PCH
by Usha P (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Reka Norman, Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Subrata Banik, Angel Pons, Krishna P Bhat D, Patrick Rudolph, Kangheui Won. Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59752 ) Change subject: soc/intel/alderlake: Add support for ADL-N PCH ...................................................................... Patch Set 4: (2 comments) File src/soc/intel/alderlake/Kconfig: https://review.coreboot.org/c/coreboot/+/59752/comment/c00e44ad_2c0bd943 PS2, Line 193: default 5 if SOC_INTEL_ALDERLAKE_PCH_N > also check this […] Document 645548 chapter 13 indicates ADL-N supports 5 clock sources and 5 clock request signals. https://review.coreboot.org/c/coreboot/+/59752/comment/d590a1bb_3f277da1 PS2, Line 199: default 5 if SOC_INTEL_ALDERLAKE_PCH_N > same as above Document 645548 chapter 13 indicates ADL-N supports 5 clock sources and 5 clock request signals. -- To view, visit https://review.coreboot.org/c/coreboot/+/59752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ebbcdcdb1ccc34b80ec71ac3e591fe4ad6b1904 Gerrit-Change-Number: 59752 Gerrit-PatchSet: 4 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kangheui Won <khwon(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Kangheui Won <khwon(a)google.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 07:30:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add support for ADL-N PCH
by Usha P (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Reka Norman, Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Subrata Banik, Angel Pons, Krishna P Bhat D, Patrick Rudolph, Kangheui Won. Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59752 ) Change subject: soc/intel/alderlake: Add support for ADL-N PCH ...................................................................... Patch Set 4: (5 comments) Commit Message: PS2: > I'd squash CB:59751 into this change. […] Ack https://review.coreboot.org/c/coreboot/+/59752/comment/67916f75_e7ada22d PS2, Line 7: Configure 9 I/O for ADL-N > don't able to follow what is `9` here. […] Ack https://review.coreboot.org/c/coreboot/+/59752/comment/052aecd8_5a8c7b7b PS2, Line 7: soc/intel/alderlake: Configure 9 I/O for ADL-N > Please clarify number 9. […] Ack https://review.coreboot.org/c/coreboot/+/59752/comment/75e1ef56_e0ceebfe PS2, Line 9: Select number of I/O based on PCH for Alder Lake-N > Please elaborate the changes like what are different port supported such as 9 PCIe root ports, 5 Clk […] Ack File src/soc/intel/alderlake/Kconfig: https://review.coreboot.org/c/coreboot/+/59752/comment/d8f38461_6f0d9781 PS2, Line 177: default > Please take a look into this […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/59752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ebbcdcdb1ccc34b80ec71ac3e591fe4ad6b1904 Gerrit-Change-Number: 59752 Gerrit-PatchSet: 4 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kangheui Won <khwon(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Kangheui Won <khwon(a)google.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 07:30:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021