coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: crossgcc/Makefile: Clean-up
by Paul Menzel (Code Review) 04 Dec '21

04 Dec '21

Attention is currently required from: HAOUAS Elyes. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59397 ) Change subject: crossgcc/Makefile: Clean-up ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59397/comment/58648720_83d6095b PS2, Line 7: Clean-up Remove obsolete target build_make https://review.coreboot.org/c/coreboot/+/59397/comment/40f298c0_3c39642a PS2, Line 9: do does https://review.coreboot.org/c/coreboot/+/59397/comment/56d54bb5_f659e86d PS2, Line 9: coreboot do not build "Make" anymore. Since what commit? -- To view, visit https://review.coreboot.org/c/coreboot/+/59397 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f159fc912d09ebde6ac7ba5be83933aa251f1d5 Gerrit-Change-Number: 59397 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 04 Dec 2021 11:41:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile.inc: Ignore IASL's "Missing dependency" warning
by HAOUAS Elyes (Code Review) 04 Dec '21

04 Dec '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59880 ) Change subject: Makefile.inc: Ignore IASL's "Missing dependency" warning ...................................................................... Makefile.inc: Ignore IASL's "Missing dependency" warning IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects: 1) If _PRS is present, must have _CRS and _SRS 2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS) 3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS requires _CRS and _SRS) 4) If _SRS is present, probably should have a _DIS (Remark only) IASL will issue a warning for each missing dependency. Ignore this warnings for existing ASL code. Change-Id: I28b437194f08232727623009372327fec15215dd Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 219 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/59880/1 diff --git a/Makefile.inc b/Makefile.inc index 971a56c..5dcc40d 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -263,9 +263,228 @@ # Redundant offset remarks are not useful in any way and are masking useful # ones that might indicate an issue so it is better to hide them. REDUNDANT_OFFSET_REMARK = 2158 +# IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects: +# 1) If _PRS is present, must have _CRS and _SRS +# 2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS) +# 3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS requires _CRS and _SRS) +# 4) If _SRS is present, probably should have a _DIS (Remark only) +# A warning will be issued for each of these cases. +# For existing ASL code, ignore this warnings +IASL_MISSING_DEPENDENCY = 3141 IASL_WARNINGS_LIST = $(EMPTY_RESOURCE_TEMPLATE_WARNING) $(REDUNDANT_OFFSET_REMARK) +# Please fix your ASL code and remove dedicated lines below. +ifeq ($(CONFIG_BOARD_ACER_G43T_AM3),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ASROCK_H81M_HDS),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ASUS_AM1I_A),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ASUS_P5G41T_M_LX),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ASUS_P5QPL_AM),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ASUS_P8H61_M_LX),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_BIOSTAR_AM1ML),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_BOARD_INTEL_ADLRVP_COMMON),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_DELL_OPTIPLEX_9010),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_DELL_OPTIPLEX_9010_SFF),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FACEBOOK_FBG1701),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FACEBOOK_MONOLITH),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FOXCONN_D41S),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FOXCONN_G41M),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FOXCONN_G41M_),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FOXCONN_G41S_K),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GIGABYTE_GA_D510UD),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_BELTINO),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_KAHLEE),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_SLIPPY),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_ZORK),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_AURON),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_BRYA),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BUTTERFLY),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_CYAN),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BASEBOARD_DEDEDE_LAPTOP),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_DEDEDE),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_DELTAUR),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_DRALLION),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_EVE),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_FIZZ),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_GLADOS),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_GUYBRUSH),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_HATCH),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_JECHT),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_LINK),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_OCTOPUS),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BASEBOARD_OCTOPUS_LAPTOP),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_POPPY),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_RAMBI),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_REEF),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BASEBOARD_REEF_LAPTOP),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_SARIEN),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_STOUT),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_VOLTEER),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_IBASE_MB899),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_BASKING_RIDGE),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_DCP847SKE),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_DG41WV),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_DG43GT),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_EMERALDLAKE2),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BASEBOARD_GLKRVP_LAPTOP),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_BASEBOARD_GLKRVP),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_JASPERLAKE_RVP_EXT_EC),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_KBLRVP_COMMON),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_KUNIMITSU),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_SHADOWMOUNTAIN),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_STRAGO),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_TGLRVP_UP3),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_TGLRVP_UP4),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_KONTRON_986LCD_M),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ODE_E20XX),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_PORTWELL_M107),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_PROTECTLI_FW2B),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_PROTECTLI_FW4B),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_SAMSUNG_LUMPY),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_SAMSUNG_STUMPY),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_SUPERMICRO_X10SLM_PLUS_F),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_SUPERMICRO_X9SCL),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif IGNORED_IASL_WARNINGS = $(addprefix -vw , $(IASL_WARNINGS_LIST)) define asl_template -- To view, visit https://review.coreboot.org/c/coreboot/+/59880 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28b437194f08232727623009372327fec15215dd Gerrit-Change-Number: 59880 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/common: Rename compare_cse_version() function name
by 9elements QA (Code Review) 04 Dec '21

04 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59689 ) Change subject: soc/intel/common: Rename compare_cse_version() function name ...................................................................... Patch Set 10: Automatic boot test returned (PASS/FAIL/TOTAL): 5 / 4 / 9 FAIL: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/83402 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/83400 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/83399 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/83398 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/83397 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/83396 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/83395 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/83394 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/83393 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/59689 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88a44a3c0ba2ad8a589602a35ea644dab535b287 Gerrit-Change-Number: 59689 Gerrit-PatchSet: 10 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane.chen(a)intel.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Sat, 04 Dec 2021 11:00:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add support for ADL-N PCH
by 9elements QA (Code Review) 04 Dec '21

04 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59752 ) Change subject: soc/intel/alderlake: Add support for ADL-N PCH ...................................................................... Patch Set 10: Automatic boot test returned (PASS/FAIL/TOTAL): 5 / 3 / 8 FAIL: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/83391 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/83389 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/83388 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/83386 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/83385 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/83384 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/83383 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/83382 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/59752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ebbcdcdb1ccc34b80ec71ac3e591fe4ad6b1904 Gerrit-Change-Number: 59752 Gerrit-PatchSet: 10 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 04 Dec 2021 09:20:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfs | tspi: Join hash calculation for verification and measurement
by 9elements QA (Code Review) 04 Dec '21

04 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59681 ) Change subject: cbfs | tspi: Join hash calculation for verification and measurement ...................................................................... Patch Set 4: Automatic boot test returned (PASS/FAIL/TOTAL): 5 / 3 / 8 FAIL: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/83380 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/83378 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/83377 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/83375 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/83374 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/83373 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/83372 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/83371 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/59681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70d7066c6768195077f083c7ffdfa30d9182b2b7 Gerrit-Change-Number: 59681 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 04 Dec 2021 07:53:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/felwinter: Add WiFi SAR table for felwinter
by 9elements QA (Code Review) 04 Dec '21

04 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59718 ) Change subject: mb/google/brya/var/felwinter: Add WiFi SAR table for felwinter ...................................................................... Patch Set 6: Automatic boot test returned (PASS/FAIL/TOTAL): 5 / 4 / 9 FAIL: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/83369 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/83368 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/83367 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/83366 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/83365 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/83364 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/83363 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/83362 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/83361 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/59718 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0de710f4447302ee545a67cbd79373bdd2077637 Gerrit-Change-Number: 59718 Gerrit-PatchSet: 6 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 04 Dec 2021 06:13:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add template for deprecation notices
by David Hendricks (Code Review) 04 Dec '21

04 Dec '21

Attention is currently required from: Patrick Georgi, Martin Roth. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59677 ) Change subject: Documentation: Add template for deprecation notices ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File Documentation/releases/templates.md: https://review.coreboot.org/c/coreboot/+/59677/comment/9250413c_2d06dcdc PS4, Line 25: line out outline -- To view, visit https://review.coreboot.org/c/coreboot/+/59677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2cc4f799804c7d56db572823246c487cd19a726 Gerrit-Change-Number: 59677 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: awokd(a)danwin1210.me Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Branden Waldner <scruffy99(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Sat, 04 Dec 2021 05:24:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Update camera NVM parameters
by 9elements QA (Code Review) 04 Dec '21

04 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58374 ) Change subject: mb/google/brya: Update camera NVM parameters ...................................................................... Patch Set 10: Automatic boot test returned (PASS/FAIL/TOTAL): 4 / 5 / 9 FAIL: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/83356 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/83354 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/83353 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/83352 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/83351 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/83350 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/83349 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/83348 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/83347 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/58374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib2366ba4c8bb70d8cc82e64ca585b118a96260c0 Gerrit-Change-Number: 58374 Gerrit-PatchSet: 10 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: ShawnX Tu <shawnx.tu(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: kiran2.kumar(a)intel.com Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Bernardo Salvador Perez Priego <bernardospp(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 04 Dec 2021 04:38:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update gpio override
by Shon Wang (Code Review) 04 Dec '21

04 Dec '21

Attention is currently required from: Kevin Chiu, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, Wisley Chen. Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59305 ) Change subject: mb/google/brya/var/vell: update gpio override ...................................................................... Patch Set 15: (1 comment) File src/mainboard/google/brya/variants/vell/gpio.c: https://review.coreboot.org/c/coreboot/+/59305/comment/433b9545_aae055c9 PS14, Line 115: PAD_CFG_GPO(GPP_D2, 1, DEEP), > For proper power sequencing of the SSD, you will likely need to enable power for SSD here as well, i […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0 Gerrit-Change-Number: 59305 Gerrit-PatchSet: 15 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 04 Dec 2021 04:05:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update gpio override
by Shon Wang (Code Review) 04 Dec '21

04 Dec '21

Attention is currently required from: Kevin Chiu, Paul Menzel, Nick Vaccaro, Wisley Chen, Shon Wang. Shon Wang has uploaded a new patch set (#15) to the change originally created by Kevin Chiu. ( https://review.coreboot.org/c/coreboot/+/59305 ) Change subject: mb/google/brya/var/vell: update gpio override ...................................................................... mb/google/brya/var/vell: update gpio override Configure GPIOs according to schematics Update initial gpio configuration for redrix BUG=b:205908918 TEST=emerge-brya coreboot Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0 Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- A src/mainboard/google/brya/variants/vell/Makefile.inc A src/mainboard/google/brya/variants/vell/gpio.c 2 files changed, 188 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/59305/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/59305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0 Gerrit-Change-Number: 59305 Gerrit-PatchSet: 15 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021