Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59853 )
Change subject: soc/intel/tigerlake: Define soc_get_pcie_rp_type
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/59853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f7d3f2fc12ae2b53604cd8f8b694a7674c3620
Gerrit-Change-Number: 59853
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sat, 04 Dec 2021 12:05:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Patrick Georgi, Tim Wawrzynczak, Rob Barnes, Jack Rosenthal.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59875 )
Change subject: mb/google/hatch: Remove stryke mainboard
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/59875
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d91fbd4ba0abe0cf599e8e75f04398ef9ff5222
Gerrit-Change-Number: 59875
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Jack Rosenthal <jrosenth(a)google.com>
Gerrit-Comment-Date: Sat, 04 Dec 2021 12:04:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Tim Wawrzynczak, Nick Vaccaro, Wisley Chen, Shon Wang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59305 )
Change subject: mb/google/brya/var/vell: update gpio override
......................................................................
Patch Set 15:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59305/comment/3afb82fd_fabdf067
PS15, Line 9: Configure GPIOs according to schematics
: Update initial gpio configuration for redrix
Please format it as a list.
https://review.coreboot.org/c/coreboot/+/59305/comment/5e5d8df5_b4517f7b
PS15, Line 10: redrix
What is retrix?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59305
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0
Gerrit-Change-Number: 59305
Gerrit-PatchSet: 15
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Sat, 04 Dec 2021 11:59:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: HAOUAS Elyes.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59174 )
Change subject: crossgcc: Upgrade acpica to 20210930 version
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59174/comment/1a7449df_2c0bb255
PS4, Line 7: crossgcc: Upgrade acpica to 20210930 version
Maybe:
> Update acpica from 20210331 to 20210930
Patchset:
PS4:
Does it produce new warnings, which CB:59880 disables?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59174
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a03b74e95f910b50aa2f7ce502b1e9ad5b6df37
Gerrit-Change-Number: 59174
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 04 Dec 2021 11:50:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: HAOUAS Elyes.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59400 )
Change subject: crossgcc: Upgrade llvm to 13.0.0 version
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59400/comment/8df46fb3_dc403847
PS3, Line 7: crossgcc: Upgrade llvm to 13.0.0 version
Maybe:
> Upgrade LLVM/clang from 12.0.0 to 13.0.0
https://review.coreboot.org/c/coreboot/+/59400/comment/8b662fde_135a58d4
PS3, Line 8:
Did you build/run test one board?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59400
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c550d3528a5b1c891b318c08ecfba3a9255e69c
Gerrit-Change-Number: 59400
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 04 Dec 2021 11:48:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: HAOUAS Elyes.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59399 )
Change subject: crossgcc: Upgrade CMake to 3.22.0 version
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/59399
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4272f72dd6ed686dbad5615a0ab44c8c632b5930
Gerrit-Change-Number: 59399
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 04 Dec 2021 11:47:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, HAOUAS Elyes.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59880 )
Change subject: Makefile.inc: Ignore IASL's "Missing dependency" warning
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59880/comment/5fff273d_47c7103a
PS1, Line 16:
Do you have a list of devices with this warning?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59880
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28b437194f08232727623009372327fec15215dd
Gerrit-Change-Number: 59880
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 04 Dec 2021 11:47:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment