HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59880 )
Change subject: Makefile.inc: Ignore IASL's "Missing dependency" warning ......................................................................
Makefile.inc: Ignore IASL's "Missing dependency" warning
IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects: 1) If _PRS is present, must have _CRS and _SRS 2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS) 3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS requires _CRS and _SRS) 4) If _SRS is present, probably should have a _DIS (Remark only) IASL will issue a warning for each missing dependency. Ignore this warnings for existing ASL code.
Change-Id: I28b437194f08232727623009372327fec15215dd Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 219 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/59880/1
diff --git a/Makefile.inc b/Makefile.inc index 971a56c..5dcc40d 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -263,9 +263,228 @@ # Redundant offset remarks are not useful in any way and are masking useful # ones that might indicate an issue so it is better to hide them. REDUNDANT_OFFSET_REMARK = 2158 +# IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects: +# 1) If _PRS is present, must have _CRS and _SRS +# 2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS) +# 3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS requires _CRS and _SRS) +# 4) If _SRS is present, probably should have a _DIS (Remark only) +# A warning will be issued for each of these cases. +# For existing ASL code, ignore this warnings +IASL_MISSING_DEPENDENCY = 3141
IASL_WARNINGS_LIST = $(EMPTY_RESOURCE_TEMPLATE_WARNING) $(REDUNDANT_OFFSET_REMARK)
+# Please fix your ASL code and remove dedicated lines below. +ifeq ($(CONFIG_BOARD_ACER_G43T_AM3),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ASROCK_H81M_HDS),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ASUS_AM1I_A),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ASUS_P5G41T_M_LX),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ASUS_P5QPL_AM),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ASUS_P8H61_M_LX),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_BIOSTAR_AM1ML),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_BOARD_INTEL_ADLRVP_COMMON),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_DELL_OPTIPLEX_9010),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_DELL_OPTIPLEX_9010_SFF),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FACEBOOK_FBG1701),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FACEBOOK_MONOLITH),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FOXCONN_D41S),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FOXCONN_G41M),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FOXCONN_G41M_),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_FOXCONN_G41S_K),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GIGABYTE_GA_D510UD),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_BELTINO),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_KAHLEE),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_SLIPPY),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_ZORK),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_AURON),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_BRYA),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BUTTERFLY),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_CYAN),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BASEBOARD_DEDEDE_LAPTOP),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_DEDEDE),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_DELTAUR),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_DRALLION),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_EVE),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_FIZZ),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_GLADOS),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_GUYBRUSH),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_HATCH),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_JECHT),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_LINK),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_OCTOPUS),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BASEBOARD_OCTOPUS_LAPTOP),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_POPPY),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_RAMBI),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_REEF),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BASEBOARD_REEF_LAPTOP),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_SARIEN),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_STOUT),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_VOLTEER),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_IBASE_MB899),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_BASKING_RIDGE),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_DCP847SKE),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_DG41WV),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_DG43GT),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_EMERALDLAKE2),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BASEBOARD_GLKRVP_LAPTOP),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_BASEBOARD_GLKRVP),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_JASPERLAKE_RVP_EXT_EC),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_KBLRVP_COMMON),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_KUNIMITSU),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_SHADOWMOUNTAIN),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_STRAGO),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_TGLRVP_UP3),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_INTEL_TGLRVP_UP4),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_KONTRON_986LCD_M),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_ODE_E20XX),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_PORTWELL_M107),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_PROTECTLI_FW2B),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_PROTECTLI_FW4B),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_SAMSUNG_LUMPY),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_SAMSUNG_STUMPY),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_SUPERMICRO_X10SLM_PLUS_F),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif +ifeq ($(CONFIG_BOARD_SUPERMICRO_X9SCL),y) +IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +endif IGNORED_IASL_WARNINGS = $(addprefix -vw , $(IASL_WARNINGS_LIST))
define asl_template
-
HAOUAS Elyes (Code Review)