coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: soc/intel/common/block/pcie/rtd3: Add ModPHY power gate support for RTD3
by Cliff Huang (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59855 ) Change subject: soc/intel/common/block/pcie/rtd3: Add ModPHY power gate support for RTD3 ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/common/block/pcie/rtd3/rtd3.c: https://review.coreboot.org/c/coreboot/+/59855/comment/b763279f_2216a327 PS2, Line 238: static bool mutex_created; initialize to false, please. -- To view, visit https://review.coreboot.org/c/coreboot/+/59855 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19cb05a74acfa3ded7867b1cac32c161a83b4f7d Gerrit-Change-Number: 59855 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 06 Dec 2021 23:04:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: Fix offset calculation for aligned files
by Tim Wawrzynczak (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Julius Werner, Tim Wawrzynczak. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59877 ) Change subject: cbfstool: Fix offset calculation for aligned files ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File util/cbfstool/cbfstool.c: https://review.coreboot.org/c/coreboot/+/59877/comment/49cddeaa_9e0c39c3 PS2, Line 1085: *offset; > I don't really understand this x86-specific address space stuff well, so I hope someone can correct […] As far as I understand too, there are only the 2 address spaces at play here, host and flash and basically yeah the host address space is for convenience when dealing with addresses where what matters in the end is the resulting memory-mapped address on x86. and I agree that this looks like it is preserving existing behavior. -- To view, visit https://review.coreboot.org/c/coreboot/+/59877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia49a585988f7a74944a6630b77b3ebd79b3a9897 Gerrit-Change-Number: 59877 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Mon, 06 Dec 2021 22:44:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Update to NixOS 21.11
by Michael Niewöhner (Code Review) 06 Dec '21

06 Dec '21

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59881 ) Change subject: util/liveiso: Update to NixOS 21.11 ...................................................................... util/liveiso: Update to NixOS 21.11 Update configs so that they work with NixOS 21.11. Drop `iasl` package since it was replaced with `acpica-tools`. Change-Id: Icb9a382b83b3b3e55126bb0bb508659d11497a05 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59881 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M util/liveiso/common.nix 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved diff --git a/util/liveiso/common.nix b/util/liveiso/common.nix index 3961aba..2ed4af5 100644 --- a/util/liveiso/common.nix +++ b/util/liveiso/common.nix @@ -8,7 +8,7 @@ <nixpkgs/nixos/modules/installer/cd-dvd/iso-image.nix> ]; - system.stateVersion = "21.05"; + system.stateVersion = "21.11"; isoImage = { makeEfiBootable = true; @@ -127,7 +127,6 @@ hexdump htop i2c-tools - iasl intel-gpu-tools inxi iotools -- To view, visit https://review.coreboot.org/c/coreboot/+/59881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb9a382b83b3b3e55126bb0bb508659d11497a05 Gerrit-Change-Number: 59881 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: util/liveiso: Update to NixOS 21.11
by Michael Niewöhner (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59881 ) Change subject: util/liveiso: Update to NixOS 21.11 ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb9a382b83b3b3e55126bb0bb508659d11497a05 Gerrit-Change-Number: 59881 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Mon, 06 Dec 2021 22:36:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Update to NixOS 21.11
by Felix Singer (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59881 ) Change subject: util/liveiso: Update to NixOS 21.11 ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59881/comment/420c3b13_1e3ffe20 PS4, Line 9: so that they work > why didn't it work before? was there a conflict? were the packages renamed? One thing is the iasl package and the other is the variable `system.stateVersion`. Depending on its value, the system might be configured differently. https://review.coreboot.org/c/coreboot/+/59881/comment/6ccf057b_235ace69 PS4, Line 10: is > ah, probably that is the reason? then `was` Yes https://review.coreboot.org/c/coreboot/+/59881/comment/81c09076_0b061cd3 PS4, Line 10: acpica-tools > nit: `acpica-tools` Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb9a382b83b3b3e55126bb0bb508659d11497a05 Gerrit-Change-Number: 59881 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 06 Dec 2021 22:28:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Update to NixOS 21.11
by Felix Singer (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59881 to look at the new patch set (#5). Change subject: util/liveiso: Update to NixOS 21.11 ...................................................................... util/liveiso: Update to NixOS 21.11 Update configs so that they work with NixOS 21.11. Drop `iasl` package since it was replaced with `acpica-tools`. Change-Id: Icb9a382b83b3b3e55126bb0bb508659d11497a05 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/liveiso/common.nix 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/59881/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/59881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb9a382b83b3b3e55126bb0bb508659d11497a05 Gerrit-Change-Number: 59881 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/liveiso: Update to NixOS 21.11
by Michael Niewöhner (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59881 ) Change subject: util/liveiso: Update to NixOS 21.11 ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59881/comment/336b3809_dca03669 PS4, Line 10: is ah, probably that is the reason? then `was` -- To view, visit https://review.coreboot.org/c/coreboot/+/59881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb9a382b83b3b3e55126bb0bb508659d11497a05 Gerrit-Change-Number: 59881 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Mon, 06 Dec 2021 22:17:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Update to NixOS 21.11
by Michael Niewöhner (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59881 ) Change subject: util/liveiso: Update to NixOS 21.11 ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59881/comment/3c5f1177_42e079a5 PS4, Line 9: so that they work why didn't it work before? was there a conflict? were the packages renamed? https://review.coreboot.org/c/coreboot/+/59881/comment/d939db69_ad63b050 PS4, Line 10: acpica-tools nit: `acpica-tools` -- To view, visit https://review.coreboot.org/c/coreboot/+/59881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb9a382b83b3b3e55126bb0bb508659d11497a05 Gerrit-Change-Number: 59881 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Mon, 06 Dec 2021 22:16:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: Fix offset calculation for aligned files
by Raul Rangel (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Julius Werner, Tim Wawrzynczak. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59877 ) Change subject: cbfstool: Fix offset calculation for aligned files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia49a585988f7a74944a6630b77b3ebd79b3a9897 Gerrit-Change-Number: 59877 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Mon, 06 Dec 2021 22:05:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: Fix offset calculation for aligned files
by Julius Werner (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Raul Rangel, Tim Wawrzynczak. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59877 ) Change subject: cbfstool: Fix offset calculation for aligned files ...................................................................... Patch Set 2: (2 comments) File util/cbfstool/cbfstool.c: https://review.coreboot.org/c/coreboot/+/59877/comment/fc1944db_cc9a909b PS2, Line 1085: *offset; > Do we also need to convert the address here? I don't really understand this x86-specific address space stuff well, so I hope someone can correct me if I'm wrong... but as far as I understand, there's only the "host" address space and the "flash" address space... so if *offset is not in the host address space that means it already is in the flash address space and good to go as is. I think in practice, do_cbfs_locate() always generates offsets in the flash address space anyway, so this is only here for convenience with the --base-address parameter so people can pass -B 0xfffff000 instead of -B 0x7ff000. Anyway, I was just trying to preserve the previous behavior here which I think this does. https://review.coreboot.org/c/coreboot/+/59877/comment/af5466c3_8fe46c32 PS2, Line 1299: param.filename, : param.name, : param.headeroffset, > If we are just using the param global, do we even need these parameters? Uff... yes... no... I don't know. I mean, in general passing everything between functions in a global is an antipattern and should be avoided. But on the other hand, do_cbfs_locate() is already using most of the stuff from `param` so it seems silly not to do it for this as well. And if you both pass something by value and have it in the global struct, that's also dangerous because then they may go out of sync (e.g. here, before this patch, param.type is actually not set to SELF for cbfstool add-payload and if something checks it it would give the wrong value). Maybe it makes sense to get rid of the other three parameters here and just use `param` everywhere for consistency. But I don't directly need that for what I'm trying to do here so I don't want to do it in this patch... like Patrick said, it's already getting a bit too big. -- To view, visit https://review.coreboot.org/c/coreboot/+/59877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia49a585988f7a74944a6630b77b3ebd79b3a9897 Gerrit-Change-Number: 59877 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Mon, 06 Dec 2021 21:47:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021