Attention is currently required from: Ravi kumar, Shelley Chen, Sudheer Amrabadi, mturney mturney.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57025 )
Change subject: HACK: Herobrine: Reinit TPM INT gpio after qclib executes
......................................................................
Patch Set 27:
(2 comments)
File src/soc/qualcomm/common/qclib.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132435):
https://review.coreboot.org/c/coreboot/+/57025/comment/12bc06fb_11f76d7c
PS27, Line 220: mainboard_blob_fix();
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132435):
https://review.coreboot.org/c/coreboot/+/57025/comment/e9c8f79a_1eda5009
PS27, Line 220: mainboard_blob_fix();
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/57025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c43d120ebb49800c82aec263ff8c215b60c5201
Gerrit-Change-Number: 57025
Gerrit-PatchSet: 27
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Fri, 05 Nov 2021 20:00:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ravi kumar.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58545 )
Change subject: sc7280: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot.
......................................................................
Patch Set 4:
(1 comment)
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132431):
https://review.coreboot.org/c/coreboot/+/58545/comment/cc4a39f3_63c146c7
PS4, Line 27: if (soc_modem_carve_out(&start, &end))
that open brace { should be on the previous line
--
To view, visit https://review.coreboot.org/c/coreboot/+/58545
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56bfb210606b08893ff71dd1b6679f1ec102ec95
Gerrit-Change-Number: 58545
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Comment-Date: Fri, 05 Nov 2021 19:46:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Paul Menzel, Marvin Drees.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/edk2/+/58630 )
Change subject: UefiPayloadPkg: Increase FV size to 8MB
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/edk2/+/58630
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: edk2
Gerrit-Branch: coreboot-stable202108
Gerrit-Change-Id: I6b757f73fe4e90282b4bfb84469545ab1af9d1bb
Gerrit-Change-Number: 58630
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Comment-Date: Fri, 05 Nov 2021 19:45:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Johnny Lin, Christian Walter, Paul Menzel.
Hello Johnny Lin, Christian Walter, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58979
to look at the new patch set (#2).
Change subject: doc/mb/ocp: update Delta Lake documentation
......................................................................
doc/mb/ocp: update Delta Lake documentation
Update Delta Lake document following the publish of OCP blog
and the Wiwynn press release.
Signed-off-by: Jonathan Zhang <jonzhang(a)fb.com>
Change-Id: I3eaa765bf9918988b4b5cb01e8607a5c27b9bd17
---
M Documentation/mainboard/ocp/deltalake.md
1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/58979/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3eaa765bf9918988b4b5cb01e8607a5c27b9bd17
Gerrit-Change-Number: 58979
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58979 )
Change subject: doc/mb/ocp: update Delta Lake documentation
......................................................................
doc/mb/ocp: update Delta Lake documentation
Signed-off-by: Jonathan Zhang <jonzhang(a)fb.com>
Change-Id: I3eaa765bf9918988b4b5cb01e8607a5c27b9bd17
---
M Documentation/mainboard/ocp/deltalake.md
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/58979/1
diff --git a/Documentation/mainboard/ocp/deltalake.md b/Documentation/mainboard/ocp/deltalake.md
index 8906ad8..a4a413b 100644
--- a/Documentation/mainboard/ocp/deltalake.md
+++ b/Documentation/mainboard/ocp/deltalake.md
@@ -7,7 +7,14 @@
OCP Delta Lake server platform is a component of multi-host server system
Yosemite-V3. Both [Delta Lake server design spec] and [Yosemite-V3 design
-spec] were contributed to [OCP].
+spec] were [OCP] accepted.
+
+On the other hand, Wiwynn's Yosemite-V3 system and Delta Lake server product
+along with its OSF implementation, which is based on FSP/coreboot/LinuxBoot
+stack, was [OCP] accepted; For details, check:
+- [The OCP blog]
+- [The Wiwynn Press Release]
+- [The Wiwynn's Yosemite-V3 product in OCP market place]
Delta Lake server is a single socket Cooper Lake Scalable Processor (CPX-SP) server.
Intel Cooper Lake Scalable Processor was launched in Q2 2020.
@@ -15,7 +22,7 @@
Yosemite-V3 has multiple configurations. Depending on configurations, it may
host up to 4 Delta Lake servers (blades) in one sled.
-The Yosemite-V3 system is in mass production. Facebook, Intel and partners
+The Yosemite-V3 system is in mass production. Meta, Intel and partners
jointly develop Open System Firmware (OSF) solution on Delta Lake as an alternative
solution. The OSF solution is based on FSP/coreboot/LinuxBoot stack. The
OSF solution reached production quality for some use cases in July, 2021.
@@ -187,6 +194,9 @@
[OCP]: https://www.opencompute.org
[Delta Lake server design spec]: https://www.opencompute.org/documents/delta-lake-1s-server-design-specifica…
[Yosemite-V3 design spec]: https://www.opencompute.org/documents/ocp-yosemite-v3-platform-design-speci…
+[The OCP blog]: https://www.opencompute.org/blog/open-system-firmware-for-ocp-server-deltal…
+[The Wiwynn Press Release]: https://www.prnewswire.com/news-releases/wiwynn-successfully-implemented-op…
+[The Wiwynn's Yosemite-V3 product in OCP market place]: https://www.opencompute.org/products/423/wiwynn-yosemite-v3-server
[osf-builder]: https://github.com/facebookincubator/osf-builder
[OCP virtual summit 2020]: https://www.opencompute.org/summit/virtual-summit/schedule
[flashrom]: https://flashrom.org/Flashrom
--
To view, visit https://review.coreboot.org/c/coreboot/+/58979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3eaa765bf9918988b4b5cb01e8607a5c27b9bd17
Gerrit-Change-Number: 58979
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-MessageType: newchange
Attention is currently required from: Ravi kumar, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: Add CPUCP firmware support
......................................................................
Patch Set 86:
(2 comments)
File src/soc/qualcomm/sc7280/include/soc/cpucp.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132421):
https://review.coreboot.org/c/coreboot/+/49768/comment/fc768866_58b1577f
PS86, Line 6: #define EPSSTOP_EPSS_TOP (void *)0x18598000
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132421):
https://review.coreboot.org/c/coreboot/+/49768/comment/bf9800aa_97040f36
PS86, Line 7: #define EPSSFAST_BASE_ADDR (void *)0x18580000
Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/49768
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idac22c8cb231658616999bc577bdf49f9aa7ae74
Gerrit-Change-Number: 49768
Gerrit-PatchSet: 86
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 05 Nov 2021 19:14:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58868 )
Change subject: Documentation/releases/4.15: Add more System76 boards
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/58868
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0353b28c1df3da8be961cb43225dcf9e30b47d16
Gerrit-Change-Number: 58868
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Comment-Date: Fri, 05 Nov 2021 18:26:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment