coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: Documentation/releases: Update 4.15 release notes
by Jason Glenesk (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Martin Roth, Felix Held. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58974 ) Change subject: Documentation/releases: Update 4.15 release notes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please help to review this update. -- To view, visit https://review.coreboot.org/c/coreboot/+/58974 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4d47456cce38e7ec4329f8cb839167017c7e26b Gerrit-Change-Number: 58974 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 05 Nov 2021 18:22:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/releases: Update 4.15 release notes
by Jason Glenesk (Code Review) 05 Nov '21

05 Nov '21

Jason Glenesk has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58974 ) Change subject: Documentation/releases: Update 4.15 release notes ...................................................................... Documentation/releases: Update 4.15 release notes Update details for upcoming 4.15 release Change-Id: Ie4d47456cce38e7ec4329f8cb839167017c7e26b Signed-off-by: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> --- M Documentation/releases/coreboot-4.15-relnotes.md 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/58974/1 diff --git a/Documentation/releases/coreboot-4.15-relnotes.md b/Documentation/releases/coreboot-4.15-relnotes.md index 97ed37c..feb77ef 100644 --- a/Documentation/releases/coreboot-4.15-relnotes.md +++ b/Documentation/releases/coreboot-4.15-relnotes.md @@ -1,18 +1,22 @@ Upcoming release - coreboot 4.15 ================================ -The 4.15 release is planned for November 1st, 2021. +The 4.15 release is planned for November 5th, 2021. -Since 4.14 there have been more than 2448 new commits by more than 219 developers. +Since 4.14 there have been more than 2597 new commits by more than 219 developers. Of these, over 73 contributed to coreboot for the first time. Welcome to the project! - - Thank you to all the developers who continue to make coreboot the great open source firmware project that it is. +Important Announcement +---------------------- +We are going to be changing the cadence from every 6 months, to every 3 months. +That means the 4.16 release will be coming in February, 2022. + + New mainboards -------------- * Asus p8h61-m_pro_cm6630 -- To view, visit https://review.coreboot.org/c/coreboot/+/58974 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4d47456cce38e7ec4329f8cb839167017c7e26b Gerrit-Change-Number: 58974 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: lib/thread: Start stopwatch after printk
by Felix Held (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Raul Rangel, Rob Barnes. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58960 ) Change subject: lib/thread: Start stopwatch after printk ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/58960 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib48e37c1b2cb462d634141bf767673936aa2dd26 Gerrit-Change-Number: 58960 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Fri, 05 Nov 2021 18:16:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [NOTFORMERGE] soc/amd/picasso: test case for mpinit-problem on mandolin
by Felix Held (Code Review) 05 Nov '21

05 Nov '21

Felix Held has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/56355 ) Change subject: [NOTFORMERGE] soc/amd/picasso: test case for mpinit-problem on mandolin ...................................................................... Abandoned CB:58859 handles mp init failure instead of ignoring the failure and then failing much later with no too specific symptoms -- To view, visit https://review.coreboot.org/c/coreboot/+/56355 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48a3d820fcf9c26649e2385ea0caaef7d23ca572 Gerrit-Change-Number: 56355 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/amd/picasso/include/southbridge: drop unused aoac_devs struct
by Raul Rangel (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58972 ) Change subject: soc/amd/picasso/include/southbridge: drop unused aoac_devs struct ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58972 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida8d767a5b56bdf59747362ddf68372436573895 Gerrit-Change-Number: 58972 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 05 Nov 2021 17:00:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/picasso/include/southbridge: drop unused aoac_devs struct
by Felix Held (Code Review) 05 Nov '21

05 Nov '21

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58972 ) Change subject: soc/amd/picasso/include/southbridge: drop unused aoac_devs struct ...................................................................... soc/amd/picasso/include/southbridge: drop unused aoac_devs struct Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ida8d767a5b56bdf59747362ddf68372436573895 --- M src/soc/amd/picasso/include/soc/southbridge.h 1 file changed, 0 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/58972/1 diff --git a/src/soc/amd/picasso/include/soc/southbridge.h b/src/soc/amd/picasso/include/soc/southbridge.h index 2cc1c62..f547f86 100644 --- a/src/soc/amd/picasso/include/soc/southbridge.h +++ b/src/soc/amd/picasso/include/soc/southbridge.h @@ -128,22 +128,6 @@ #define SATA_CAPABILITIES_REG 0xfc #define SATA_CAPABILITY_SPM BIT(12) -typedef struct aoac_devs { - unsigned int :7; - unsigned int ic2e:1; /* 7: I2C2 */ - unsigned int ic3e:1; /* 8: I2C3 */ - unsigned int ic4e:1; /* 9: I2C4 */ - unsigned int :1; - unsigned int ut0e:1; /* 11: UART0 */ - unsigned int ut1e:1; /* 12: UART1 */ - unsigned int :3; - unsigned int ut2e:1; /* 16: UART2 */ - unsigned int :9; - unsigned int ut3e:1; /* 26: UART3 */ - unsigned int espi:1; /* 27: ESPI */ - unsigned int :4; -} __packed aoac_devs_t; - void fch_pre_init(void); void fch_early_init(void); void fch_init(void *chip_info); -- To view, visit https://review.coreboot.org/c/coreboot/+/58972 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida8d767a5b56bdf59747362ddf68372436573895 Gerrit-Change-Number: 58972 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/cbfstool/flashmap/fmap.c: fix fmaptool endianness bugs on BE
by Sergii Dmytruk (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Idwer Vollering, Stefan Reinauer, Julius Werner, Arthur Heymans, Krystian Hebel, Timothy Pearson. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55039 ) Change subject: util/cbfstool/flashmap/fmap.c: fix fmaptool endianness bugs on BE ...................................................................... Patch Set 9: (2 comments) Patchset: PS9: Added -D_DEFAULT_SOURCE to util/ifdtool/Makefile.inc instead of defining it in code. File util/cbfstool/flashmap/fmap.c: https://review.coreboot.org/c/coreboot/+/55039/comment/58ea3cd6_4b42df56 PS7, Line 7: * It is required for endianness converting functions. > Then why not add it to the ifdtool Makefile? I think that would be more appropriate than this. Moved it there. -- To view, visit https://review.coreboot.org/c/coreboot/+/55039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia88c0625cefa1e594ac1849271a71c3aacc8ce78 Gerrit-Change-Number: 55039 Gerrit-PatchSet: 9 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Comment-Date: Fri, 05 Nov 2021 16:30:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool/flashmap/fmap.c: fix fmaptool endianness bugs on BE
by Sergii Dmytruk (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Idwer Vollering, Arthur Heymans, Krystian Hebel, Timothy Pearson, Sergii Dmytruk. Sergii Dmytruk has uploaded a new patch set (#9) to the change originally created by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/55039 ) Change subject: util/cbfstool/flashmap/fmap.c: fix fmaptool endianness bugs on BE ...................................................................... util/cbfstool/flashmap/fmap.c: fix fmaptool endianness bugs on BE This patch makes all accesses to the FMAP fields explicitly little endian. It fixes issue where build on BE host produced different binary image than on LE. Signed-off-by: Marek Kasiewicz <marek.kasiewicz(a)3mdeb.com> Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> Change-Id: Ia88c0625cefa1e594ac1849271a71c3aacc8ce78 --- M util/cbfstool/flashmap/fmap.c M util/ifdtool/Makefile.inc 2 files changed, 34 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/55039/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/55039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia88c0625cefa1e594ac1849271a71c3aacc8ce78 Gerrit-Change-Number: 55039 Gerrit-PatchSet: 9 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/*/include/smi: move NUMBER_SMITYPES definition to the top
by Felix Held (Code Review) 05 Nov '21

05 Nov '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58953 ) Change subject: soc/amd/*/include/smi: move NUMBER_SMITYPES definition to the top ...................................................................... soc/amd/*/include/smi: move NUMBER_SMITYPES definition to the top Since all other defines for the number of certain things are at the top of the file, move NUMBER_SMITYPES there as well to keep things consistent. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Idfb599531d6cc382ab258bd1eae89e7b35fa9e79 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58953 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> --- M src/soc/amd/cezanne/include/soc/smi.h M src/soc/amd/picasso/include/soc/smi.h M src/soc/amd/stoneyridge/include/soc/smi.h 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved diff --git a/src/soc/amd/cezanne/include/soc/smi.h b/src/soc/amd/cezanne/include/soc/smi.h index f0948bb..aad4123 100644 --- a/src/soc/amd/cezanne/include/soc/smi.h +++ b/src/soc/amd/cezanne/include/soc/smi.h @@ -8,6 +8,7 @@ #define SMI_GEVENTS 24 #define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32 +#define NUMBER_SMITYPES 160 #define SMI_EVENT_STATUS 0x0 #define SMI_EVENT_ENABLE 0x04 @@ -138,7 +139,7 @@ /* 153-155 Reserved */ #define SMITYPE_CFGTRAP0 156 /* 157-159 Reserved */ -#define NUMBER_SMITYPES 160 + #define TYPE_TO_MASK(X) (1 << (X) % 32) #define SMI_REG_SMISTS0 0x80 diff --git a/src/soc/amd/picasso/include/soc/smi.h b/src/soc/amd/picasso/include/soc/smi.h index 8256b21..dba3bea 100644 --- a/src/soc/amd/picasso/include/soc/smi.h +++ b/src/soc/amd/picasso/include/soc/smi.h @@ -8,6 +8,7 @@ #define SMI_GEVENTS 24 #define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32 +#define NUMBER_SMITYPES 160 #define SMI_EVENT_STATUS 0x0 #define SMI_EVENT_ENABLE 0x04 @@ -140,7 +141,7 @@ /* 153-155 Reserved */ #define SMITYPE_CFGTRAP0 156 /* 157-159 Reserved */ -#define NUMBER_SMITYPES 160 + #define TYPE_TO_MASK(X) (1 << (X) % 32) #define SMI_REG_SMISTS0 0x80 diff --git a/src/soc/amd/stoneyridge/include/soc/smi.h b/src/soc/amd/stoneyridge/include/soc/smi.h index 0e0bc37..3ce41df 100644 --- a/src/soc/amd/stoneyridge/include/soc/smi.h +++ b/src/soc/amd/stoneyridge/include/soc/smi.h @@ -6,6 +6,7 @@ #define SMI_GEVENTS 24 #define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32 +#define NUMBER_SMITYPES 160 #define SMI_EVENT_STATUS 0x0 #define SMI_EVENT_ENABLE 0x04 @@ -138,7 +139,7 @@ /* 153-155 Reserved */ #define SMITYPE_CFGTRAP0 156 /* 157-159 Reserved */ -#define NUMBER_SMITYPES 160 + #define TYPE_TO_MASK(X) (1 << (X) % 32) #define SMI_REG_SMISTS0 0x80 -- To view, visit https://review.coreboot.org/c/coreboot/+/58953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idfb599531d6cc382ab258bd1eae89e7b35fa9e79 Gerrit-Change-Number: 58953 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/amd/*/include/smi: fix off-by-one in SCIMAPS defines
by Felix Held (Code Review) 05 Nov '21

05 Nov '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58952 ) Change subject: soc/amd/*/include/smi: fix off-by-one in SCIMAPS defines ...................................................................... soc/amd/*/include/smi: fix off-by-one in SCIMAPS defines SCIMAPS is the total number of SCI to GEVENT mappings. configure_scimap returns early when the scimap is greater or equal than SCIMAPS, so for SMITYPE_ACDC_TIMER it returned early without doing what was expected from it to do despite that being a valid value, so fix this off-by-one. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ibaf8c5618ddbf0b8d4cd612a7f1347d8562bbfcb Reviewed-on: https://review.coreboot.org/c/coreboot/+/58952 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> --- M src/soc/amd/cezanne/include/soc/smi.h M src/soc/amd/picasso/include/soc/smi.h M src/soc/amd/stoneyridge/include/soc/smi.h 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved diff --git a/src/soc/amd/cezanne/include/soc/smi.h b/src/soc/amd/cezanne/include/soc/smi.h index dc299a5..f0948bb 100644 --- a/src/soc/amd/cezanne/include/soc/smi.h +++ b/src/soc/amd/cezanne/include/soc/smi.h @@ -6,7 +6,7 @@ #include <types.h> #define SMI_GEVENTS 24 -#define SCIMAPS 58 +#define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32 #define SMI_EVENT_STATUS 0x0 diff --git a/src/soc/amd/picasso/include/soc/smi.h b/src/soc/amd/picasso/include/soc/smi.h index e86809e..8256b21 100644 --- a/src/soc/amd/picasso/include/soc/smi.h +++ b/src/soc/amd/picasso/include/soc/smi.h @@ -6,7 +6,7 @@ #include <types.h> #define SMI_GEVENTS 24 -#define SCIMAPS 58 +#define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32 #define SMI_EVENT_STATUS 0x0 diff --git a/src/soc/amd/stoneyridge/include/soc/smi.h b/src/soc/amd/stoneyridge/include/soc/smi.h index 6162475..0e0bc37 100644 --- a/src/soc/amd/stoneyridge/include/soc/smi.h +++ b/src/soc/amd/stoneyridge/include/soc/smi.h @@ -4,7 +4,7 @@ #define AMD_STONEYRIDGE_SMI_H #define SMI_GEVENTS 24 -#define SCIMAPS 58 +#define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32 #define SMI_EVENT_STATUS 0x0 -- To view, visit https://review.coreboot.org/c/coreboot/+/58952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibaf8c5618ddbf0b8d4cd612a7f1347d8562bbfcb Gerrit-Change-Number: 58952 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021