Attention is currently required from: Mario Scheithauer.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58112 )
Change subject: mb/siemens/mc_ehl2: Move RTC RX6110SA from SMBus to I2C2
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58112
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I679c6397fa0d213a25eebaf8a9e0bda9941acd26
Gerrit-Change-Number: 58112
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Comment-Date: Thu, 07 Oct 2021 04:37:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Mario Scheithauer.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58111 )
Change subject: mb/siemens/mc_ehl2: Set the suitable SPD data
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58111/comment/98fcb63a_2068b88d
PS1, Line 9: On this mainboard are Micron MT53D512M32D2NP modules. Since there are
: other DRAM modules on mc_ehl1, the SPD data file must be adjusted here
: accordingly.
We do not use the traditional DRMA modules here but have memory down with different memory chips. Maybe we should adapt the wording to avoid confusions?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb25f418952f0c96117140863d0d9c897d814ac5
Gerrit-Change-Number: 58111
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Comment-Date: Thu, 07 Oct 2021 04:35:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Sridhar Siricilla, Paul Menzel, Patrick Rudolph.
Ravindra has uploaded a new patch set (#3) to the change originally created by Sridhar Siricilla. ( https://review.coreboot.org/c/coreboot/+/55363 )
Change subject: soc/intel/common: Add HECI Reset flow in the CSE driver
......................................................................
soc/intel/common: Add HECI Reset flow in the CSE driver
The patch adds HECI Reset flow in the CSE driver. This is required as part
of the HECI Interface initialization in order to put the host and CSE into
a known good state for communication. This change is required to send
HECI commands before DRAM Init.
TEST=Run 50 cold reset cycles on Brya
Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Change-Id: Ie078beaa33c6a35ae8f5f460d4354766aa710fba
---
M src/soc/intel/common/block/cse/cse.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/55363/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/55363
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie078beaa33c6a35ae8f5f460d4354766aa710fba
Gerrit-Change-Number: 55363
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hou-hsun Lee, Kane Chen.
Ryan Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58104 )
Change subject: mb/google/brya: Add PsysPmax setting to 145W
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58104/comment/b6798129_0f2f9d2a
PS1, Line 13: Ensure
> ensure
done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I996a11f76fdc0c8babe0037219f5b43e45e459dd
Gerrit-Change-Number: 58104
Gerrit-PatchSet: 2
Gerrit-Owner: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Hou-hsun Lee <hou-hsun.lee(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hou-hsun Lee <hou-hsun.lee(a)intel.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Comment-Date: Thu, 07 Oct 2021 04:06:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment