Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58111 )
Change subject: mb/siemens/mc_ehl2: Set the suitable SPD data
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58111/comment/3f09d823_4937d167
PS2, Line 9: Since other LPDDR4X modules with memory down are used on this board
> How about: […]
Yes, you are right, that is better. Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/58111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb25f418952f0c96117140863d0d9c897d814ac5
Gerrit-Change-Number: 58111
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Thu, 07 Oct 2021 07:06:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Mario Scheithauer.
Hello build bot (Jenkins), Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58111
to look at the new patch set (#3).
Change subject: mb/siemens/mc_ehl2: Set the suitable SPD data
......................................................................
mb/siemens/mc_ehl2: Set the suitable SPD data
Since this variant uses different DDR4 devices compared to mc_ehl1 in a
memory down configuration, the SPD data file must be adapted.
Change-Id: Icb25f418952f0c96117140863d0d9c897d814ac5
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/spd/mc_ehl2.spd.hex
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/58111/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/58111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb25f418952f0c96117140863d0d9c897d814ac5
Gerrit-Change-Number: 58111
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Mario Scheithauer.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58111 )
Change subject: mb/siemens/mc_ehl2: Set the suitable SPD data
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58111/comment/d19e1fb7_d15458d6
PS2, Line 9: Since other LPDDR4X modules with memory down are used on this board
How about:
'Since this variant uses different DDR4 devices compared to mc_ehl1 in a memory down configuration'
?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb25f418952f0c96117140863d0d9c897d814ac5
Gerrit-Change-Number: 58111
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Comment-Date: Thu, 07 Oct 2021 06:59:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Jan Dabros.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 )
Change subject: tests: Add lib/lzma-test test case
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/57555
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id75e0b41991382d4c391b031862106de58eacdf7
Gerrit-Change-Number: 57555
Gerrit-PatchSet: 7
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Comment-Date: Thu, 07 Oct 2021 06:56:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Julius Werner, Andrey Petrov, Yu-Ping Wu, Patrick Rudolph.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57951 )
Change subject: Revert "vboot_logic: Set VB2_CONTEXT_EC_TRUSTED in verstage_main"
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/57951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaeb1bf598047160f01e33ad0d9d004cad59e3f75
Gerrit-Change-Number: 57951
Gerrit-PatchSet: 2
Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 07 Oct 2021 06:51:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hsuan-ting Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/58107 )
Change subject: Update vboot submodule to upstream main
......................................................................
Abandoned
The commit of submodule vboot should be reverted
--
To view, visit https://review.coreboot.org/c/coreboot/+/58107
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b7c117aab3a680db292c38e1f7e635e8005ab1c
Gerrit-Change-Number: 58107
Gerrit-PatchSet: 1
Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: abandon
Attention is currently required from: Hsuan Ting Chen.
Hsuan-ting Chen has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/58156 )
Change subject: [WIP] mainboard/google: Add EC_IN_RW to the early gpio table
......................................................................
Removed reviewer Tim Wawrzynczak.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58156
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1bd26b0ed7c0ff23b5fbfa1b641c092c25f921c
Gerrit-Change-Number: 58156
Gerrit-PatchSet: 1
Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org>
Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Jan Dabros, Werner Zeh.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 )
Change subject: tests: Add lib/lzma-test test case
......................................................................
Patch Set 7:
(3 comments)
File tests/lib/lzma-test.c:
https://review.coreboot.org/c/coreboot/+/57555/comment/e8cf5cd1_13f525d7
PS6, Line 48: /* 9 -> strlen(".lzma.bin") */
> nit: Now that you have moved on to ARRAY_SIZE this '9' is a bit confusing.
Oh, thanks. I thought, I removed this comment.
https://review.coreboot.org/c/coreboot/+/57555/comment/475553c5_6caf5bc8
PS6, Line 81: test_free(s->raw_filename);
: test_free(s->comp_filename);
: test_free(s)
> How about calling teardown_ulzman_file() here?
Done
https://review.coreboot.org/c/coreboot/+/57555/comment/314f3af6_0e4791a9
PS6, Line 120: assert_non_null(raw_buf);
: assert_non_null(comp_buf);
> I guess this test is here for making sure that test_malloc was successful in getting some memory, ri […]
Good find. I forgot to check decomp_buf.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57555
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id75e0b41991382d4c391b031862106de58eacdf7
Gerrit-Change-Number: 57555
Gerrit-PatchSet: 7
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Thu, 07 Oct 2021 06:35:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment