coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5512 discussions

Change in coreboot[master]: security/vboot: Remove vb2ex_hwcrypto stubs
by Yu-Ping Wu (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Werner Zeh. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58095 ) Change subject: security/vboot: Remove vb2ex_hwcrypto stubs ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Is there a need to update the vboot git hassh for coreboot submodules first to have it included? No. The current vboot 13f601fbd4c1b128f333391e4552082594f0ff25 already contains CL:2353775. -- To view, visit https://review.coreboot.org/c/coreboot/+/58095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62bdc647eb3e34c581cc1b8d15e7f271211e6156 Gerrit-Change-Number: 58095 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 05:16:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/vboot: Remove vb2ex_hwcrypto stubs
by Werner Zeh (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Yu-Ping Wu. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58095 ) Change subject: security/vboot: Remove vb2ex_hwcrypto stubs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Is there a need to update the vboot git hassh for coreboot submodules first to have it included? -- To view, visit https://review.coreboot.org/c/coreboot/+/58095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62bdc647eb3e34c581cc1b8d15e7f271211e6156 Gerrit-Change-Number: 58095 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 05:08:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Add lib/lzma-test test case
by Werner Zeh (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Jakub Czapiga, Jan Dabros. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 ) Change subject: tests: Add lib/lzma-test test case ...................................................................... Patch Set 6: Code-Review+1 (3 comments) File tests/lib/lzma-test.c: https://review.coreboot.org/c/coreboot/+/57555/comment/99cc4885_608fdb9e PS6, Line 48: /* 9 -> strlen(".lzma.bin") */ nit: Now that you have moved on to ARRAY_SIZE this '9' is a bit confusing. https://review.coreboot.org/c/coreboot/+/57555/comment/614d88fb_58926cb9 PS6, Line 81: test_free(s->raw_filename); : test_free(s->comp_filename); : test_free(s) How about calling teardown_ulzman_file() here? https://review.coreboot.org/c/coreboot/+/57555/comment/8ac18415_480085ee PS6, Line 120: assert_non_null(raw_buf); : assert_non_null(comp_buf); I guess this test is here for making sure that test_malloc was successful in getting some memory, right? Then why not add the same test her for dcomp_buf? -- To view, visit https://review.coreboot.org/c/coreboot/+/57555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id75e0b41991382d4c391b031862106de58eacdf7 Gerrit-Change-Number: 57555 Gerrit-PatchSet: 6 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 05:06:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "mb/google/brya: Disable crashlog on brya"
by Name of user not set (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: vagdevi.p(a)intel.com. vagdevi.p(a)intel.com has removed 9elements QA from this change. ( https://review.coreboot.org/c/coreboot/+/57950 ) Change subject: Revert "mb/google/brya: Disable crashlog on brya" ...................................................................... Removed cc 9elements QA. -- To view, visit https://review.coreboot.org/c/coreboot/+/57950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f257c67cb078a633eb860b3872a13d55778b69e Gerrit-Change-Number: 57950 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: vagdevi.p(a)intel.com Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: Revert "mb/google/brya: Disable crashlog on brya"
by Name of user not set (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: vagdevi.p(a)intel.com. vagdevi.p(a)intel.com has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/57950 ) Change subject: Revert "mb/google/brya: Disable crashlog on brya" ...................................................................... Removed cc Paul Menzel. -- To view, visit https://review.coreboot.org/c/coreboot/+/57950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f257c67cb078a633eb860b3872a13d55778b69e Gerrit-Change-Number: 57950 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: vagdevi.p(a)intel.com Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: Revert "mb/google/brya: Disable crashlog on brya"
by Name of user not set (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: vagdevi.p(a)intel.com. vagdevi.p(a)intel.com has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/57950 ) Change subject: Revert "mb/google/brya: Disable crashlog on brya" ...................................................................... Removed reviewer Tim Wawrzynczak. -- To view, visit https://review.coreboot.org/c/coreboot/+/57950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f257c67cb078a633eb860b3872a13d55778b69e Gerrit-Change-Number: 57950 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: vagdevi.p(a)intel.com Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: Revert "mb/google/brya: Disable crashlog on brya"
by Name of user not set (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: vagdevi.p(a)intel.com, Tim Wawrzynczak. vagdevi.p(a)intel.com has removed Subrata Banik from this change. ( https://review.coreboot.org/c/coreboot/+/57950 ) Change subject: Revert "mb/google/brya: Disable crashlog on brya" ...................................................................... Removed reviewer Subrata Banik. -- To view, visit https://review.coreboot.org/c/coreboot/+/57950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f257c67cb078a633eb860b3872a13d55778b69e Gerrit-Change-Number: 57950 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: vagdevi.p(a)intel.com Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: Revert "mb/google/brya: Disable crashlog on brya"
by Name of user not set (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: vagdevi.p(a)intel.com, Tim Wawrzynczak, Subrata Banik. vagdevi.p(a)intel.com has removed Maulik V Vaghela from this change. ( https://review.coreboot.org/c/coreboot/+/57950 ) Change subject: Revert "mb/google/brya: Disable crashlog on brya" ...................................................................... Removed reviewer Maulik V Vaghela. -- To view, visit https://review.coreboot.org/c/coreboot/+/57950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f257c67cb078a633eb860b3872a13d55778b69e Gerrit-Change-Number: 57950 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: vagdevi.p(a)intel.com Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: Revert "mb/google/brya: Disable crashlog on brya"
by Name of user not set (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Maulik V Vaghela, vagdevi.p(a)intel.com, Tim Wawrzynczak, Subrata Banik. vagdevi.p(a)intel.com has removed Furquan Shaikh from this change. ( https://review.coreboot.org/c/coreboot/+/57950 ) Change subject: Revert "mb/google/brya: Disable crashlog on brya" ...................................................................... Removed reviewer Furquan Shaikh. -- To view, visit https://review.coreboot.org/c/coreboot/+/57950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f257c67cb078a633eb860b3872a13d55778b69e Gerrit-Change-Number: 57950 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: vagdevi.p(a)intel.com Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: soc/intel/dnv_ns: correct size of GPE0 registers in FADT
by Werner Zeh (Code Review) 07 Oct '21

07 Oct '21

Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58086 ) Change subject: soc/intel/dnv_ns: correct size of GPE0 registers in FADT ...................................................................... soc/intel/dnv_ns: correct size of GPE0 registers in FADT There are 4 GPE0 STS/EN register pairs, each 32 bit wide. However, SoC code sets a GPE0 block size of 4 byte length instead of 32 byte. The resulting value of `x_gpe0_blk.bit_with` is wrong, too (32 bit instead of 256 bit). Drop the overrides and let common ACPI code set the correct values based on `GPE0_REG_MAX`. Change-Id: I45ee0f6678784c292ee3ed3446bf3c0f2d53b633 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/58086 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/soc/intel/denverton_ns/acpi.c 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/src/soc/intel/denverton_ns/acpi.c b/src/soc/intel/denverton_ns/acpi.c index aa59aa8..574d106 100644 --- a/src/soc/intel/denverton_ns/acpi.c +++ b/src/soc/intel/denverton_ns/acpi.c @@ -101,7 +101,6 @@ /* Control Registers - Length */ fadt->pm2_cnt_len = 1; fadt->pm_tmr_len = 4; - fadt->gpe0_blk_len = 8; fadt->p_lvl2_lat = ACPI_FADT_C2_NOT_SUPPORTED; fadt->p_lvl3_lat = ACPI_FADT_C3_NOT_SUPPORTED; @@ -149,14 +148,6 @@ fadt->x_pm_tmr_blk.access_size = ACPI_ACCESS_SIZE_DWORD_ACCESS; fadt->x_pm_tmr_blk.addrl = fadt->pm_tmr_blk; fadt->x_pm_tmr_blk.addrh = 0x00; - - /* General-Purpose Event Registers */ - fadt->x_gpe0_blk.space_id = ACPI_ADDRESS_SPACE_IO; - fadt->x_gpe0_blk.bit_width = 64; /* EventStatus + EventEnable */ - fadt->x_gpe0_blk.bit_offset = 0; - fadt->x_gpe0_blk.access_size = ACPI_ACCESS_SIZE_BYTE_ACCESS; - fadt->x_gpe0_blk.addrl = fadt->gpe0_blk; - fadt->x_gpe0_blk.addrh = 0x00; } static acpi_tstate_t denverton_tss_table[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/58086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45ee0f6678784c292ee3ed3446bf3c0f2d53b633 Gerrit-Change-Number: 58086 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021