coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5512 discussions

Change in coreboot[master]: payloads: Allow selecting UefiPayload on ARM64 platforms
by Yu-Ping Wu (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer, Martin Roth, Rex-BC Chen, Paul Menzel, Julius Werner, Marty E. Plummer. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 ) Change subject: payloads: Allow selecting UefiPayload on ARM64 platforms ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 9 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 02:06:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: Allow selecting UefiPayload on ARM64 platforms
by Rex-BC Chen (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer, Martin Roth, Paul Menzel, Julius Werner, Marty E. Plummer. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 ) Change subject: payloads: Allow selecting UefiPayload on ARM64 platforms ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 9 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 01:42:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: Allow selecting UefiPayload on ARM64 platforms
by Rex-BC Chen (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer, Martin Roth, Paul Menzel, Julius Werner, Marty E. Plummer. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 ) Change subject: payloads: Allow selecting UefiPayload on ARM64 platforms ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58054/comment/4c3f85df_a2b6f16a PS8, Line 7: Add UefiPayload support to ARM64 platforms > nit: Since this doesn't add significant code changes, how about this? […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 9 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 01:41:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: Allow selecting UefiPayload on ARM64 platforms
by Rex-BC Chen (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Martin Roth, Rex-BC Chen, Paul Menzel, Julius Werner, Marty E. Plummer. Hello Hung-Te Lin, build bot (Jenkins), Martin Roth, Stefan Reinauer, Julius Werner, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58054 to look at the new patch set (#9). Change subject: payloads: Allow selecting UefiPayload on ARM64 platforms ...................................................................... payloads: Allow selecting UefiPayload on ARM64 platforms Some ARM64 platforms (e.g., MT8195) are now able to compile and run EDK2 (UefiPayload). As a result, we should allow selecting PAYLOAD_TIANOCORE for ARM64 platforms. TEST=show strings correctly. 1. make menuconfig 2. select Mainboard -> Vendor=Google, model=Cherry 3. select Payload -> Add a payload -> Tianocorepayload 4. make -j 5. build/cbfstool build/coreboot.rom extract --name fallback/payload --file out.elf -m arm64 6. file out.elf # ELF 64-bit LSB executable, ARM aarch64 7. strings out.elf | grep tianocore # lots of tianocore stuff Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 --- M payloads/external/tianocore/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58054/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 9 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Disable unused i2s pins for BT offload
by EricR Lai (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Sugnan Prabhu S. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58137 ) Change subject: mb/google/brya: Disable unused i2s pins for BT offload ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbc53848c6ad12e537216cac3c2871088c094f3d Gerrit-Change-Number: 58137 Gerrit-PatchSet: 1 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 01:28:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/mediatek/mt8195: fix misleading-indentation error
by Yu-Ping Wu (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58136 ) Change subject: vc/mediatek/mt8195: fix misleading-indentation error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I680e9e6fffaebb23bf1f156a7f614345e952ed95 Gerrit-Change-Number: 58136 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 01:24:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: Add UefiPayload support to ARM64 platforms
by Felix Singer (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Martin Roth, Rex-BC Chen, Paul Menzel, Julius Werner, Marty E. Plummer. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 ) Change subject: payloads: Add UefiPayload support to ARM64 platforms ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58054/comment/4a87f109_cbe7ccf4 PS8, Line 7: Add UefiPayload support to ARM64 platforms nit: Since this doesn't add significant code changes, how about this? Allow selecting UefiPayload on ARM64 platforms -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 8 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 01:17:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: cbgfx: Clear screen by memcpy
by Julius Werner (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58128 ) Change subject: libpayload: cbgfx: Clear screen by memcpy ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f08fb50faab48d3db6b61ae022af3226914f72b Gerrit-Change-Number: 58128 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 01:08:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: Add UefiPayload support to ARM64 platforms
by Hung-Te Lin (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Martin Roth, Rex-BC Chen, Paul Menzel, Julius Werner, Marty E. Plummer. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 ) Change subject: payloads: Add UefiPayload support to ARM64 platforms ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 8 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 00:56:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Enable touchpad
by Bernardo Perez Priego (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Bora Guvendik, Anil Kumar K, Tim Wawrzynczak, Selma Bensaid, Raju Rajakumar, Bernardo Perez Priego. Hello Bora Guvendik, build bot (Jenkins), Anil Kumar K, Tim Wawrzynczak, Selma Bensaid, Raju Rajakumar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57863 to look at the new patch set (#6). Change subject: mb/intel/adlrvp_m: Enable touchpad ...................................................................... mb/intel/adlrvp_m: Enable touchpad These changes include ELAN touchpad to ACPI tables and configure GPIO's. Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Change-Id: I78e5e133f7d3af47395819a79638a90fee4fd19e --- M src/mainboard/intel/adlrvp/devicetree_m.cb M src/mainboard/intel/adlrvp/gpio_m.c 2 files changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/57863/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/57863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78e5e133f7d3af47395819a79638a90fee4fd19e Gerrit-Change-Number: 57863 Gerrit-PatchSet: 6 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Raju Rajakumar <raju.rajakumar(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Raju Rajakumar <raju.rajakumar(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021