coreboot-gerrit September 2020

coreboot-gerrit@coreboot.org

1 participants
2628 discussions

Change in coreboot[master]: mb/Kconfig: add option for choosing the default state of s0ix
by Michael Niewöhner (Code Review) 19 Sep '20

19 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45542 ) Change subject: mb/Kconfig: add option for choosing the default state of s0ix ...................................................................... Patch Set 3: Code-Review-1 some boards have problems with s0ix enabled and need a workaround; see src/mainboard/google/volteer/dsdt.asl:38 for example. => having a Kconfig provides no advantage over devicetree option and may even cause more problems -- To view, visit https://review.coreboot.org/c/coreboot/+/45542 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a29cc1187ceb4f2ce9a6cc3deed8764e0f26691 Gerrit-Change-Number: 45542 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 19 Sep 2020 11:28:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/Kconfig: add option for choosing the default state of s0ix
by Michael Niewöhner (Code Review) 19 Sep '20

19 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Furquan Shaikh, Jeremy Soller, Duncan Laurie, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Aaron Durbin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45542 to look at the new patch set (#3). Change subject: mb/Kconfig: add option for choosing the default state of s0ix ...................................................................... mb/Kconfig: add option for choosing the default state of s0ix Add a Kconfig option to choose the default enablement state of s0ix. This is option is meant to replace the devicetree option `s0ix_enable`. The value gets overridden by the CMOS option, which gets added later in CB:45544. Change-Id: I3a29cc1187ceb4f2ce9a6cc3deed8764e0f26691 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/Kconfig 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/45542/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/45542 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a29cc1187ceb4f2ce9a6cc3deed8764e0f26691 Gerrit-Change-Number: 45542 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/*: add s0ix default state Kconfig
by Michael Niewöhner (Code Review) 19 Sep '20

19 Sep '20

1 0

Change in coreboot[master]: mb/*: add CMOS option for s0ix
by Michael Niewöhner (Code Review) 19 Sep '20

19 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Jeremy Soller, Paul Menzel, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45544 to look at the new patch set (#4). Change subject: mb/*: add CMOS option for s0ix ...................................................................... mb/*: add CMOS option for s0ix Add a new CMOS option for s0ix to the two boards that a) enable s0ix in the devicetree and b) have a CMOS option layout. This option gets used in CB:45545 to get the user choice from CMOS. Change-Id: I86fdc8dd41523b6e3af535e6a6f1e0a7460754b1 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/google/auron/cmos.layout M src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/45544/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/45544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86fdc8dd41523b6e3af535e6a6f1e0a7460754b1 Gerrit-Change-Number: 45544 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/{bdw,skl,apl,cnl,icl,jsl,tgl,elh}: switch to s0ix Kconfig
by Michael Niewöhner (Code Review) 19 Sep '20

19 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Jeremy Soller, Paul Menzel, Subrata Banik, Andrey Petrov, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45545 to look at the new patch set (#5). Change subject: soc/intel/{bdw,skl,apl,cnl,icl,jsl,tgl,elh}: switch to s0ix Kconfig ...................................................................... soc/intel/{bdw,skl,apl,cnl,icl,jsl,tgl,elh}: switch to s0ix Kconfig Switch from using the devicetree option `s0ix_enable` to using the new s0ix Kconfig `LOW_POWER_IDLE_STATES`. Change-Id: Ib594ce6da1dda4b548d2ceeec55ded59922d8eba Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/acpi.c M src/soc/intel/apollolake/chip.c M src/soc/intel/broadwell/acpi.c M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/acpi.c M src/soc/intel/cannonlake/finalize.c M src/soc/intel/cannonlake/fsp_params.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/include/intelblocks/acpi.h M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/elkhartlake/acpi.c M src/soc/intel/elkhartlake/finalize.c M src/soc/intel/icelake/Kconfig M src/soc/intel/icelake/acpi.c M src/soc/intel/icelake/finalize.c M src/soc/intel/icelake/fsp_params.c M src/soc/intel/jasperlake/Kconfig M src/soc/intel/jasperlake/acpi.c M src/soc/intel/jasperlake/finalize.c M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/acpi.c M src/soc/intel/skylake/chip.c M src/soc/intel/skylake/fadt.c M src/soc/intel/skylake/finalize.c M src/soc/intel/tigerlake/Kconfig M src/soc/intel/tigerlake/acpi.c M src/soc/intel/tigerlake/finalize.c 28 files changed, 57 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/45545/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/45545 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib594ce6da1dda4b548d2ceeec55ded59922d8eba Gerrit-Change-Number: 45545 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/*: drop obsolete devicetree option s0ix_enable
by Michael Niewöhner (Code Review) 19 Sep '20

19 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Michał Żygowski, Jeremy Soller, Paul Menzel, Subrata Banik, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45546 to look at the new patch set (#5). Change subject: mb/*: drop obsolete devicetree option s0ix_enable ...................................................................... mb/*: drop obsolete devicetree option s0ix_enable Drop the devicetree option `s0ix_enable` which got replaced by the Kconfig/CMOS-option combination, added in the previous changes. Change-Id: I498e6406ab79ffa5aedd4d243befcf02b1d9d8e1 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/google/auron/devicetree.cb M src/mainboard/google/auron/variants/buddy/overridetree.cb M src/mainboard/google/auron/variants/samus/overridetree.cb M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/fizz/variants/baseboard/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/octopus/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/nocturne/devicetree.cb M src/mainboard/google/poppy/variants/rammus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb M src/mainboard/google/reef/variants/baseboard/devicetree.cb M src/mainboard/google/reef/variants/coral/devicetree.cb M src/mainboard/google/reef/variants/pyro/devicetree.cb M src/mainboard/google/reef/variants/sand/devicetree.cb M src/mainboard/google/reef/variants/snappy/devicetree.cb M src/mainboard/google/sarien/variants/arcada/devicetree.cb M src/mainboard/google/sarien/variants/sarien/devicetree.cb M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb M src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb M src/mainboard/intel/coffeelake_rvp/variants/baseboard/devicetree.cb M src/mainboard/intel/coffeelake_rvp/variants/cfl_u/overridetree.cb M src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb M src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb M src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb M src/mainboard/protectli/vault_kbl/devicetree.cb M src/mainboard/purism/librem_whl/devicetree.cb M src/mainboard/supermicro/x11-lga1151-series/devicetree.cb M src/mainboard/system76/lemp9/devicetree.cb 39 files changed, 0 insertions(+), 105 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45546/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/45546 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I498e6406ab79ffa5aedd4d243befcf02b1d9d8e1 Gerrit-Change-Number: 45546 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/{bdw,skl,apl,cnl,icl,jsl,tgl,elh}: drop s0ix from devicetree
by Michael Niewöhner (Code Review) 19 Sep '20

19 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Jeremy Soller, Paul Menzel, Subrata Banik, Andrey Petrov, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45547 to look at the new patch set (#5). Change subject: soc/intel/{bdw,skl,apl,cnl,icl,jsl,tgl,elh}: drop s0ix from devicetree ...................................................................... soc/intel/{bdw,skl,apl,cnl,icl,jsl,tgl,elh}: drop s0ix from devicetree Drop the now obsolete devicetree option `s0ix_enable` from the SoCs, as it's not used anymore. Change-Id: Id353f8cdc09313b06f8fa875ab0b87149f2b5411 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/soc/intel/apollolake/chip.h M src/soc/intel/broadwell/chip.h M src/soc/intel/cannonlake/chip.h M src/soc/intel/elkhartlake/chip.h M src/soc/intel/icelake/chip.h M src/soc/intel/jasperlake/chip.h M src/soc/intel/skylake/chip.h M src/soc/intel/tigerlake/chip.h 8 files changed, 0 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/45547/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/45547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id353f8cdc09313b06f8fa875ab0b87149f2b5411 Gerrit-Change-Number: 45547 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/Kconfig: add option for choosing the default state of s0ix
by Michael Niewöhner (Code Review) 19 Sep '20

19 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Furquan Shaikh, Jeremy Soller, Duncan Laurie, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Aaron Durbin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45542 to look at the new patch set (#2). Change subject: mb/Kconfig: add option for choosing the default state of s0ix ...................................................................... mb/Kconfig: add option for choosing the default state of s0ix Add a Kconfig option to choose the default enablement state of s0ix. This is option is meant to replace the devicetree option `s0ix_enable`. Change-Id: I3a29cc1187ceb4f2ce9a6cc3deed8764e0f26691 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/Kconfig 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/45542/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/45542 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a29cc1187ceb4f2ce9a6cc3deed8764e0f26691 Gerrit-Change-Number: 45542 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/Kconfig: add option for selecting the default state of s0ix
by Angel Pons (Code Review) 19 Sep '20

19 Sep '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45542 ) Change subject: mb/Kconfig: add option for selecting the default state of s0ix ...................................................................... Patch Set 1: > Patch Set 1: > > I'm not sure if s0ix works regardless of hardware support. If s0ix doesn't require the mainboard to wire something in a certain way, then we can have a prompt in Kconfig to choose whether to enable it. I'd also add a Kconfig so that mainboards can easily enable s0ix by default, but without force-enabling s0ix as a plain `select` would. If hardware support is required, then one would have a Kconfig symbol to indicate a mainboard supports s0ix, and another one (that could just default to y) to let the user choose whether to enable it (I assume that non-s0ix would always work) > > Does anyone happen to know if s0ix depends on whether mainboard designs implement something? Please ignore this. -- To view, visit https://review.coreboot.org/c/coreboot/+/45542 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a29cc1187ceb4f2ce9a6cc3deed8764e0f26691 Gerrit-Change-Number: 45542 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 19 Sep 2020 10:15:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/*: add CMOS option for s0ix
by Michael Niewöhner (Code Review) 19 Sep '20

19 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Jeremy Soller, Paul Menzel, Subrata Banik, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45544 to look at the new patch set (#2). Change subject: mb/*: add CMOS option for s0ix ...................................................................... mb/*: add CMOS option for s0ix Add a new CMOS option for s0ix to the two boards that a) enable s0ix in the devicetree and b) have a CMOS option layout. Change-Id: I86fdc8dd41523b6e3af535e6a6f1e0a7460754b1 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/google/auron/cmos.layout M src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/45544/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/45544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86fdc8dd41523b6e3af535e6a6f1e0a7460754b1 Gerrit-Change-Number: 45544 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2020