Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45513 )
Change subject: lint: check for misuse of Kconfig SUBSYSTEM_*_ID
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/check_lint_tests
File util/lint/check_lint_tests:
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/check_lint_tests…
PS4, Line 50: #lint-stable-024-kconfig-no-subsystem
> Hm, I did this because #lint-stable-008-kconfig is there, too, but now realized nr. […]
yup, works without. see CB:45513
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/lint-stable-024-…
File util/lint/lint-stable-024-kconfig-no-subsystem:
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/lint-stable-024-…
PS4, Line 11: D
> End with `\>` to make the match exact?
Done
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/lint-stable-024-…
PS4, Line 11: ^
> I'd make it `^\s*` (could be indented)
Done
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/lint-stable-024-…
PS4, Line 12: %%/
> uhm oh, does "it was late" count as as answer? ;)
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/45513
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21c021c718154f1396f795a555af47a76d6efe03
Gerrit-Change-Number: 45513
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Elyes HAOUAS
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 19 Sep 2020 16:47:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Hello Felix Singer, Elyes HAOUAS, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi, Paul Menzel, Duncan Laurie, Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45513
to look at the new patch set (#6).
Change subject: lint: check for misuse of Kconfig SUBSYSTEM_*_ID
......................................................................
lint: check for misuse of Kconfig SUBSYSTEM_*_ID
Check that nobody misuses the Kconfigs SUBSYSTEM_*_ID. They are meant to
be used for overriding the devicetree subsystem ids locally but shall
not be added to a board's Kconfig. Instead, the devicetree option
`subsystemid` should be used.
Add a linter script for this that finds and warns about such misuse.
Also add a note in the Kconfigs' description.
TEST=CB:45513
Change-Id: I21c021c718154f1396f795a555af47a76d6efe03
Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
---
M src/device/Kconfig
A util/lint/lint-stable-024-kconfig-no-subsystem
2 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/45513/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/45513
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21c021c718154f1396f795a555af47a76d6efe03
Gerrit-Change-Number: 45513
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Elyes HAOUAS
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45513 )
Change subject: lint: check for misuse of Kconfig SUBSYSTEM_*_ID
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/check_lint_tests
File util/lint/check_lint_tests:
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/check_lint_tests…
PS4, Line 50: #lint-stable-024-kconfig-no-subsystem
> Why mention it here, is this file parsed somewhere? (beside the shell)
Hm, I did this because #lint-stable-008-kconfig is there, too, but now realized nr. 007 is missing, so let's try to drop that
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/lint-stable-024-…
File util/lint/lint-stable-024-kconfig-no-subsystem:
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/lint-stable-024-…
PS4, Line 12: %%/
> Why was the / added in the first place?
uhm oh, does "it was late" count as as answer? ;)
--
To view, visit https://review.coreboot.org/c/coreboot/+/45513
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21c021c718154f1396f795a555af47a76d6efe03
Gerrit-Change-Number: 45513
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Elyes HAOUAS
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 19 Sep 2020 16:30:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Hello Felix Singer, Elyes HAOUAS, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi, Paul Menzel, Duncan Laurie, Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45513
to look at the new patch set (#5).
Change subject: lint: check for misuse of Kconfig SUBSYSTEM_*_ID
......................................................................
lint: check for misuse of Kconfig SUBSYSTEM_*_ID
Check that nobody misuses the Kconfigs SUBSYSTEM_*_ID. They are meant to
be used for overriding the devicetree subsystem ids locally but shall
not be added to a board's Kconfig. Instead, the devicetree option
`subsystemid` should be used.
Add a linter script for this that finds and warns about such misuse.
Also add a note in the Kconfigs' description.
Change-Id: I21c021c718154f1396f795a555af47a76d6efe03
Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
---
M src/device/Kconfig
A util/lint/lint-stable-024-kconfig-no-subsystem
2 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/45513/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/45513
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21c021c718154f1396f795a555af47a76d6efe03
Gerrit-Change-Number: 45513
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Elyes HAOUAS
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45528 )
Change subject: mb/system76/lemp9: move subsystem id from Kconfig to devicetree
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/45528
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21e7e53787b115f50093d7caa72285ce480cef52
Gerrit-Change-Number: 45528
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 19 Sep 2020 14:28:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45527 )
Change subject: mb/up/squared: move subsystem id from Kconfig to devicetree
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/45527
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf62a73ee568d9369c53bd767bd4cfb736ea76f1
Gerrit-Change-Number: 45527
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 19 Sep 2020 14:27:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment