Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45513 )
Change subject: lint: check for misuse of Kconfig SUBSYSTEM_*_ID
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/check_lint_tests
File util/lint/check_lint_tests:
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/check_lint_tests@...
PS4, Line 50: #lint-stable-024-kconfig-no-subsystem
Why mention it here, is this file parsed somewhere? (beside the shell)
Hm, I did this because #lint-stable-008-kconfig is there, too, but now realized nr. 007 is missing, so let's try to drop that
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/lint-stable-024-k...
File util/lint/lint-stable-024-kconfig-no-subsystem:
https://review.coreboot.org/c/coreboot/+/45513/4/util/lint/lint-stable-024-k...
PS4, Line 12: %%/
Why was the / added in the first place?
uhm oh, does "it was late" count as as answer? ;)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45513
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21c021c718154f1396f795a555af47a76d6efe03
Gerrit-Change-Number: 45513
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Elyes HAOUAS
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 19 Sep 2020 16:30:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment