Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45542 )
Change subject: mb/Kconfig: add option for selecting the default state of s0ix
......................................................................
Patch Set 1:
Patch Set 1:
I'm not sure if s0ix works regardless of hardware support. If s0ix doesn't require the mainboard to wire something in a certain way, then we can have a prompt in Kconfig to choose whether to enable it. I'd also add a Kconfig so that mainboards can easily enable s0ix by default, but without force-enabling s0ix as a plain `select` would. If hardware support is required, then one would have a Kconfig symbol to indicate a mainboard supports s0ix, and another one (that could just default to y) to let the user choose whether to enable it (I assume that non-s0ix would always work)
Does anyone happen to know if s0ix depends on whether mainboard designs implement something?
Please ignore this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45542
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a29cc1187ceb4f2ce9a6cc3deed8764e0f26691
Gerrit-Change-Number: 45542
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 19 Sep 2020 10:15:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment