Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48431 )
Change subject: soc/amd/stoneyridge/southbridge: make sb_disable_4dw_burst static
......................................................................
soc/amd/stoneyridge/southbridge: make sb_disable_4dw_burst static
sb_disable_4dw_burst is only used in the same compilation unit, so no
need to make it externally visible.
Change-Id: I6c7c96f67b98fb8ed808f45a7685c4d72a10d32c
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/soc/amd/stoneyridge/include/soc/southbridge.h
M src/soc/amd/stoneyridge/southbridge.c
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/48431/1
diff --git a/src/soc/amd/stoneyridge/include/soc/southbridge.h b/src/soc/amd/stoneyridge/include/soc/southbridge.h
index d346197..e0ffd61 100644
--- a/src/soc/amd/stoneyridge/include/soc/southbridge.h
+++ b/src/soc/amd/stoneyridge/include/soc/southbridge.h
@@ -248,7 +248,6 @@
void enable_aoac_devices(void);
void sb_clk_output_48Mhz(u32 osc);
-void sb_disable_4dw_burst(void);
void sb_enable(struct device *dev);
void southbridge_final(void *chip_info);
void southbridge_init(void *chip_info);
diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c
index 7661607..8815702 100644
--- a/src/soc/amd/stoneyridge/southbridge.c
+++ b/src/soc/amd/stoneyridge/southbridge.c
@@ -255,7 +255,7 @@
spi_write16(SPI100_ENABLE, SPI_USE_SPI100);
}
-void sb_disable_4dw_burst(void)
+static void sb_disable_4dw_burst(void)
{
spi_write16(SPI100_HOST_PREF_CONFIG,
spi_read16(SPI100_HOST_PREF_CONFIG) & ~SPI_RD4DW_EN_HOST);
--
To view, visit https://review.coreboot.org/c/coreboot/+/48431
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c7c96f67b98fb8ed808f45a7685c4d72a10d32c
Gerrit-Change-Number: 48431
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28101 )
Change subject: Makefile: Add $(xcompile) to specify where to write xcompile
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/28101/11/Makefile
File Makefile:
https://review.coreboot.org/c/coreboot/+/28101/11/Makefile@154
PS11, Line 154: util/xcompile/xcompile $(XGCCPATH) > $(xcompile) || rm -f $(xcompile)))
Should we redirect stderr to /dev/null just in case? The `include` below
should give a reasonable error message if something goes wrong but any
output of the `$(shell )` call would likely result in a mess.
--
To view, visit https://review.coreboot.org/c/coreboot/+/28101
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia83f234447b977efa824751c9674154b77d606b0
Gerrit-Change-Number: 28101
Gerrit-PatchSet: 11
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Raul Rangel <rrangel(a)google.com>
Gerrit-Comment-Date: Tue, 08 Dec 2020 23:49:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48186 )
Change subject: soc/intel/tigerlake: Enable support for extended BIOS window
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48186/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48186/4//COMMIT_MSG@13
PS4, Line 13: BUG=b:171534504
Waiting to land the earlier patches in chromium tree and then I will cherry-pick rest of the changes here to ensure I can set up Cq-Depend correctly.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48186
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I039155506380310cf867f5f8c5542278be40838a
Gerrit-Change-Number: 48186
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 08 Dec 2020 22:59:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48190 )
Change subject: mb/google/deltaur: Restrict RW_DIAG to lower 16MiB
......................................................................
mb/google/deltaur: Restrict RW_DIAG to lower 16MiB
This change restricts RW_DIAG region to lower 16MiB to ensure that the
extended BIOS checker for FMAP does not complain about 16MiB boundary
crossing.
I haven't updated any other regions to occupy the newly freed space
but it is fine since this board is dead and should be dropped from
coreboot soon.
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
Change-Id: I19ab204fbe3e020e42baf68bfa350dcff32066a3
---
M src/mainboard/google/deltaur/chromeos.fmd
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/48190/1
diff --git a/src/mainboard/google/deltaur/chromeos.fmd b/src/mainboard/google/deltaur/chromeos.fmd
index bbec112..a84a448 100644
--- a/src/mainboard/google/deltaur/chromeos.fmd
+++ b/src/mainboard/google/deltaur/chromeos.fmd
@@ -6,9 +6,9 @@
SI_PDR(PRESERVE)@0x602000 0x4000
}
SI_BIOS@0x606000 0x19fa000 {
- RW_DIAG@0x0 0x10ca000 {
- RW_LEGACY(CBFS)@0x0 0x10ba000
- DIAG_NVRAM@0x10ba000 0x10000
+ RW_DIAG@0x0 0x9fa000 {
+ RW_LEGACY(CBFS)@0x0 0x9ea000
+ DIAG_NVRAM@0x9ea000 0x10000
}
RW_SECTION_A@0x10ca000 0x280000 {
VBLOCK_A@0x0 0x10000
--
To view, visit https://review.coreboot.org/c/coreboot/+/48190
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19ab204fbe3e020e42baf68bfa350dcff32066a3
Gerrit-Change-Number: 48190
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: newchange
Srinidhi N Kaushik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47991 )
Change subject: soc/intel/common/fast_spi: Add support for configuring MTRRs
......................................................................
soc/intel/common/fast_spi: Add support for configuring MTRRs
This change enables caching for extended BIOS region.
Currently, caching is enabled for the standard BIOS region
upto a maximum of 16MiB using fast_spi_cache_bios_region,
used the same function to add the support for caching for
extended BIOS region as well.
Changes include:
1. Add a new helper function fast_spi_cache_ext_bios_region()
which calls fast_spi_get_ext_bios_window() to get details
about the extended BIOS window from the boot media map.
2. Make a call to fast_spi_cache_ext_bios_region() from
fast_spi_cache_bios_region ().
3. If the extended window is used, then it enables caching
for this window similar to how it is done for the standard window.
BUG=b:171534504
Signed-off-by: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Change-Id: I9711f110a35a167efe3a4c912cf46c63c0812779
---
M src/soc/intel/common/block/fast_spi/fast_spi.c
1 file changed, 37 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/47991/1
diff --git a/src/soc/intel/common/block/fast_spi/fast_spi.c b/src/soc/intel/common/block/fast_spi/fast_spi.c
index a3ec0d7..d5c6218 100644
--- a/src/soc/intel/common/block/fast_spi/fast_spi.c
+++ b/src/soc/intel/common/block/fast_spi/fast_spi.c
@@ -213,6 +213,40 @@
return bios_start;
}
+static void fast_spi_cache_ext_bios_window(void)
+{
+
+ size_t ext_bios_size;
+ uint32_t alignment;
+ uintptr_t ext_bios_base;
+ const int type = MTRR_TYPE_WRPROT;
+
+ if (!CONFIG(FAST_SPI_SUPPORTS_EXT_BIOS_WINDOW))
+ return;
+
+ fast_spi_get_ext_bios_window(&ext_bios_base, &ext_bios_size);
+
+ /* Enable extended bios only if Size of Bios region is greater than 16MiB */
+ if (ext_bios_size == 0 || ext_bios_base == 0)
+ return;
+
+ /* Round to power of two */
+ alignment = 1UL << (log2_ceil(ext_bios_size));
+ ext_bios_size = ALIGN_UP(ext_bios_size, alignment);
+ ext_bios_base = ALIGN_DOWN(ext_bios_base, ext_bios_size);
+
+ if (ENV_PAYLOAD_LOADER) {
+ mtrr_use_temp_range(ext_bios_base, ext_bios_size, type);
+ } else {
+ int mtrr = get_free_var_mtrr();
+
+ if (mtrr == -1)
+ return;
+
+ set_var_mtrr(mtrr, ext_bios_base, ext_bios_size, type);
+ }
+}
+
void fast_spi_cache_bios_region(void)
{
size_t bios_size;
@@ -246,6 +280,9 @@
set_var_mtrr(mtrr, base, bios_size, type);
}
+
+ /* Check if caching is needed for extended bios region if supported */
+ fast_spi_cache_ext_bios_window();
}
/* Enable extended bios support
--
To view, visit https://review.coreboot.org/c/coreboot/+/47991
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9711f110a35a167efe3a4c912cf46c63c0812779
Gerrit-Change-Number: 47991
Gerrit-PatchSet: 1
Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange