Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47358 )
Change subject: mb/google/volteer: Create drobit variant
......................................................................
Patch Set 2:
This CL is create for issue root cause investigation .
--
To view, visit https://review.coreboot.org/c/coreboot/+/47358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3dca73dea26c0d267d8e0e725d712f750810b06
Gerrit-Change-Number: 47358
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 09 Nov 2020 07:50:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47252 )
Change subject: mb/purism/librem_mini: drop PcieRpSlotImplemented from LAN PCIe
......................................................................
mb/purism/librem_mini: drop PcieRpSlotImplemented from LAN PCIe
The LAN NIC is onboard, not installed in a slot.
Change-Id: I77ee7ee8c944b7942ca78d35cd881277c4030ab9
Signed-off-by: Matt DeVillier <matt.devillier(a)puri.sm>
---
M src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/47252/1
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb
index 1a1c466..9b231a8 100644
--- a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb
+++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb
@@ -202,7 +202,6 @@
device pci 1d.0 off end # PCI Express Port 9
device pci 1d.1 on # PCI Express Port 10
device pci 00.0 on end # x1 (LAN)
- register "PcieRpSlotImplemented[9]" = "1"
register "PcieRpEnable[9]" = "1"
register "PcieClkSrcUsage[3]" = "9"
register "PcieClkSrcClkReq[3]" = "3"
--
To view, visit https://review.coreboot.org/c/coreboot/+/47252
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77ee7ee8c944b7942ca78d35cd881277c4030ab9
Gerrit-Change-Number: 47252
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47251 )
Change subject: mb/purism/librem_mini: Update smbios_slot_desc for M.2/WLAN
......................................................................
mb/purism/librem_mini: Update smbios_slot_desc for M.2/WLAN
Add strings for M.2 keying and number of PCIe lanes.
Change-Id: I2e13749b50263ee5c2388a419bc8d784af6bd880
Signed-off-by: Matt DeVillier <matt.devillier(a)puri.sm>
---
M src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/47251/1
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb
index e02586c..1a1c466 100644
--- a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb
+++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb
@@ -197,7 +197,7 @@
register "PcieRpLtrEnable[7]" = "1"
# ClkSrcUsage must be set to free-run since SRCCLKREQ2 is NC
register "PcieClkSrcUsage[2]" = "0x80"
- smbios_slot_desc "SlotTypeM2Socket1_SD" "SlotLengthOther"
+ smbios_slot_desc "SlotTypeM2Socket1_SD" "SlotLengthOther" "M.2/E 2230 (WLAN)" "SlotDataBusWidth1X"
end
device pci 1d.0 off end # PCI Express Port 9
device pci 1d.1 on # PCI Express Port 10
--
To view, visit https://review.coreboot.org/c/coreboot/+/47251
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e13749b50263ee5c2388a419bc8d784af6bd880
Gerrit-Change-Number: 47251
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Bryant Ou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45405 )
Change subject: drivers/uart: Override uart base address
......................................................................
drivers/uart: Override uart base address
Add CONFIG_UART_OVERRIDE_BASE_ADDR to select the function, platform
overrides the base address by providing a uart_platform_base routine.
Signed-off-by: Bryant Ou <Bryant.Ou.Q(a)gmail.com>
Change-Id: I2079bd1e5ffa209553383b6aafe3b8724849ba2a
---
M src/drivers/uart/Kconfig
M src/drivers/uart/uart8250io.c
2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/45405/1
diff --git a/src/drivers/uart/Kconfig b/src/drivers/uart/Kconfig
index 41b870f..9cbb359 100644
--- a/src/drivers/uart/Kconfig
+++ b/src/drivers/uart/Kconfig
@@ -33,6 +33,13 @@
Set to "y" when the platform overrides the uart_platform_refclk
routine.
+config UART_OVERRIDE_BASE_ADDR
+ bool
+ default n
+ help
+ Set to "y" when the platform overrides the base address by providing
+ a uart_platform_base routine.
+
config DRIVERS_UART_8250MEM
bool
default n
diff --git a/src/drivers/uart/uart8250io.c b/src/drivers/uart/uart8250io.c
index d0841de..c5317af 100644
--- a/src/drivers/uart/uart8250io.c
+++ b/src/drivers/uart/uart8250io.c
@@ -75,6 +75,7 @@
ENABLE_TRACE;
}
+#if !CONFIG(UART_OVERRIDE_BASE_ADDR)
static const unsigned int bases[] = { 0x3f8, 0x2f8, 0x3e8, 0x2e8 };
uintptr_t uart_platform_base(unsigned int idx)
@@ -83,6 +84,7 @@
return bases[idx];
return 0;
}
+#endif
void uart_init(unsigned int idx)
{
--
To view, visit https://review.coreboot.org/c/coreboot/+/45405
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2079bd1e5ffa209553383b6aafe3b8724849ba2a
Gerrit-Change-Number: 45405
Gerrit-PatchSet: 1
Gerrit-Owner: Bryant Ou <bryant.ou.q(a)gmail.com>
Gerrit-MessageType: newchange
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47274 )
Change subject: soc/amd/common: add Kconfig help text to pre-family-17h-only blocks
......................................................................
soc/amd/common: add Kconfig help text to pre-family-17h-only blocks
The cpu/car code only applies to pre-familiy-17h CPUs that still use
cache as RAM (CAR) and the PI code only applies to the pre-FSP vendor
code blob binaryPI interface.
Change-Id: I5a13d7e202bb745255fabb46110850c36b07de7a
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/soc/amd/common/block/cpu/Kconfig
M src/soc/amd/common/block/pi/Kconfig
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/47274/1
diff --git a/src/soc/amd/common/block/cpu/Kconfig b/src/soc/amd/common/block/cpu/Kconfig
index 5941599..f6756e1 100644
--- a/src/soc/amd/common/block/cpu/Kconfig
+++ b/src/soc/amd/common/block/cpu/Kconfig
@@ -8,3 +8,6 @@
it may not be appropriate for a romstage implementation without
additional consideration. If this option is not used, the SOC must
implement these functions separately.
+ This is only used for AMD CPU before family 17h. From family 17h on
+ the RAM is already initialized by the PSP before the x86 cores are
+ released from reset.
diff --git a/src/soc/amd/common/block/pi/Kconfig b/src/soc/amd/common/block/pi/Kconfig
index f0917bb..cf8c79a 100644
--- a/src/soc/amd/common/block/pi/Kconfig
+++ b/src/soc/amd/common/block/pi/Kconfig
@@ -3,7 +3,8 @@
select HAVE_DEBUG_RAM_SETUP
default n
help
- This option builds functions that interface AMD's AGESA.
+ This option builds functions that interface AMD's AGESA reference
+ code packaged in the binaryPI form.
if SOC_AMD_COMMON_BLOCK_PI
--
To view, visit https://review.coreboot.org/c/coreboot/+/47274
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a13d7e202bb745255fabb46110850c36b07de7a
Gerrit-Change-Number: 47274
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange