Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47314 )
Change subject: util/intelp2m: Cleanup SCI, SMI macro generation and update comments
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47314/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47314/4//COMMIT_MSG@7
PS4, Line 7: Cleanup
The verb is spelled with a space: Clean up.
https://review.coreboot.org/c/coreboot/+/47314/4//COMMIT_MSG@9
PS4, Line 9: fix-up
fix up
https://review.coreboot.org/c/coreboot/+/47314/4//COMMIT_MSG@10
PS4, Line 10: CB:45008
As git is operated using commit SHA’s, it’d be great if you could add that hash too.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47314
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie49874d4abbdc7d1a18d63a62ccbce970ce78233
Gerrit-Change-Number: 47314
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 12 Nov 2020 07:29:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46231 )
Change subject: soc/intel/xeon_sp: Enable SMI handler
......................................................................
Patch Set 26:
> Patch Set 24:
>
> > Patch Set 24:
> >
> > (1 comment)
> >
> > Does the TCO, gnvs, and smbsus changes belong in this patch? Maybe explain in the commit message if they do.
>
> soc/intel/common has some dependencies which is what I suspect drove those changes. IDK if there is even TCO on these? GNVS is fully broken on this platform, but needs separate fixing (or actual implementing). No idea about smbus.
>
> I have some local improvements I want to push soon, like less skx/cpx boilerplate + proper IED handling. So maybe hold off on merging for a day or two?
TCO is not used, but the common block code assumes the support is there. Hence, I had to put in the ifdef's. Regarding, smbus.h, it's required by common block SMM code also.
--
To view, visit https://review.coreboot.org/c/coreboot/+/46231
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabee5c72f0245ab988d477ac8df3d8d655a2a506
Gerrit-Change-Number: 46231
Gerrit-PatchSet: 26
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 12 Nov 2020 05:29:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45024 )
Change subject: libpayload/usb: Fix printf format string mismatches in debug messages
......................................................................
Patch Set 3:
question for the reviewers:
should we reflow the affected areas to fit within 96 columns
to keep buildbot happy? i'm not convinced that aggressively
splitting format strings improves this patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4dc70baefb3cd82fcc915cc2e7f68719cf6870cc
Gerrit-Change-Number: 45024
Gerrit-PatchSet: 3
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 12 Nov 2020 00:05:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment