Change in coreboot[master]: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level tr...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: Delete...

Chen Wisley (Code Review)

6 Nov 2020 6 Nov '20

9:33 a.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47292 )

Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................

mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger

Per elan request, change to level trigger to fix touchscreen function lost.

BUG=none TEST=emerge-dedede coreboot

Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/47292/1

diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index 5942121..ff2a02a 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -199,7 +199,7 @@ chip drivers/i2c/hid register "generic.hid" = ""ELAN2513"" register "generic.desc" = ""ELAN Touchscreen"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D5)" register "generic.reset_delay_ms" = "20"

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Chen Wisley (Code Review)

6 Nov 6 Nov

2:45 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47292

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................

mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger

Per elan request, change to level trigger to fix touchscreen function lost.

BUG=b:172642296 TEST=emerge-dedede coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/47292/2

Furquan Shaikh (Code Review)

5:21 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47292 )

Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... PS2, Line 202: ACPI_IRQ_LEVEL_LOW Does this device use level triggered interrupts as per the datasheet? I think most ELAN devices use edge-triggered. So, want to make sure we are not working around some other problem.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Fri, 06 Nov 2020 17:21:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

9 Nov 9 Nov

10:09 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47292 )

Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... PS2, Line 202: ACPI_IRQ_LEVEL_LOW

...

Does this device use level triggered interrupts as per the datasheet? I think most ELAN devices use […]

Elan uploaded doc in tracker. It use level trigger in "ACPI Setting Reference" page.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Mon, 09 Nov 2020 10:09:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:03 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47292 )

Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47292/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47292/2//COMMIT_MSG@9 PS2, Line 9: Per elan request, change to level trigger to fix touchscreen function lost Can you please add the following detail to the commit message:

ELAN touchscreen device used on drawcia is I2C-HID device and as per "HID over I2C Protocol Specification"[1] Version 1.00 Section 7.4, the interrupt line used by the device is expected to be level triggered. Hence, this change updates the configuration of the touchscreen interrupt to be level triggered.

References: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d...

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... PS2, Line 202: ACPI_IRQ_LEVEL_LOW

...

Elan uploaded doc in tracker. It use level trigger in "ACPI Setting Reference" page.

Thanks for the reference Wisley! Can you please update the commit message as per the comment provided? Thanks!

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Mon, 09 Nov 2020 20:03:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Chen Wisley wisley.chen@quantatw.com Gerrit-MessageType: comment

Chen Wisley (Code Review)

10 Nov 10 Nov

4:32 p.m.

Hello build bot (Jenkins), Henry Sun, Justin TerAvest, Wisley Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47292

to look at the new patch set (#3).

Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................

mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger

References: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d... hid-over-i2c-protocol-spec-v1-0.docx

BUG=b:172642296 TEST=emerge-dedede coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/47292/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

4:36 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47292 )

Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47292/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47292/3//COMMIT_MSG@15 PS3, Line 15: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d... : hid-over-i2c-protocol-spec-v1-0.docx Nit: I think we can have greater than 72 characters for URLs. Otherwise the link looks broken.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Tue, 10 Nov 2020 16:36:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

4:36 p.m.

Hello build bot (Jenkins), Henry Sun, Justin TerAvest, Wisley Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47292

to look at the new patch set (#4).

Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................

mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger

References: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d...

BUG=b:172642296 TEST=emerge-dedede coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/47292/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

4:52 p.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47292 )

Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/47292/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47292/2//COMMIT_MSG@9 PS2, Line 9: Per elan request, change to level trigger to fix touchscreen function lost

...

Can you please add the following detail to the commit message: […]

Done, thanks

https://review.coreboot.org/c/coreboot/+/47292/3//COMMIT_MSG Commit Message:

...

Nit: I think we can have greater than 72 characters for URLs. Otherwise the link looks broken.

Done, thanks

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... PS2, Line 202: ACPI_IRQ_LEVEL_LOW

...

Thanks for the reference Wisley! Can you please update the commit message as per the comment provide […]

Done, thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Tue, 10 Nov 2020 16:52:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Chen Wisley wisley.chen@quantatw.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

6:03 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47292 )

Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... PS2, Line 174: ACPI_IRQ_EDGE_LOW This too.

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... PS2, Line 188: ACPI_IRQ_EDGE_LOW This needs update too.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Tue, 10 Nov 2020 18:03:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

11 Nov 11 Nov

2:37 p.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Change I2C-HID touchscreen to level tri...

Hello build bot (Jenkins), Henry Sun, Justin TerAvest, Wisley Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47292

to look at the new patch set (#5).

Change subject: mb/google/dedede/var/drawcia: Change I2C-HID touchscreen to level trigger ......................................................................

mb/google/dedede/var/drawcia: Change I2C-HID touchscreen to level trigger

ELAN/Goodix/G2Touch touchscreen device used on drawcia/drawman is I2C-HID device and as per "HID over I2C Protocol Specification"[1] Version 1.00 Section 7.4, the interrupt line used by the device is expected to be level triggered. Hence, this change updates the configuration of the touchscreen interrupt to be level triggered.

References: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d...

BUG=b:172642296 TEST=emerge-dedede coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/47292/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 5 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

2:41 p.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Change I2C-HID touchscreen to level tri...

Hello build bot (Jenkins), Henry Sun, Justin TerAvest, Wisley Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47292

to look at the new patch set (#6).

Change subject: mb/google/dedede/var/drawcia: Change I2C-HID touchscreen to level trigger ......................................................................

mb/google/dedede/var/drawcia: Change I2C-HID touchscreen to level trigger

References: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d...

BUG=b:172642296 TEST=emerge-dedede coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/47292/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 6 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

3:33 p.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Change I2C-HID touchscreen to level tri...

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47292 )

Change subject: mb/google/dedede/var/drawcia: Change I2C-HID touchscreen to level trigger ......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... PS2, Line 174: ACPI_IRQ_EDGE_LOW

...

This too.

Done

https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... PS2, Line 188: ACPI_IRQ_EDGE_LOW

...

This needs update too.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 6 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Wed, 11 Nov 2020 15:33:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Chen Wisley (Code Review)

12 Nov 12 Nov

1:59 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Change I2C-HID touchscreen to level tri...

Chen Wisley has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47292 )

Change subject: mb/google/dedede/var/drawcia: Change I2C-HID touchscreen to level trigger ......................................................................

Abandoned

abandon this CL, due to Karthik already submited CL*47415 for all dedede

-- To view, visit https://review.coreboot.org/c/coreboot/+/47292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f Gerrit-Change-Number: 47292 Gerrit-PatchSet: 6 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1284

days inactive

1290

days old

coreboot-gerrit@coreboot.org

13 comments

3 participants

tags (0)

participants (3)

Chen Wisley (Code Review)
Furquan Shaikh (Code Review)
Karthik Ramasubramanian (Code Review)