build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45024 )
Change subject: libpayload/usb: Fix printf format string mismatches in debug messages ......................................................................
Patch Set 3:
(10 comments)
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/ehci.c:
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... PS3, Line 55: usb_debug("|:| Alt. Next qTD [0x%08"PRIx32"] |:|\n", td->alt_next_qtd); line over 96 characters
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... PS3, Line 57: usb_debug("|:| | Bytes to Transfer |[%05"PRId32"] |:|\n", (td->token & QTD_TOTAL_LEN_MASK) >> 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... PS3, Line 282: if (0) usb_debug("\nmoving from %p to %p\n", cur, phys_to_virt(cur->next_qtd)); trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/ohci.c:
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... PS3, Line 72: usb_debug("|:| Current Buffer Pointer [0x%08"PRIx32"] |:|\n", cur->current_buffer_pointer); line over 96 characters
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... PS3, Line 76: usb_debug("|:| Current Buffer End [0x%08"PRIx32"] |:|\n", cur->buffer_end); line over 96 characters
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... PS3, Line 93: usb_debug("| O | Function Address | [%04"PRIx32"] |\n", cur->config & 0x7F); line over 96 characters
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... PS3, Line 471: usb_debug("ohci_control(): doing transfer with %x. first_td at %"PRIxPTR"\n", Prefer using '"%s...", __func__' to using 'ohci_control', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... PS3, Line 509: usb_debug("bulk: %x bytes from %p, finalize: %x, maxpacketsize: %x\n", dalen, src, finalize, ep->maxpacketsize); line over 96 characters
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/uhci.c:
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... PS3, Line 82: usb_debug("|:| O | PID CODE | [%04"PRIx32"] |:|\n", td->token & 0xFF); line over 96 characters
https://review.coreboot.org/c/coreboot/+/45024/3/payloads/libpayload/drivers... PS3, Line 83: usb_debug("|:| K | Endpoint | [%04"PRIx32"] |:|\n", (td->token & TD_EP_MASK) >> TD_EP_SHIFT); line over 96 characters